From: Jens Axboe <axboe@kernel.dk>
To: Simao Gomes Viana <devel@superboring.dev>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch
Date: Fri, 19 Jun 2020 15:26:41 -0600 [thread overview]
Message-ID: <f1dea27d-9262-f818-20a2-e77098dbb27f@kernel.dk> (raw)
In-Reply-To: <20200619180834.8032-1-devel@superboring.dev>
On 6/19/20 12:08 PM, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.
>
> Before:
> drivers/cdrom/cdrom.c:
> total: 118 errors, 126 warnings, 3794 lines checked
> drivers/cdrom/gdrom.c:
> total: 0 errors, 16 warnings, 873 lines checked
>
> After:
> drivers/cdrom/cdrom.c:
> total: 0 errors, 38 warnings, 3866 lines checked
> drivers/cdrom/gdrom.c:
> total: 0 errors, 3 warnings, 882 lines checked
>
> Test: scripts/checkpatch.pl --file drivers/cdrom/*.c
> Test: make drivers/cdrom/cdrom.o
> Test: make CONFIG_GDROM=y drivers/cdrom/gdrom.o # partial
> Test: compiles, boots on 5.7.4
> Test: CD ROM works (tested with Audio CD)
Let's please not do this, it's a lot of churn for zero gain.
--
Jens Axboe
prev parent reply other threads:[~2020-06-19 21:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 18:08 Simao Gomes Viana
2020-06-19 18:08 ` [PATCH 2/2] drivers: cdrom: add missing SPDX license identifier Simao Gomes Viana
2020-06-19 18:29 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Joe Perches
2020-06-19 18:41 ` Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 1/9] drivers: cdrom: fix horizontal whitespace Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 2/9] drivers: cdrom: fix comment style Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 3/9] drivers: cdrom: replace func name by __func__ Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 4/9] drivers: cdrom: rewrite embedded assignments in multiple lines Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 5/9] drivers: cdrom: swap sides of comparison Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 6/9] drivers: cdrom: add missing newlines (vertical space) Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 7/9] drivers: cdrom: miscellaneous code style fixes Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 8/9] drivers: cdrom: change unsigned to unsigned int Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 9/9] drivers: cdrom: fix spacing and wrapping Simao Gomes Viana
2020-06-19 21:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1dea27d-9262-f818-20a2-e77098dbb27f@kernel.dk \
--to=axboe@kernel.dk \
--cc=arnd@arndb.de \
--cc=devel@superboring.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome