From: Joe Perches <joe@perches.com>
To: Simao Gomes Viana <devel@superboring.dev>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch
Date: Fri, 19 Jun 2020 11:29:59 -0700 [thread overview]
Message-ID: <f6102c402ae3f4232aebf4e102953f21fdb86cf6.camel@perches.com> (raw)
In-Reply-To: <20200619180834.8032-1-devel@superboring.dev>
On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.
This is too many changes in a single patch to verify
them easily.
If you really want to change this file, and it's likely
not particularly necessary, I suggest that you send a
patch series that where each patch individually does:
1: Horizontal whitespace only changes
o Trim trailing whitespace
o Add alignment whitespace
o Add operator spacing whitespace
2: Vertical whitespace changes if any
3: Convert embedded assignments to multiple lines
4: Comment style updates
And whatever other specific style changes necessary
to properly and easily identify them as correct.
next prev parent reply other threads:[~2020-06-19 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 18:08 Simao Gomes Viana
2020-06-19 18:08 ` [PATCH 2/2] drivers: cdrom: add missing SPDX license identifier Simao Gomes Viana
2020-06-19 18:29 ` Joe Perches [this message]
2020-06-19 18:41 ` Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 1/9] drivers: cdrom: fix horizontal whitespace Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 2/9] drivers: cdrom: fix comment style Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 3/9] drivers: cdrom: replace func name by __func__ Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 4/9] drivers: cdrom: rewrite embedded assignments in multiple lines Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 5/9] drivers: cdrom: swap sides of comparison Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 6/9] drivers: cdrom: add missing newlines (vertical space) Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 7/9] drivers: cdrom: miscellaneous code style fixes Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 8/9] drivers: cdrom: change unsigned to unsigned int Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 9/9] drivers: cdrom: fix spacing and wrapping Simao Gomes Viana
2020-06-19 21:26 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6102c402ae3f4232aebf4e102953f21fdb86cf6.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=devel@superboring.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®