mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simao Gomes Viana <devel@superboring.dev>
To: linux-kernel@vger.kernel.org
Cc: Simao Gomes Viana <devel@superboring.dev>, Joe Perches <joe@perches.com>
Subject: [PATCH 7/9] drivers: cdrom: miscellaneous code style fixes
Date: Fri, 19 Jun 2020 21:33:39 +0200	[thread overview]
Message-ID: <20200619193341.51209-7-devel@superboring.dev> (raw)
In-Reply-To: <20200619193341.51209-1-devel@superboring.dev>

These were mainly reported by scripts/checkpatch.pl

Signed-off-by: Simao Gomes Viana <devel@superboring.dev>
---
 drivers/cdrom/cdrom.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index f1c02d4d5583..6ff8da08230c 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -1093,7 +1093,7 @@ int open_for_data(struct cdrom_device_info *cdi)
 
 			/* Ok, the door should be closed now.. Check again */
 			ret = cdo->drive_status(cdi, CDSL_CURRENT);
-			if ((ret == CDS_NO_DISC) || (ret==CDS_TRAY_OPEN)) {
+			if (ret == CDS_NO_DISC || ret == CDS_TRAY_OPEN) {
 				cd_dbg(CD_OPEN, "bummer. the tray is still not closed.\n");
 				cd_dbg(CD_OPEN, "tray might not contain a medium\n");
 				ret = -ENOMEDIUM;
@@ -1242,8 +1242,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi,
 		if (ret == CDS_TRAY_OPEN) {
 			cd_dbg(CD_OPEN, "the tray is open...\n");
 			/* can/may i close it? */
-			if (CDROM_CAN(CDC_CLOSE_TRAY) &&
-			    cdi->options & CDO_AUTO_CLOSE) {
+			if (CDROM_CAN(CDC_CLOSE_TRAY) && cdi->options & CDO_AUTO_CLOSE) {
 				cd_dbg(CD_OPEN, "trying to close the tray\n");
 				ret = cdo->tray_move(cdi, 0);
 				if (ret) {
@@ -1471,11 +1470,10 @@ static int cdrom_select_disc(struct cdrom_device_info *cdi, int slot)
 	kfree(info);
 
 	if (cdi->use_count > 1 || cdi->keeplocked) {
-		if (slot == CDSL_CURRENT) {
-	    		return curslot;
-		} else {
+		if (slot == CDSL_CURRENT)
+			return curslot;
+		else
 			return -EBUSY;
-		}
 	}
 
 	/* Specifying CDSL_CURRENT will attempt to load the currnet slot,
@@ -3015,13 +3013,12 @@ static int cdrom_get_next_writable(struct cdrom_device_info *cdi,
 
 use_last_written:
 	ret = cdrom_get_last_written(cdi, next_writable);
-	if (ret) {
+	if (ret)
 		*next_writable = 0;
-		return ret;
-	} else {
+	else
 		*next_writable += 7;
-		return 0;
-	}
+
+	return ret;
 }
 
 static noinline int mmc_ioctl_cdrom_read_data(struct cdrom_device_info *cdi,
-- 
2.27.0


  parent reply	other threads:[~2020-06-19 19:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 18:08 [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Simao Gomes Viana
2020-06-19 18:08 ` [PATCH 2/2] drivers: cdrom: add missing SPDX license identifier Simao Gomes Viana
2020-06-19 18:29 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Joe Perches
2020-06-19 18:41   ` Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 1/9] drivers: cdrom: fix horizontal whitespace Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 2/9] drivers: cdrom: fix comment style Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 3/9] drivers: cdrom: replace func name by __func__ Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 4/9] drivers: cdrom: rewrite embedded assignments in multiple lines Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 5/9] drivers: cdrom: swap sides of comparison Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 6/9] drivers: cdrom: add missing newlines (vertical space) Simao Gomes Viana
2020-06-19 19:33   ` Simao Gomes Viana [this message]
2020-06-19 19:33   ` [PATCH 8/9] drivers: cdrom: change unsigned to unsigned int Simao Gomes Viana
2020-06-19 19:33   ` [PATCH 9/9] drivers: cdrom: fix spacing and wrapping Simao Gomes Viana
2020-06-19 21:26 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619193341.51209-7-devel@superboring.dev \
    --to=devel@superboring.dev \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome