* [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV
@ 2020-09-04 13:06 Wang Hai
2020-09-04 13:26 ` Willem de Bruijn
0 siblings, 1 reply; 3+ messages in thread
From: Wang Hai @ 2020-09-04 13:06 UTC (permalink / raw)
To: davem, kuba, willemb, john.ogness, maowenan, jrosen, arnd,
colin.king, edumazet
Cc: netdev, linux-kernel
BPDU_TYPE_TCN is never used after it was introduced.
So better to remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/packet/af_packet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index da8254e680f9..c430672c6a67 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
#define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len)
#define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num)
#define BLOCK_O2PRIV(x) ((x)->offset_to_priv)
-#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x)))
struct packet_sock;
static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV
2020-09-04 13:06 [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV Wang Hai
@ 2020-09-04 13:26 ` Willem de Bruijn
2020-09-05 3:00 ` wanghai (M)
0 siblings, 1 reply; 3+ messages in thread
From: Willem de Bruijn @ 2020-09-04 13:26 UTC (permalink / raw)
To: Wang Hai
Cc: David Miller, Jakub Kicinski, John Ogness, Mao Wenan, jrosen,
Arnd Bergmann, Colin King, Eric Dumazet, Network Development,
linux-kernel
On Fri, Sep 4, 2020 at 3:09 PM Wang Hai <wanghai38@huawei.com> wrote:
>
> BPDU_TYPE_TCN is never used after it was introduced.
> So better to remove it.
This comment does not cover the patch contents. Otherwise the patch
looks good to me.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> net/packet/af_packet.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index da8254e680f9..c430672c6a67 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
> #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len)
> #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num)
> #define BLOCK_O2PRIV(x) ((x)->offset_to_priv)
> -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x)))
>
> struct packet_sock;
> static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV
2020-09-04 13:26 ` Willem de Bruijn
@ 2020-09-05 3:00 ` wanghai (M)
0 siblings, 0 replies; 3+ messages in thread
From: wanghai (M) @ 2020-09-05 3:00 UTC (permalink / raw)
To: Willem de Bruijn
Cc: David Miller, Jakub Kicinski, John Ogness, Mao Wenan, jrosen,
Arnd Bergmann, Colin King, Eric Dumazet, Network Development,
linux-kernel
在 2020/9/4 21:26, Willem de Bruijn 写道:
> On Fri, Sep 4, 2020 at 3:09 PM Wang Hai <wanghai38@huawei.com> wrote:
>> BPDU_TYPE_TCN is never used after it was introduced.
>> So better to remove it.
> This comment does not cover the patch contents. Otherwise the patch
> looks good to me.
Thanks for your review, I will revise this comment.
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>> ---
>> net/packet/af_packet.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
>> index da8254e680f9..c430672c6a67 100644
>> --- a/net/packet/af_packet.c
>> +++ b/net/packet/af_packet.c
>> @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
>> #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len)
>> #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num)
>> #define BLOCK_O2PRIV(x) ((x)->offset_to_priv)
>> -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x)))
>>
>> struct packet_sock;
>> static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
>> --
>> 2.17.1
>>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-05 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 13:06 [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV Wang Hai
2020-09-04 13:26 ` Willem de Bruijn
2020-09-05 3:00 ` wanghai (M)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®