From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: peterz@infradead.org
Cc: mingo@kernel.org, vincent.guittot@linaro.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bristot@redhat.com, swood@redhat.com,
valentin.schneider@arm.com
Subject: Re: [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run during hotplug
Date: Wed, 16 Sep 2020 15:58:17 +0200 [thread overview]
Message-ID: <20200916135817.3djsqmziqvzo6hmq@flow> (raw)
In-Reply-To: <20200916121020.GP2674@hirez.programming.kicks-ass.net>
On 2020-09-16 14:10:20 [+0200], peterz@infradead.org wrote:
squeeze that in please:
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a4fe22b8b8418..bed3cd28af578 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6866,7 +6866,7 @@ static int __balance_push_cpu_stop(void *arg)
raw_spin_lock_irq(&p->pi_lock);
rq_lock(rq, &rf);
- update_rq_clock();
+ update_rq_clock(rq);
if (task_rq(p) == rq && task_on_rq_queued(p)) {
cpu = select_fallback_rq(rq->cpu, p);
and count me in :)
Sebastian
next prev parent reply other threads:[~2020-09-16 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 8:17 [PATCH 0/2] sched: migrate_disable() preparations Peter Zijlstra
2020-09-11 8:17 ` [PATCH 1/2] sched: Fix balance_callback() Peter Zijlstra
2020-09-11 12:17 ` Valentin Schneider
2020-09-11 12:25 ` peterz
2020-09-11 13:27 ` Valentin Schneider
2020-09-11 8:17 ` [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run during hotplug Peter Zijlstra
2020-09-11 12:17 ` Valentin Schneider
2020-09-11 12:29 ` peterz
2020-09-11 13:48 ` Valentin Schneider
2020-09-16 10:18 ` Sebastian Andrzej Siewior
2020-09-16 12:10 ` peterz
2020-09-16 13:58 ` Sebastian Andrzej Siewior [this message]
2020-09-16 14:07 ` peterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916135817.3djsqmziqvzo6hmq@flow \
--to=sebastian@breakpoint.cc \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®