* [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment
@ 2020-11-13 8:34 xiakaixu1987
2020-11-16 7:48 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-11-13 8:34 UTC (permalink / raw)
To: kishon, vkoul; +Cc: linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable error is overwritten by the following call
devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the
value assignment is useless. Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
index 5172971..24ab848 100644
--- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
+++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
@@ -421,7 +421,6 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
dev_info(ddata->dev, "Powered up OK\n");
} else {
ddata->enabled = false;
- error = -ETIMEDOUT;
dev_err(ddata->dev, "Timed out powering up\n");
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment
2020-11-13 8:34 [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment xiakaixu1987
@ 2020-11-16 7:48 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-11-16 7:48 UTC (permalink / raw)
To: xiakaixu1987; +Cc: kishon, linux-kernel, Kaixu Xia
On 13-11-20, 16:34, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The value of variable error is overwritten by the following call
> devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the
> value assignment is useless. Remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> index 5172971..24ab848 100644
> --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> @@ -421,7 +421,6 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
> dev_info(ddata->dev, "Powered up OK\n");
> } else {
> ddata->enabled = false;
> - error = -ETIMEDOUT;
> dev_err(ddata->dev, "Timed out powering up\n");
Maybe the right fix is adding return error here..?
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 8:34 [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment xiakaixu1987
2020-11-16 7:48 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®