* [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties
@ 2020-11-30 17:00 Bjorn Andersson
2020-11-30 17:25 ` Steev Klimaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2020-11-30 17:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Steev Klimaszewski, Shawn Guo
Cc: Rob Herring, Vinod Koul, linux-arm-msm, devicetree, linux-kernel
The "pins" property takes an array of pin _names_, not pin numbers. Fix
this.
Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 399aef2a0951..bb314973eb0c 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -432,7 +432,7 @@ &tlmm {
gpio-reserved-ranges = <0 4>, <81 4>;
i2c3_hid_active: i2c2-hid-active {
- pins = <37>;
+ pins = "gpio37";
function = "gpio";
input-enable;
@@ -441,7 +441,7 @@ i2c3_hid_active: i2c2-hid-active {
};
i2c5_hid_active: i2c5-hid-active {
- pins = <125>;
+ pins = "gpio125";
function = "gpio";
input-enable;
@@ -450,7 +450,7 @@ i2c5_hid_active: i2c5-hid-active {
};
i2c11_hid_active: i2c11-hid-active {
- pins = <92>;
+ pins = "gpio92";
function = "gpio";
input-enable;
@@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active {
};
wcd_intr_default: wcd_intr_default {
- pins = <54>;
+ pins = "gpio54";
function = "gpio";
input-enable;
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties
2020-11-30 17:00 [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties Bjorn Andersson
@ 2020-11-30 17:25 ` Steev Klimaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Steev Klimaszewski @ 2020-11-30 17:25 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Shawn Guo
Cc: Rob Herring, Vinod Koul, linux-arm-msm, devicetree, linux-kernel
On 11/30/20 11:00 AM, Bjorn Andersson wrote:
> The "pins" property takes an array of pin _names_, not pin numbers. Fix
> this.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 399aef2a0951..bb314973eb0c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -432,7 +432,7 @@ &tlmm {
> gpio-reserved-ranges = <0 4>, <81 4>;
>
> i2c3_hid_active: i2c2-hid-active {
> - pins = <37>;
> + pins = "gpio37";
> function = "gpio";
>
> input-enable;
> @@ -441,7 +441,7 @@ i2c3_hid_active: i2c2-hid-active {
> };
>
> i2c5_hid_active: i2c5-hid-active {
> - pins = <125>;
> + pins = "gpio125";
> function = "gpio";
>
> input-enable;
> @@ -450,7 +450,7 @@ i2c5_hid_active: i2c5-hid-active {
> };
>
> i2c11_hid_active: i2c11-hid-active {
> - pins = <92>;
> + pins = "gpio92";
> function = "gpio";
>
> input-enable;
> @@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active {
> };
>
> wcd_intr_default: wcd_intr_default {
> - pins = <54>;
> + pins = "gpio54";
> function = "gpio";
>
> input-enable;
Tested-by: Steev Klimaszewski <steev@kali.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30 17:00 [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties Bjorn Andersson
2020-11-30 17:25 ` Steev Klimaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®