* [PATCH] selftests/seccomp: Update kernel config
@ 2020-12-02 16:26 Mickaël Salaün
2020-12-02 19:22 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Mickaël Salaün @ 2020-12-02 16:26 UTC (permalink / raw)
To: Kees Cook, Shuah Khan
Cc: Mickaël Salaün, linux-kernel, linux-kselftest,
Mickaël Salaün, Tycho Andersen
From: Mickaël Salaün <mic@linux.microsoft.com>
seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
to be set.
Cc: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>
Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
Acked-by: Tycho Andersen <tycho@tycho.pizza>
---
Previous version:
https://lore.kernel.org/lkml/20201030121819.764395-1-mic@digikod.net/
Changes since v1:
* Add Acked-by: Tycho Andersen <tycho@tycho.pizza>
* Synchronize From and Signed-off-by emails.
---
tools/testing/selftests/seccomp/config | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
index 64c19d8eba79..ad431a5178fb 100644
--- a/tools/testing/selftests/seccomp/config
+++ b/tools/testing/selftests/seccomp/config
@@ -1,3 +1,4 @@
+CONFIG_PID_NS=y
CONFIG_SECCOMP=y
CONFIG_SECCOMP_FILTER=y
CONFIG_USER_NS=y
base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
--
2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/seccomp: Update kernel config
2020-12-02 16:26 [PATCH] selftests/seccomp: Update kernel config Mickaël Salaün
@ 2020-12-02 19:22 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2020-12-02 19:22 UTC (permalink / raw)
To: Mickaël Salaün, Shuah Khan
Cc: Kees Cook, linux-kselftest, linux-kernel, Tycho Andersen,
Mickaël Salaün
On Wed, 2 Dec 2020 17:26:43 +0100, Mickaël Salaün wrote:
> seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
> to be set.
Applied to for-next/seccomp, thanks!
[1/1] selftests/seccomp: Update kernel config
https://git.kernel.org/kees/c/2c07343abd89
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] selftests/seccomp: Update kernel config
@ 2020-10-30 12:18 Mickaël Salaün
2020-11-10 21:36 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Mickaël Salaün @ 2020-10-30 12:18 UTC (permalink / raw)
To: Kees Cook, Shuah Khan
Cc: Mickaël Salaün, linux-kernel, linux-kselftest,
Tycho Andersen, Mickaël Salaün
seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
to be set.
Cc: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Tycho Andersen <tycho@tycho.pizza>
Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
---
tools/testing/selftests/seccomp/config | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
index 64c19d8eba79..ad431a5178fb 100644
--- a/tools/testing/selftests/seccomp/config
+++ b/tools/testing/selftests/seccomp/config
@@ -1,3 +1,4 @@
+CONFIG_PID_NS=y
CONFIG_SECCOMP=y
CONFIG_SECCOMP_FILTER=y
CONFIG_USER_NS=y
base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
--
2.28.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/seccomp: Update kernel config
2020-10-30 12:18 Mickaël Salaün
@ 2020-11-10 21:36 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2020-11-10 21:36 UTC (permalink / raw)
To: Mickaël Salaün, Kees Cook, Shuah Khan
Cc: linux-kernel, linux-kselftest, Tycho Andersen,
Mickaël Salaün, Shuah Khan
On 10/30/20 6:18 AM, Mickaël Salaün wrote:
> seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
> to be set.
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Tycho Andersen <tycho@tycho.pizza>
> Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> ---
> tools/testing/selftests/seccomp/config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
> index 64c19d8eba79..ad431a5178fb 100644
> --- a/tools/testing/selftests/seccomp/config
> +++ b/tools/testing/selftests/seccomp/config
> @@ -1,3 +1,4 @@
> +CONFIG_PID_NS=y
> CONFIG_SECCOMP=y
> CONFIG_SECCOMP_FILTER=y
> CONFIG_USER_NS=y
>
> base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
>
Your from and Signed-off-by don't match. Please send the patch
from your igned-off-by address.
WARNING: From:/Signed-off-by: email address mismatch: 'From: "Mickaël
Salaün" <mic@digikod.net>' != 'Signed-off-by: Mickaël Salaün
<mic@linux.microsoft.com>'
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-02 19:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 16:26 [PATCH] selftests/seccomp: Update kernel config Mickaël Salaün
2020-12-02 19:22 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 12:18 Mickaël Salaün
2020-11-10 21:36 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®