From: James Morse <james.morse@arm.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
James Morse <james.morse@arm.com>,
shameerali.kolothum.thodi@huawei.com,
D Scott Phillips OS <scott@os.amperecomputing.com>,
carl@os.amperecomputing.com, lcherian@marvell.com,
bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
Jamie Iles <quic_jiles@quicinc.com>,
Xin Hao <xhao@linux.alibaba.com>,
xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com,
peternewman@google.com
Subject: [PATCH 12/18] x86/resctrl: Move alloc/mon static keys into helpers
Date: Fri, 21 Oct 2022 13:11:58 +0000 [thread overview]
Message-ID: <20221021131204.5581-13-james.morse@arm.com> (raw)
In-Reply-To: <20221021131204.5581-1-james.morse@arm.com>
resctrl enables three static keys depending on the features it has enabled.
Another architecture's context switch code may look different, any
static keys that control it should be buried behind helpers.
Move the alloc/mon logic into arch-specific helpers as a preparatory step
for making the rdt_enable_key's status something the arch code decides.
This means other architectures don't have to mirror the static keys.
Signed-off-by: James Morse <james.morse@arm.com>
---
arch/x86/include/asm/resctrl.h | 20 ++++++++++++++++++++
arch/x86/kernel/cpu/resctrl/internal.h | 5 -----
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 8 ++++----
3 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
index 4ce1376525e3..ae3a87100626 100644
--- a/arch/x86/include/asm/resctrl.h
+++ b/arch/x86/include/asm/resctrl.h
@@ -37,6 +37,26 @@ DECLARE_STATIC_KEY_FALSE(rdt_enable_key);
DECLARE_STATIC_KEY_FALSE(rdt_alloc_enable_key);
DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
+static inline void resctrl_arch_enable_alloc(void)
+{
+ static_branch_enable_cpuslocked(&rdt_alloc_enable_key);
+}
+
+static inline void resctrl_arch_disable_alloc(void)
+{
+ static_branch_disable_cpuslocked(&rdt_alloc_enable_key);
+}
+
+static inline void resctrl_arch_enable_mon(void)
+{
+ static_branch_enable_cpuslocked(&rdt_mon_enable_key);
+}
+
+static inline void resctrl_arch_disable_mon(void)
+{
+ static_branch_disable_cpuslocked(&rdt_mon_enable_key);
+}
+
/*
* __resctrl_sched_in() - Writes the task's CLOSid/RMID to IA32_PQR_MSR
*
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index a1f5bfdc62cc..f7ea5432cbdb 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -57,9 +57,6 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)
return container_of(kfc, struct rdt_fs_context, kfc);
}
-DECLARE_STATIC_KEY_FALSE(rdt_enable_key);
-DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
-
/**
* struct mon_evt - Entry in the event list of a resource
* @evtid: event id
@@ -415,8 +412,6 @@ extern struct mutex rdtgroup_mutex;
extern struct rdt_hw_resource rdt_resources_all[];
extern struct rdtgroup rdtgroup_default;
-DECLARE_STATIC_KEY_FALSE(rdt_alloc_enable_key);
-
extern struct dentry *debugfs_resctrl;
enum resctrl_res_level {
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 89ce5ac7de35..bd2489bae7cf 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2244,9 +2244,9 @@ static int rdt_get_tree(struct fs_context *fc)
goto out_psl;
if (rdt_alloc_capable)
- static_branch_enable_cpuslocked(&rdt_alloc_enable_key);
+ resctrl_arch_enable_alloc();
if (rdt_mon_capable)
- static_branch_enable_cpuslocked(&rdt_mon_enable_key);
+ resctrl_arch_enable_mon();
if (rdt_alloc_capable || rdt_mon_capable) {
static_branch_enable_cpuslocked(&rdt_enable_key);
@@ -2515,8 +2515,8 @@ static void rdt_kill_sb(struct super_block *sb)
rdt_pseudo_lock_release();
rdtgroup_default.mode = RDT_MODE_SHAREABLE;
schemata_list_destroy();
- static_branch_disable_cpuslocked(&rdt_alloc_enable_key);
- static_branch_disable_cpuslocked(&rdt_mon_enable_key);
+ resctrl_arch_disable_alloc();
+ resctrl_arch_disable_mon();
static_branch_disable_cpuslocked(&rdt_enable_key);
resctrl_mounted = false;
kernfs_kill_sb(sb);
--
2.30.2
next prev parent reply other threads:[~2022-10-21 13:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:11 [PATCH 00/18] x86/resctrl: monitored closid+rmid together, separate arch/fs locking James Morse
2022-10-21 13:11 ` [PATCH 01/18] x86/resctrl: Track the closid with the rmid James Morse
2022-10-31 14:42 ` Peter Newman
2022-11-25 4:07 ` haoxin
2023-01-06 2:57 ` Yu, Fenghua
2023-01-10 17:57 ` James Morse
2023-01-10 18:01 ` Yu, Fenghua
2022-10-21 13:11 ` [PATCH 02/18] x86/resctrl: Access per-rmid structures by index James Morse
2023-01-06 3:12 ` Yu, Fenghua
2023-01-10 17:57 ` James Morse
2022-10-21 13:11 ` [PATCH 03/18] x86/resctrl: Create helper for RMID allocation and mondata dir creation James Morse
2023-01-06 3:23 ` Yu, Fenghua
2023-01-10 17:57 ` James Morse
2022-10-21 13:11 ` [PATCH 04/18] x86/resctrl: Move rmid allocation out of mkdir_rdt_prepare() James Morse
2022-11-10 10:50 ` Shaopeng Tan (Fujitsu)
2022-11-24 14:21 ` James Morse
2022-10-21 13:11 ` [PATCH 05/18] x86/resctrl: Allow RMID allocation to be scoped by CLOSID James Morse
2022-10-21 13:11 ` [PATCH 06/18] x86/resctrl: Allow the allocator to check if a CLOSID can allocate clean RMID James Morse
2022-11-08 15:57 ` Shawn Wang
2022-11-09 17:02 ` James Morse
2022-11-10 10:50 ` Shaopeng Tan (Fujitsu)
2022-11-24 14:21 ` James Morse
2022-10-21 13:11 ` [PATCH 07/18] x86/resctrl: Move CLOSID/RMID matching and setting to use helpers James Morse
2022-11-18 15:49 ` Valentin Schneider
2022-11-24 14:21 ` James Morse
2022-10-21 13:11 ` [PATCH 08/18] x86/resctrl: Queue mon_event_read() instead of sending an IPI James Morse
2022-10-21 13:11 ` [PATCH 09/18] x86/resctrl: Allow resctrl_arch_rmid_read() to sleep James Morse
2022-10-21 13:11 ` [PATCH 10/18] x86/resctrl: Allow arch to allocate memory needed in resctrl_arch_rmid_read() James Morse
2022-10-21 13:11 ` [PATCH 11/18] x86/resctrl: Make resctrl_mounted checks explicit James Morse
2022-10-21 13:11 ` James Morse [this message]
2022-10-21 13:11 ` [PATCH 13/18] x86/resctrl: Make rdt_enable_key the arch's decision to switch James Morse
2022-10-21 13:12 ` [PATCH 14/18] x86/resctrl: Add helpers for system wide mon/alloc capable James Morse
2022-11-10 10:51 ` Shaopeng Tan (Fujitsu)
2022-11-24 14:22 ` James Morse
2022-10-21 13:12 ` [PATCH 15/18] x86/resctrl: Add cpu online callback for resctrl work James Morse
2022-10-21 13:12 ` [PATCH 16/18] x86/resctrl: Allow overflow/limbo handlers to be scheduled on any-but cpu James Morse
2022-10-21 13:12 ` [PATCH 17/18] x86/resctrl: Add cpu offline callback for resctrl work James Morse
2022-10-21 13:12 ` [PATCH 18/18] x86/resctrl: Separate arch and fs resctrl locks James Morse
2022-10-31 14:21 ` Peter Newman
2022-11-09 17:18 ` James Morse
2022-11-01 8:01 ` [PATCH 00/18] x86/resctrl: monitored closid+rmid together, separate arch/fs locking Shaopeng Tan (Fujitsu)
2022-11-09 17:21 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021131204.5581-13-james.morse@arm.com \
--to=james.morse@arm.com \
--cc=Babu.Moger@amd.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=carl@os.amperecomputing.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=xingxin.hx@openanolis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®