* [PATCH] iommu/renesas: Support riscv compile
@ 2022-12-15 7:32 guoren
2022-12-15 17:16 ` Robin Murphy
0 siblings, 1 reply; 3+ messages in thread
From: guoren @ 2022-12-15 7:32 UTC (permalink / raw)
To: palmer, prabhakar.mahadev-lad.rj
Cc: linux-kernel, linux-riscv, iommu, Guo Ren, kernel test robot, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM
dependency here.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
---
drivers/iommu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index dc5f7a156ff5..746b95b9f345 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
config IPMMU_VMSA
bool "Renesas VMSA-compatible IPMMU"
+ depends on ARM64 || ARM
depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
select IOMMU_API
select IOMMU_IO_PGTABLE_LPAE
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/renesas: Support riscv compile
2022-12-15 7:32 [PATCH] iommu/renesas: Support riscv compile guoren
@ 2022-12-15 17:16 ` Robin Murphy
2022-12-16 1:32 ` Guo Ren
0 siblings, 1 reply; 3+ messages in thread
From: Robin Murphy @ 2022-12-15 17:16 UTC (permalink / raw)
To: guoren, palmer, prabhakar.mahadev-lad.rj
Cc: linux-kernel, linux-riscv, iommu, Guo Ren, kernel test robot
On 2022-12-15 07:32, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM
> dependency here.
This effectively removes all the extra COMPILE_TEST coverage we've been
enjoying. FWIW I prefer Geert's suggestion to separate the real
functional dependency from implicit assumptions about ARCH_RENESAS, with
something like:
depends on ARCH_RENESAS || COMPILE_TEST
depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE
Thanks,
Robin.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> ---
> drivers/iommu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dc5f7a156ff5..746b95b9f345 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
>
> config IPMMU_VMSA
> bool "Renesas VMSA-compatible IPMMU"
> + depends on ARM64 || ARM
> depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/renesas: Support riscv compile
2022-12-15 17:16 ` Robin Murphy
@ 2022-12-16 1:32 ` Guo Ren
0 siblings, 0 replies; 3+ messages in thread
From: Guo Ren @ 2022-12-16 1:32 UTC (permalink / raw)
To: Robin Murphy
Cc: palmer, prabhakar.mahadev-lad.rj, linux-kernel, linux-riscv,
iommu, Guo Ren, kernel test robot
On Fri, Dec 16, 2022 at 1:16 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2022-12-15 07:32, guoren@kernel.org wrote:
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM
> > dependency here.
>
> This effectively removes all the extra COMPILE_TEST coverage we've been
> enjoying. FWIW I prefer Geert's suggestion to separate the real
> functional dependency from implicit assumptions about ARCH_RENESAS, with
> something like:
>
> depends on ARCH_RENESAS || COMPILE_TEST
> depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE
The problem is from clang version 16.0.0, and gcc version 12.2.0 () is
okay. I didn't recognize COMPILE_TEST could utilize the x86(another
arch) to test the arm driver.
How About:
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index dc5f7a156ff5..a2e259da5a6a 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
config IPMMU_VMSA
bool "Renesas VMSA-compatible IPMMU"
+ depends on !RISCV
depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
select IOMMU_API
select IOMMU_IO_PGTABLE_LPAE
>
> Thanks,
> Robin.
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@kernel.org>
> > ---
> > drivers/iommu/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > index dc5f7a156ff5..746b95b9f345 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG
> >
> > config IPMMU_VMSA
> > bool "Renesas VMSA-compatible IPMMU"
> > + depends on ARM64 || ARM
> > depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64)
> > select IOMMU_API
> > select IOMMU_IO_PGTABLE_LPAE
--
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-16 1:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 7:32 [PATCH] iommu/renesas: Support riscv compile guoren
2022-12-15 17:16 ` Robin Murphy
2022-12-16 1:32 ` Guo Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®