mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Tim Zimmermann <tim@linux4.de>
Subject: [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace
Date: Mon, 10 Apr 2023 22:52:59 +0200	[thread overview]
Message-ID: <20230410205305.1649678-2-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230410205305.1649678-1-daniel.lezcano@linaro.org>

The pch_critical() callback accesses the thermal zone device structure
internals, it dereferences the thermal zone struct device and the 'type'.

For the former, the driver related device should be use instead and
for the latter an accessor already exists. Use them instead of
accessing the internals.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/intel/intel_pch_thermal.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index dce50d239357..0de46057db2a 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -127,7 +127,10 @@ static int pch_thermal_get_temp(struct thermal_zone_device *tzd, int *temp)
 
 static void pch_critical(struct thermal_zone_device *tzd)
 {
-	dev_dbg(&tzd->device, "%s: critical temperature reached\n", tzd->type);
+	struct pch_thermal_device *ptd = thermal_zone_device_priv(tzd);
+
+	dev_dbg(&ptd->pdev->dev, "%s: critical temperature reached\n",
+		thermal_zone_device_type(tzd));
 }
 
 static struct thermal_zone_device_ops tzd_ops = {
-- 
2.34.1


  reply	other threads:[~2023-04-10 20:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 20:52 [PATCH v2 0/7] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-10 20:52 ` Daniel Lezcano [this message]
2023-04-11 18:16   ` [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Rafael J. Wysocki
2023-04-11 20:10     ` Daniel Lezcano
2023-04-12 18:35       ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 2/7] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-11 18:19   ` Rafael J. Wysocki
2023-04-11 20:20     ` Daniel Lezcano
2023-04-12 18:56       ` Rafael J. Wysocki
2023-04-12 19:17         ` Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 3/7] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 4/7] thermal/drivers/menlow: " Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 5/7] thermal/core: Prepare sanitizing thermal class sysfs content Daniel Lezcano
2023-04-11 18:23   ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 6/7] thermal/drivers/acpi: Make cross dev link optional by configuration Daniel Lezcano
2023-04-11 18:26   ` Rafael J. Wysocki
2023-04-11 20:21     ` Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 7/7] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230410205305.1649678-2-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amitk@kernel.org \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=tim@linux4.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®