From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Sujith Thomas <sujith.thomas@intel.com>,
Amit Kucheria <amitk@kernel.org>
Subject: [PATCH v2 7/7] thermal/drivers/intel_menlow: Make additionnal sysfs information optional
Date: Mon, 10 Apr 2023 22:53:05 +0200 [thread overview]
Message-ID: <20230410205305.1649678-8-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230410205305.1649678-1-daniel.lezcano@linaro.org>
The Menlon thermal driver creates specific files in the thermal zone
sysfs class. It is specific to Menlon and these entries look debug
code. It is probable these are not needed.
Let's make the code optional and disable it by default.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/intel/intel_menlow.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/intel/intel_menlow.c b/drivers/thermal/intel/intel_menlow.c
index d720add918ff..d46dacea1b4d 100644
--- a/drivers/thermal/intel/intel_menlow.c
+++ b/drivers/thermal/intel/intel_menlow.c
@@ -374,6 +374,9 @@ static int intel_menlow_add_one_attribute(char *name, umode_t mode, void *show,
struct intel_menlow_attribute *attr;
int result;
+ if (!IS_ENABLED(CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY))
+ return 0;
+
attr = kzalloc(sizeof(struct intel_menlow_attribute), GFP_KERNEL);
if (!attr)
return -ENOMEM;
--
2.34.1
prev parent reply other threads:[~2023-04-10 20:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 20:52 [PATCH v2 0/7] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-10 20:52 ` [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Daniel Lezcano
2023-04-11 18:16 ` Rafael J. Wysocki
2023-04-11 20:10 ` Daniel Lezcano
2023-04-12 18:35 ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 2/7] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-11 18:19 ` Rafael J. Wysocki
2023-04-11 20:20 ` Daniel Lezcano
2023-04-12 18:56 ` Rafael J. Wysocki
2023-04-12 19:17 ` Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 3/7] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 4/7] thermal/drivers/menlow: " Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 5/7] thermal/core: Prepare sanitizing thermal class sysfs content Daniel Lezcano
2023-04-11 18:23 ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 6/7] thermal/drivers/acpi: Make cross dev link optional by configuration Daniel Lezcano
2023-04-11 18:26 ` Rafael J. Wysocki
2023-04-11 20:21 ` Daniel Lezcano
2023-04-10 20:53 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410205305.1649678-8-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sujith.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®