From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Len Brown <lenb@kernel.org>,
"open list:ACPI THERMAL DRIVER" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] thermal/drivers/acpi: Make cross dev link optional by configuration
Date: Tue, 11 Apr 2023 22:21:49 +0200 [thread overview]
Message-ID: <f88a1c56-4078-63a2-ab52-69523c3fdcd8@linaro.org> (raw)
In-Reply-To: <CAJZ5v0hqqPQ0xQqt3KgyQ5b-xTRjPicgkKgyo=+p7jgB9BuZaQ@mail.gmail.com>
On 11/04/2023 20:26, Rafael J. Wysocki wrote:
> On Mon, Apr 10, 2023 at 10:53 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> The ACPI thermal driver creates a link in the thermal zone device
>> sysfs directory pointing to the device sysfs directory. At the same
>> time, it creates a back pointer link from the device to the thermal
>> zone device sysfs directory.
>>
>> From a generic perspective, having a device pointer in the sysfs
>> thermal zone directory may make sense. But the opposite is not true as
>> the same driver can be related to multiple thermal zones.
>>
>> The usage of these information is very specific to ACPI and it is
>> questionable if they are really needed.
>>
>> Let's make the code optional and disable it by default.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/acpi/thermal.c | 62 ++++++++++++++++++++++++++++--------------
>> 1 file changed, 42 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
>> index 5763db4528b8..70f1d28810f2 100644
>> --- a/drivers/acpi/thermal.c
>> +++ b/drivers/acpi/thermal.c
>> @@ -787,9 +787,44 @@ static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
>> .critical = acpi_thermal_zone_device_critical,
>> };
>>
>> +#ifdef CONFIG_THERMAL_SYSFS_OBSOLETE_SINGULARITY
>
> It is OK to move the code to the separate functions below, but it is
> not OK to make it depend on the Kconfig option above.
>
> The extra sysfs things were added in different drivers for different
> reasons. Making them all depend on one Kconfig option is just wrong.
Ok, I'll do the changes accordingly.
Thanks for reviewing the series
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-04-11 20:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 20:52 [PATCH v2 0/7] Thermal zone device structure encapsulation Daniel Lezcano
2023-04-10 20:52 ` [PATCH v2 1/7] thermal/drivers/intel_pch_thermal: Use thermal driver device to write a trace Daniel Lezcano
2023-04-11 18:16 ` Rafael J. Wysocki
2023-04-11 20:10 ` Daniel Lezcano
2023-04-12 18:35 ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 2/7] thermal/core: Encapsulate tz->device field Daniel Lezcano
2023-04-11 18:19 ` Rafael J. Wysocki
2023-04-11 20:20 ` Daniel Lezcano
2023-04-12 18:56 ` Rafael J. Wysocki
2023-04-12 19:17 ` Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 3/7] thermal/drivers/acpi: Use thermal_zone_device() Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 4/7] thermal/drivers/menlow: " Daniel Lezcano
2023-04-10 20:53 ` [PATCH v2 5/7] thermal/core: Prepare sanitizing thermal class sysfs content Daniel Lezcano
2023-04-11 18:23 ` Rafael J. Wysocki
2023-04-10 20:53 ` [PATCH v2 6/7] thermal/drivers/acpi: Make cross dev link optional by configuration Daniel Lezcano
2023-04-11 18:26 ` Rafael J. Wysocki
2023-04-11 20:21 ` Daniel Lezcano [this message]
2023-04-10 20:53 ` [PATCH v2 7/7] thermal/drivers/intel_menlow: Make additionnal sysfs information optional Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f88a1c56-4078-63a2-ab52-69523c3fdcd8@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®