From: Luo Jie <quic_luoj@quicinc.com>
To: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_sricharan@quicinc.com>, Luo Jie <quic_luoj@quicinc.com>
Subject: [PATCH 2/3] net: phy: at803x: remove 1000BaseX mode of qca8081
Date: Thu, 29 Jun 2023 11:48:45 +0800 [thread overview]
Message-ID: <20230629034846.30600-3-quic_luoj@quicinc.com> (raw)
In-Reply-To: <20230629034846.30600-1-quic_luoj@quicinc.com>
QCA808x does not support the link mode 1000BaseX.
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
drivers/net/phy/at803x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 3339ca372b24..29aab7eaaa90 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -920,7 +920,7 @@ static int at803x_get_features(struct phy_device *phydev)
}
}
- if (phydev->drv->phy_id != ATH8031_PHY_ID)
+ if (phydev->drv->phy_id != ATH8031_PHY_ID && phydev->drv->phy_id != QCA8081_PHY_ID)
return 0;
/* AR8031/AR8033 have different status registers
@@ -933,6 +933,8 @@ static int at803x_get_features(struct phy_device *phydev)
*
* Remove this mode from the supported link modes
* when not operating in 1000BaseX mode.
+ *
+ * QCA808x does not support 1000BaseX mode.
*/
if (!priv->is_1000basex)
linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
--
2.17.1
next prev parent reply other threads:[~2023-06-29 3:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 3:48 [PATCH 0/3] net: phy: at803x: support qca8081 1G version chip Luo Jie
2023-06-29 3:48 ` [PATCH 1/3] net: phy: at803x: support qca8081 1G chip type Luo Jie
2023-06-29 13:14 ` Andrew Lunn
2023-06-30 6:39 ` Jie Luo
2023-06-30 13:16 ` Andrew Lunn
2023-07-01 8:00 ` Jie Luo
2023-07-01 14:30 ` Andrew Lunn
2023-07-01 15:42 ` Jie Luo
2023-06-29 3:48 ` Luo Jie [this message]
2023-06-29 13:16 ` [PATCH 2/3] net: phy: at803x: remove 1000BaseX mode of qca8081 Andrew Lunn
2023-06-29 3:48 ` [PATCH 3/3] net: phy: at803x: add qca8081 fifo reset on the link down Luo Jie
2023-06-29 13:23 ` Andrew Lunn
2023-06-30 6:54 ` Jie Luo
2023-06-30 13:21 ` Andrew Lunn
2023-07-01 8:04 ` Jie Luo
2023-07-01 14:34 ` Andrew Lunn
2023-07-01 15:44 ` Jie Luo
2023-07-01 16:21 ` Andrew Lunn
2023-07-02 10:00 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629034846.30600-3-quic_luoj@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_sricharan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®