From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rafael@kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
rui.zhang@intel.com, amit.kucheria@verdurent.com,
amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
mhiramat@kernel.org
Subject: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table
Date: Fri, 21 Jul 2023 16:50:18 +0100 [thread overview]
Message-ID: <20230721155022.2339982-9-lukasz.luba@arm.com> (raw)
In-Reply-To: <20230721155022.2339982-1-lukasz.luba@arm.com>
This patch introduces the new feature: modifiable EM perf_state table.
The new runtime table would be populated with a new power data to better
reflect the actual power. The power can vary over time e.g. due to the
SoC temperature change. Higher temperature can increase power values.
For longer running scenarios, such as game or camera, when also other
devices are used (e.g. GPU, ISP) the CPU power can change. The new
EM framework is able to addresses this issue and change the data
at runtime safely.
The runtime modifiable EM data is used by the Energy Aware Scheduler (EAS)
for the task placement. The EAS is the only user of the 'runtime
modifiable EM'. All the other users (thermal, etc.) are still using the
default (basic) EM. This fact drove the design of this feature.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
include/linux/energy_model.h | 4 +++-
kernel/power/energy_model.c | 26 ++++++++++++++++++++++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index 9b67f54ddcf0..cfb1759ffd45 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -39,7 +39,7 @@ struct em_perf_state {
/**
* struct em_perf_table - Performance states table
* @state: List of performance states, in ascending order
- * @rcu: RCU used for safe access and destruction
+ * @rcu: RCU used only for runtime modifiable table
*/
struct em_perf_table {
struct em_perf_state *state;
@@ -49,6 +49,7 @@ struct em_perf_table {
/**
* struct em_perf_domain - Performance domain
* @default_table: Pointer to the default em_perf_table
+ * @runtime_table: Pointer to the runtime modifiable em_perf_table
* @nr_perf_states: Number of performance states
* @flags: See "em_perf_domain flags"
* @cpus: Cpumask covering the CPUs of the domain. It's here
@@ -64,6 +65,7 @@ struct em_perf_table {
*/
struct em_perf_domain {
struct em_perf_table *default_table;
+ struct em_perf_table __rcu *runtime_table;
int nr_perf_states;
unsigned long flags;
unsigned long cpus[];
diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
index 6cd94f92701d..c2f8a0046f8a 100644
--- a/kernel/power/energy_model.c
+++ b/kernel/power/energy_model.c
@@ -212,6 +212,7 @@ static int em_create_pd(struct device *dev, int nr_states,
unsigned long flags)
{
struct em_perf_table *default_table;
+ struct em_perf_table *runtime_table;
struct em_perf_domain *pd;
struct device *cpu_dev;
int cpu, ret, num_cpus;
@@ -244,13 +245,25 @@ static int em_create_pd(struct device *dev, int nr_states,
pd->default_table = default_table;
+ runtime_table = kzalloc(sizeof(*runtime_table), GFP_KERNEL);
+ if (!runtime_table) {
+ kfree(default_table);
+ kfree(pd);
+ return -ENOMEM;
+ }
+
ret = em_create_perf_table(dev, pd, nr_states, cb, flags);
if (ret) {
kfree(default_table);
+ kfree(runtime_table);
kfree(pd);
return ret;
}
+ /* Re-use temporally (till 1st modification) the memory */
+ runtime_table->state = default_table->state;
+ rcu_assign_pointer(pd->runtime_table, runtime_table);
+
if (_is_cpu_device(dev))
for_each_cpu(cpu, cpus) {
cpu_dev = get_cpu_device(cpu);
@@ -448,23 +461,36 @@ EXPORT_SYMBOL_GPL(em_dev_register_perf_domain);
*/
void em_dev_unregister_perf_domain(struct device *dev)
{
+ struct em_perf_table __rcu *runtime_table;
+ struct em_perf_domain *pd;
+
if (IS_ERR_OR_NULL(dev) || !dev->em_pd)
return;
if (_is_cpu_device(dev))
return;
+ pd = dev->em_pd;
/*
* The mutex separates all register/unregister requests and protects
* from potential clean-up/setup issues in the debugfs directories.
* The debugfs directory name is the same as device's name.
*/
mutex_lock(&em_pd_mutex);
+
em_debug_remove_pd(dev);
+ runtime_table = pd->runtime_table;
+
+ rcu_assign_pointer(pd->runtime_table, NULL);
+ synchronize_rcu();
+
+ kfree(runtime_table);
+
kfree(pd->default_table->state);
kfree(pd->default_table);
kfree(dev->em_pd);
+
dev->em_pd = NULL;
mutex_unlock(&em_pd_mutex);
}
--
2.25.1
next prev parent reply other threads:[~2023-07-21 15:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:50 [PATCH v3 00/12] Introduce runtime modifiable Energy Model Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 01/12] PM: EM: Refactor em_cpufreq_update_efficiencies() arguments Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 02/12] PM: EM: Find first CPU online while updating OPP efficiency Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 03/12] PM: EM: Refactor em_pd_get_efficient_state() to be more flexible Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 04/12] PM: EM: Refactor a new function em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 05/12] PM: EM: Check if the get_cost() callback is present in em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 06/12] PM: EM: Refactor struct em_perf_domain and add default_table Lukasz Luba
2023-08-16 13:04 ` Dietmar Eggemann
2023-08-21 15:22 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 07/12] PM: EM: Add update_power() callback for runtime modifications Lukasz Luba
2023-08-16 13:04 ` Dietmar Eggemann
2023-08-21 15:23 ` Lukasz Luba
2023-07-21 15:50 ` Lukasz Luba [this message]
2023-08-16 13:05 ` [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table Dietmar Eggemann
2023-08-21 15:25 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 09/12] PM: EM: Add RCU mechanism which safely cleans the old data Lukasz Luba
2023-08-16 13:06 ` Dietmar Eggemann
2023-08-21 15:30 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power Lukasz Luba
2023-08-16 13:07 ` Dietmar Eggemann
2023-08-21 15:33 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 11/12] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 12/12] Documentation: EM: Update with runtime modification design Lukasz Luba
2023-08-16 13:08 ` Dietmar Eggemann
2023-08-21 16:13 ` Lukasz Luba
2023-08-16 13:00 ` [PATCH v3 00/12] Introduce runtime modifiable Energy Model Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721155022.2339982-9-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=Pierre.Gondois@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®