From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com,
amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power
Date: Mon, 21 Aug 2023 16:33:43 +0100 [thread overview]
Message-ID: <c6dbcebb-a743-0aa8-1596-5345e0500aa3@arm.com> (raw)
In-Reply-To: <7f4afadb-da77-8edd-f6ef-6c3d68c14801@arm.com>
On 8/16/23 14:07, Dietmar Eggemann wrote:
> On 21/07/2023 17:50, Lukasz Luba wrote:
>
> [...]
>
>> @@ -381,6 +383,12 @@ static inline int em_pd_nr_perf_states(struct em_perf_domain *pd)
>> {
>> return 0;
>> }
>> +static inline
>> +int em_dev_update_perf_domain(struct device *dev, struct em_data_callback *cb,
>> + void *priv)
>> +{
>> + return -EINVAL;
>> +}
>> #endif
>>
>> #endif
>> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
>> index 4596bfe7398e..10180c776c5b 100644
>> --- a/kernel/power/energy_model.c
>> +++ b/kernel/power/energy_model.c
>> @@ -185,6 +185,101 @@ static int em_compute_costs(struct device *dev, struct em_perf_state *table,
>> return 0;
>> }
>>
>> +/**
>> + * em_dev_update_perf_domain() - Update run-time EM table for a device
>
> nit pick: s/run-time/runtime
>
> there are multiple occurrences in this file (maybe more in the entire set?)
>
> [...]
Yes, there are 5 occurrences in the whole patch set. I'll change them.
next prev parent reply other threads:[~2023-08-21 15:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:50 [PATCH v3 00/12] Introduce runtime modifiable Energy Model Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 01/12] PM: EM: Refactor em_cpufreq_update_efficiencies() arguments Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 02/12] PM: EM: Find first CPU online while updating OPP efficiency Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 03/12] PM: EM: Refactor em_pd_get_efficient_state() to be more flexible Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 04/12] PM: EM: Refactor a new function em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 05/12] PM: EM: Check if the get_cost() callback is present in em_compute_costs() Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 06/12] PM: EM: Refactor struct em_perf_domain and add default_table Lukasz Luba
2023-08-16 13:04 ` Dietmar Eggemann
2023-08-21 15:22 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 07/12] PM: EM: Add update_power() callback for runtime modifications Lukasz Luba
2023-08-16 13:04 ` Dietmar Eggemann
2023-08-21 15:23 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table Lukasz Luba
2023-08-16 13:05 ` Dietmar Eggemann
2023-08-21 15:25 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 09/12] PM: EM: Add RCU mechanism which safely cleans the old data Lukasz Luba
2023-08-16 13:06 ` Dietmar Eggemann
2023-08-21 15:30 ` Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power Lukasz Luba
2023-08-16 13:07 ` Dietmar Eggemann
2023-08-21 15:33 ` Lukasz Luba [this message]
2023-07-21 15:50 ` [PATCH v3 11/12] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS Lukasz Luba
2023-07-21 15:50 ` [PATCH v3 12/12] Documentation: EM: Update with runtime modification design Lukasz Luba
2023-08-16 13:08 ` Dietmar Eggemann
2023-08-21 16:13 ` Lukasz Luba
2023-08-16 13:00 ` [PATCH v3 00/12] Introduce runtime modifiable Energy Model Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6dbcebb-a743-0aa8-1596-5345e0500aa3@arm.com \
--to=lukasz.luba@arm.com \
--cc=Pierre.Gondois@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®