* [PATCH] binder: modify the comment for binder_proc_unlock
@ 2024-09-02 17:54 Carlos Llamas
2024-09-02 17:58 ` [PATCH v3] " Carlos Llamas
0 siblings, 1 reply; 3+ messages in thread
From: Carlos Llamas @ 2024-09-02 17:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: linux-kernel, kernel-team, bajing
From: bajing <bajing@cmss.chinamobile.com>
Modify the comment for binder_proc_unlock() to clearly indicate which
spinlock it releases and to better match the acquire comment block in
binder_proc_lock().
Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 905290c98c3c..089bf2b45f0d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
}
/**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
* @proc: struct binder_proc to acquire
*
* Release lock acquired via binder_proc_lock()
--
2.46.0.469.g59c65b2a67-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] binder: modify the comment for binder_proc_unlock
2024-09-02 17:54 [PATCH] binder: modify the comment for binder_proc_unlock Carlos Llamas
@ 2024-09-02 17:58 ` Carlos Llamas
2024-09-03 8:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Carlos Llamas @ 2024-09-02 17:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: linux-kernel, kernel-team, bajing
From: bajing <bajing@cmss.chinamobile.com>
Modify the comment for binder_proc_unlock() to clearly indicate which
spinlock it releases and to better match the acquire comment block in
binder_proc_lock().
Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
Notes:
v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
v2: Reword commit log per suggestions from cmllamas@
https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
v3: Wrap commit message. Add version history.
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 905290c98c3c..089bf2b45f0d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
}
/**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
* @proc: struct binder_proc to acquire
*
* Release lock acquired via binder_proc_lock()
--
2.46.0.469.g59c65b2a67-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] binder: modify the comment for binder_proc_unlock
2024-09-02 17:58 ` [PATCH v3] " Carlos Llamas
@ 2024-09-03 8:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-09-03 8:52 UTC (permalink / raw)
To: Carlos Llamas
Cc: Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, Suren Baghdasaryan,
linux-kernel, kernel-team, bajing
On Mon, Sep 02, 2024 at 05:58:09PM +0000, Carlos Llamas wrote:
> From: bajing <bajing@cmss.chinamobile.com>
>
> Modify the comment for binder_proc_unlock() to clearly indicate which
> spinlock it releases and to better match the acquire comment block in
> binder_proc_lock().
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Sorry, but this needs to be a full name, not just an email alias.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-03 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-02 17:54 [PATCH] binder: modify the comment for binder_proc_unlock Carlos Llamas
2024-09-02 17:58 ` [PATCH v3] " Carlos Llamas
2024-09-03 8:52 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®