mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst
@ 2024-10-02 10:07 Anaswara T Rajan
  2024-10-03 23:03 ` Armin Wolf
  0 siblings, 1 reply; 2+ messages in thread
From: Anaswara T Rajan @ 2024-10-02 10:07 UTC (permalink / raw)
  To: W_Armin
  Cc: corbet, platform-driver-x86, linux-doc, linux-kernel, Anaswara T Rajan

typo in word 'diagnostics'

Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>
---
 Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
index 2fcdfcf03327..e0c20af30948 100644
--- a/Documentation/wmi/devices/dell-wmi-ddv.rst
+++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
@@ -8,7 +8,7 @@ Introduction
 ============
 
 Many Dell notebooks made after ~2020 support a WMI-based interface for
-retrieving various system data like battery temperature, ePPID, diagostic data
+retrieving various system data like battery temperature, ePPID, diagnostic data
 and fan/thermal sensor data.
 
 This interface is likely used by the `Dell Data Vault` software on Windows,
@@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
 4. Try to deduce the meaning of a certain WMI method by comparing the control
    flow with other ACPI methods (_BIX or _BIF for battery related methods
    for example).
-5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
+5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
    related methods (sometimes overwriting static ACPI data fields can be used
    to test different sensor type values, since on some machines this data is
    not reinitialized upon a warm reset).
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst
  2024-10-02 10:07 [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst Anaswara T Rajan
@ 2024-10-03 23:03 ` Armin Wolf
  0 siblings, 0 replies; 2+ messages in thread
From: Armin Wolf @ 2024-10-03 23:03 UTC (permalink / raw)
  To: Anaswara T Rajan; +Cc: corbet, platform-driver-x86, linux-doc, linux-kernel

Am 02.10.24 um 12:07 schrieb Anaswara T Rajan:

> typo in word 'diagnostics'

Please rename your patch to "platform/x86: dell-ddv: Fix typo in documentation" and
rework the patch description so it forms a full sentence.

Other than that, the patch look fine.

Thanks,
Armin Wolf

> Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>
> ---
>   Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
> index 2fcdfcf03327..e0c20af30948 100644
> --- a/Documentation/wmi/devices/dell-wmi-ddv.rst
> +++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
> @@ -8,7 +8,7 @@ Introduction
>   ============
>
>   Many Dell notebooks made after ~2020 support a WMI-based interface for
> -retrieving various system data like battery temperature, ePPID, diagostic data
> +retrieving various system data like battery temperature, ePPID, diagnostic data
>   and fan/thermal sensor data.
>
>   This interface is likely used by the `Dell Data Vault` software on Windows,
> @@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
>   4. Try to deduce the meaning of a certain WMI method by comparing the control
>      flow with other ACPI methods (_BIX or _BIF for battery related methods
>      for example).
> -5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
> +5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
>      related methods (sometimes overwriting static ACPI data fields can be used
>      to test different sensor type values, since on some machines this data is
>      not reinitialized upon a warm reset).

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-03 23:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-02 10:07 [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst Anaswara T Rajan
2024-10-03 23:03 ` Armin Wolf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®