From: Mario Limonciello <mario.limonciello@amd.com>
To: "Borislav Petkov" <bp@alien8.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <x86@kernel.org>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH v3 12/14] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification
Date: Tue, 15 Oct 2024 16:36:43 -0500 [thread overview]
Message-ID: <20241015213645.1476-13-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241015213645.1476-1-mario.limonciello@amd.com>
On designs that have workload classification, it's preferred that
the amd-hfi driver is used to provide hints to the scheduler of
which cores to use instead of the amd-pstate driver.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2->v3:
* Disable prefcore sysfs file too
---
drivers/cpufreq/amd-pstate.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 90868c8b214e..f2a23f622843 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -763,6 +763,12 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)
/* user disabled or not detected */
if (!amd_pstate_prefcore)
return;
+ /* should use amd-hfi instead */
+ if (boot_cpu_has(X86_FEATURE_WORKLOAD_CLASS) &&
+ IS_ENABLED(CONFIG_AMD_HFI)) {
+ amd_pstate_prefcore = false;
+ return;
+ }
cpudata->hw_prefcore = true;
--
2.43.0
next prev parent reply other threads:[~2024-10-15 21:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 21:36 [PATCH v3 00/14] Add support for AMD hardware feedback interface Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 01/14] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 02/14] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 03/14] x86/cpufeatures: add X86_FEATURE_WORKLOAD_CLASS feature bit Mario Limonciello
2024-10-17 4:47 ` Gautham R. Shenoy
2024-10-22 12:42 ` Borislav Petkov
2024-10-22 13:03 ` Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 04/14] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-10-17 4:48 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 05/14] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-10-17 6:07 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 06/14] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 07/14] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2024-10-17 5:52 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 08/14] platform/x86: hfi: add online and offline callback support Mario Limonciello
2024-10-16 12:42 ` Ilpo Järvinen
2024-10-15 21:36 ` [PATCH v3 09/14] platform/x86: hfi: add power management callback Mario Limonciello
2024-10-17 6:00 ` Gautham R. Shenoy
2024-10-17 19:27 ` Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 10/14] x86/cpu: Enable SD_ASYM_PACKING for DIE Domain on AMD Processors Mario Limonciello
2024-10-17 6:06 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 11/14] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-10-15 21:36 ` Mario Limonciello [this message]
2024-10-15 21:36 ` [PATCH v3 13/14] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 14/14] platform/x86: hfi: Add debugfs support Mario Limonciello
2024-10-16 12:38 ` Ilpo Järvinen
2024-10-16 16:09 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015213645.1476-13-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®