From: Mario Limonciello <mario.limonciello@amd.com>
To: "Borislav Petkov" <bp@alien8.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <x86@kernel.org>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH v3 14/14] platform/x86: hfi: Add debugfs support
Date: Tue, 15 Oct 2024 16:36:45 -0500 [thread overview]
Message-ID: <20241015213645.1476-15-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241015213645.1476-1-mario.limonciello@amd.com>
Add a dump of the class and capabilities table to debugfs to assist
with debugging scheduler issues.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2->v3:
* New patch
---
drivers/platform/x86/amd/hfi/hfi.c | 31 ++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
index 6c90b50f0a40..6df80f6ac73c 100644
--- a/drivers/platform/x86/amd/hfi/hfi.c
+++ b/drivers/platform/x86/amd/hfi/hfi.c
@@ -13,6 +13,7 @@
#include <linux/acpi.h>
#include <linux/cpu.h>
#include <linux/cpumask.h>
+#include <linux/debugfs.h>
#include <linux/gfp.h>
#include <linux/init.h>
#include <linux/io.h>
@@ -79,6 +80,8 @@ struct amd_hfi_data {
void __iomem *pcc_comm_addr;
struct acpi_subtable_header *pcct_entry;
struct amd_shmem_info *shmem;
+
+ struct dentry *dbgfs_dir;
};
/**
@@ -243,6 +246,8 @@ static void amd_hfi_remove(struct platform_device *pdev)
{
struct amd_hfi_data *dev = platform_get_drvdata(pdev);
+ debugfs_remove_recursive(dev->dbgfs_dir);
+
mutex_destroy(&dev->lock);
}
@@ -400,6 +405,28 @@ static int amd_hfi_metadata_parser(struct platform_device *pdev,
return ret;
}
+static int class_capabilities_show(struct seq_file *s, void *unused)
+{
+ int cpu, idx;
+
+ seq_puts(s, "CPU #\tWLC\tPerf\tEff\n");
+ for_each_present_cpu(cpu) {
+ struct amd_hfi_cpuinfo *hfi_cpuinfo = per_cpu_ptr(&amd_hfi_cpuinfo, cpu);
+
+ seq_printf(s, "%d\t", cpu);
+ for (idx = 0; idx < hfi_cpuinfo->nr_class; idx++) {
+ seq_printf(s, "%s%d\t%d\t%d\n",
+ idx == 0 ? "" : "\t",
+ idx,
+ hfi_cpuinfo->amd_hfi_classes[idx].perf,
+ hfi_cpuinfo->amd_hfi_classes[idx].eff);
+ }
+ }
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(class_capabilities);
+
static int amd_hfi_pm_resume(struct device *dev)
{
int ret, cpu;
@@ -473,6 +500,10 @@ static int amd_hfi_probe(struct platform_device *pdev)
schedule_work(&sched_amd_hfi_itmt_work);
+ amd_hfi_data->dbgfs_dir = debugfs_create_dir("amd_hfi", arch_debugfs_dir);
+ debugfs_create_file("class_capabilities", 0644, amd_hfi_data->dbgfs_dir, pdev,
+ &class_capabilities_fops);
+
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2024-10-15 21:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 21:36 [PATCH v3 00/14] Add support for AMD hardware feedback interface Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 01/14] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 02/14] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 03/14] x86/cpufeatures: add X86_FEATURE_WORKLOAD_CLASS feature bit Mario Limonciello
2024-10-17 4:47 ` Gautham R. Shenoy
2024-10-22 12:42 ` Borislav Petkov
2024-10-22 13:03 ` Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 04/14] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-10-17 4:48 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 05/14] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-10-17 6:07 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 06/14] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 07/14] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2024-10-17 5:52 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 08/14] platform/x86: hfi: add online and offline callback support Mario Limonciello
2024-10-16 12:42 ` Ilpo Järvinen
2024-10-15 21:36 ` [PATCH v3 09/14] platform/x86: hfi: add power management callback Mario Limonciello
2024-10-17 6:00 ` Gautham R. Shenoy
2024-10-17 19:27 ` Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 10/14] x86/cpu: Enable SD_ASYM_PACKING for DIE Domain on AMD Processors Mario Limonciello
2024-10-17 6:06 ` Gautham R. Shenoy
2024-10-15 21:36 ` [PATCH v3 11/14] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 12/14] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2024-10-15 21:36 ` [PATCH v3 13/14] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-10-15 21:36 ` Mario Limonciello [this message]
2024-10-16 12:38 ` [PATCH v3 14/14] platform/x86: hfi: Add debugfs support Ilpo Järvinen
2024-10-16 16:09 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015213645.1476-15-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®