mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Vyukov <dvyukov@google.com>,
	Oleg Nesterov <oleg@redhat.com>,
	 Russell King <linux@armlinux.org.uk>,
	Kees Cook <kees@kernel.org>,
	 Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	 Frederic Weisbecker <frederic@kernel.org>,
	 "Paul E. McKenney" <paulmck@kernel.org>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,  Ard Biesheuvel <ardb@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH RFC v3 12/30] ARM: entry: Rename syscall invocation
Date: Tue, 07 Jan 2025 10:41:28 +0100	[thread overview]
Message-ID: <20250107-arm-generic-entry-v3-12-4e5f3c15db2d@linaro.org> (raw)
In-Reply-To: <20250107-arm-generic-entry-v3-0-4e5f3c15db2d@linaro.org>

Now that we do not have a separate trace syscall invocation
path, rename the invocation functions to be generic.

This can be squashed into the previous patch, it is just done
here for the previous patch to be easier to get a cleaner
diff and be easier to read.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/include/asm/syscall.h |  2 +-
 arch/arm/kernel/entry-common.S | 10 +++++-----
 arch/arm/kernel/syscall.c      |  8 ++++----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/include/asm/syscall.h b/arch/arm/include/asm/syscall.h
index 9c664d8c5718f58034f442c20a030b59faf65dd9..b94fd7ce17f82f0baf06b74800245112e1f13002 100644
--- a/arch/arm/include/asm/syscall.h
+++ b/arch/arm/include/asm/syscall.h
@@ -19,7 +19,7 @@
 
 extern const unsigned long sys_call_table[];
 
-int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno);
+int invoke_syscall(void *table, struct pt_regs *regs, int scno);
 
 static inline int syscall_get_nr(struct task_struct *task,
 				 struct pt_regs *regs)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index f0f1f8723965313b287158fb2a238908db72fcd2..f1e48002bd3075ea67b5883178583127fa0055c6 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -260,7 +260,7 @@ ENTRY(vector_swi)
 	stmdb	sp!, {r4, r5}			@ push fifth and sixth args
 	mov	r0, tbl
 	mov	r2, scno			@ syscall number from r7
-	bl	invoke_syscall_trace
+	bl	invoke_syscall
 	cmp	r0, #0
 	beq	ret_fast_syscall
 	/* This path taken when tracing */
@@ -390,7 +390,7 @@ ENDPROC(sys_mmap2)
  * r1: regs
  * r2: syscall number
  */
-SYM_TYPED_FUNC_START(invoke_syscall_trace_asm)
+SYM_TYPED_FUNC_START(invoke_syscall_asm)
 #ifdef CONFIG_CPU_SPECTRE
 	csdb
 #endif
@@ -400,17 +400,17 @@ SYM_TYPED_FUNC_START(invoke_syscall_trace_asm)
 	/* Make space to copy the two syscall stack arguments */
 	sub	sp, sp, #S_OFF
 	mov	scno, r2
-	badr	lr, __invoke_syscall_trace_ret	@ return right here
+	badr	lr, __invoke_syscall_ret	@ return right here
 	ldmia	r1, {r0 - r6}			@ reload r0-r6 from regs
 	stmia	sp, {r4, r5}			@ copy stack arguments
 	ldr	pc, [tbl, scno, lsl #2]		@ call sys_* routine
-__invoke_syscall_trace_ret:
+__invoke_syscall_ret:
 	/* Drop the copied stack arguments */
 	add	sp, sp, #S_OFF
 	pop	{r4 - r10, lr}
  ARM(	mov	pc, lr		)
  THUMB(	bx	lr		)
-SYM_FUNC_END(invoke_syscall_trace_asm)
+SYM_FUNC_END(invoke_syscall_asm)
 
 #ifdef CONFIG_OABI_COMPAT
 
diff --git a/arch/arm/kernel/syscall.c b/arch/arm/kernel/syscall.c
index 36330023b5484399a4ca2fdb5727b410e2c74b6f..6f518ec3870fb36a64d1b671b20f96d63a52bf78 100644
--- a/arch/arm/kernel/syscall.c
+++ b/arch/arm/kernel/syscall.c
@@ -8,10 +8,10 @@ static inline bool has_syscall_work(unsigned long flags)
 	return unlikely(flags & _TIF_SYSCALL_WORK);
 }
 
-int invoke_syscall_trace_asm(void *table, struct pt_regs *regs, int scno);
-__ADDRESSABLE(invoke_syscall_trace_asm);
+int invoke_syscall_asm(void *table, struct pt_regs *regs, int scno);
+__ADDRESSABLE(invoke_syscall_asm);
 
-__visible int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno)
+__visible int invoke_syscall(void *table, struct pt_regs *regs, int scno)
 {
 	unsigned long flags = read_thread_flags();
 	int ret;
@@ -23,7 +23,7 @@ __visible int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno)
 	}
 
 	if (scno < NR_syscalls) {
-		ret = invoke_syscall_trace_asm(table, regs, scno);
+		ret = invoke_syscall_asm(table, regs, scno);
 		goto exit_save;
 	}
 

-- 
2.47.1


  parent reply	other threads:[~2025-01-07  9:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  9:41 [PATCH RFC v3 00/30] ARM: Switch to generic entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 01/30] ARM: Prepare includes for " Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 02/30] ARM: ptrace: Split report_syscall() Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 03/30] ARM: entry: Skip ret_slow_syscall label Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 04/30] ARM: process: Rewrite ret_from_fork i C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 05/30] ARM: process: Remove local restart Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 06/30] ARM: entry: Invoke syscalls using C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 07/30] ARM: entry: Rewrite two asm calls in C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 08/30] ARM: entry: Move trace entry to C function Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 09/30] ARM: entry: save the syscall sp in thread_info Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 10/30] ARM: entry: move all tracing invocation to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 11/30] ARM: entry: Merge the common and trace entry code Linus Walleij
2025-01-07  9:41 ` Linus Walleij [this message]
2025-01-07  9:41 ` [PATCH RFC v3 13/30] ARM: entry: Create user_mode_enter/exit Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 14/30] ARM: entry: Drop trace argument from usr_entry macro Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 15/30] ARM: entry: Separate call path for syscall SWI entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 16/30] ARM: entry: Drop argument to asm_irqentry macros Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 17/30] ARM: entry: Implement syscall_exit_to_user_mode() Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 18/30] ARM: entry: Drop the superfast ret_fast_syscall Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 19/30] ARM: entry: Remove fast and offset register restore Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 20/30] ARM: entry: Untangle ret_fast_syscall/to_user Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 21/30] ARM: entry: Do not double-call exit functions Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 22/30] ARM: entry: Move work processing to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 23/30] ARM: entry: Stop exiting syscalls like IRQs Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 24/30] ARM: entry: Complete syscall and IRQ transition to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 25/30] ARM: entry: Create irqentry calls from kernel mode Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 26/30] ARM: entry: Move in-kernel hardirq tracing to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 27/30] ARM: irq: Add irqstack helpers Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 28/30] ARM: entry: Convert to generic entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 29/30] ARM: entry: Handle prefetch and data aborts as interrupts Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 30/30] RFC: ARM: entry: Block IRQs in early IRQ context Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107-arm-generic-entry-v3-12-4e5f3c15db2d@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dvyukov@google.com \
    --cc=frederic@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®