From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Vyukov <dvyukov@google.com>,
Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Kees Cook <kees@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
Frederic Weisbecker <frederic@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH RFC v3 16/30] ARM: entry: Drop argument to asm_irqentry macros
Date: Tue, 07 Jan 2025 10:41:32 +0100 [thread overview]
Message-ID: <20250107-arm-generic-entry-v3-16-4e5f3c15db2d@linaro.org> (raw)
In-Reply-To: <20250107-arm-generic-entry-v3-0-4e5f3c15db2d@linaro.org>
asm_irqentry_enter_from_user_mode and asm_irqentry_exit_to_user_mode
have a "save" argument that will save and restore registers before
the call to the C function.
Now all invocations set this argument to 0 so drop the surplus
code.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/kernel/entry-armv.S | 8 ++++----
arch/arm/kernel/entry-common.S | 2 +-
| 18 ++----------------
3 files changed, 7 insertions(+), 21 deletions(-)
diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
index 6edf362ab1e1035dafebf6fb7c55db71462c1eae..460aa92c3c1f50de905550acf363c58f509bfe0a 100644
--- a/arch/arm/kernel/entry-armv.S
+++ b/arch/arm/kernel/entry-armv.S
@@ -422,7 +422,7 @@ ENDPROC(__fiq_abt)
.align 5
__dabt_usr:
usr_entry uaccess=0
- asm_irqentry_enter_from_user_mode save = 0
+ asm_irqentry_enter_from_user_mode
kuser_cmpxchg_check
mov r2, sp
dabt_helper
@@ -433,7 +433,7 @@ ENDPROC(__dabt_usr)
.align 5
__irq_usr:
usr_entry
- asm_irqentry_enter_from_user_mode save = 0
+ asm_irqentry_enter_from_user_mode
kuser_cmpxchg_check
irq_handler from_user=1
get_thread_info tsk
@@ -447,7 +447,7 @@ ENDPROC(__irq_usr)
.align 5
__und_usr:
usr_entry uaccess=0
- asm_irqentry_enter_from_user_mode save = 0
+ asm_irqentry_enter_from_user_mode
@ IRQs must be enabled before attempting to read the instruction from
@ user space since that could cause a page/translation fault if the
@@ -472,7 +472,7 @@ ENDPROC(__und_usr)
.align 5
__pabt_usr:
usr_entry
- asm_irqentry_enter_from_user_mode save = 0
+ asm_irqentry_enter_from_user_mode
mov r2, sp @ regs
pabt_helper
UNWIND(.fnend )
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index 14b2495cae3c2f95b0dfecd849b4e16ec143dbe9..df564388905ee019cd5553f8b37e678da59e3222 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -109,7 +109,7 @@ ENTRY(ret_to_user_from_irq)
movs r1, r1, lsl #16
bne slow_work_pending
no_work_pending:
- asm_irqentry_exit_to_user_mode save = 0
+ asm_irqentry_exit_to_user_mode
#ifdef CONFIG_GCC_PLUGIN_STACKLEAK
bl stackleak_erase_on_task_stack
--git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index fb5bb019199b2871e29e306a29bea8fdf47dd7f3..50c0b55adc7421e7be123c9d00f94b1ebb93ff9e 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -365,28 +365,14 @@ ALT_UP_B(.L1_\@)
* Context tracking and other mode transitions. Used to instrument transitions
* between user and kernel mode.
*/
- .macro asm_irqentry_enter_from_user_mode, save = 1
- .if \save
- stmdb sp!, {r0-r3, ip, lr}
+ .macro asm_irqentry_enter_from_user_mode
mov r0, sp @ regs
bl irqentry_enter_from_user_mode
- ldmia sp!, {r0-r3, ip, lr}
- .else
- mov r0, sp @ regs
- bl irqentry_enter_from_user_mode
- .endif
.endm
- .macro asm_irqentry_exit_to_user_mode, save = 1
- .if \save
- stmdb sp!, {r0-r3, ip, lr}
+ .macro asm_irqentry_exit_to_user_mode
mov r0, sp @ regs
bl irqentry_exit_to_user_mode
- ldmia sp!, {r0-r3, ip, lr}
- .else
- mov r0, sp @ regs
- bl irqentry_exit_to_user_mode
- .endif
.endm
/*
--
2.47.1
next prev parent reply other threads:[~2025-01-07 9:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 9:41 [PATCH RFC v3 00/30] ARM: Switch to generic entry Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 01/30] ARM: Prepare includes for " Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 02/30] ARM: ptrace: Split report_syscall() Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 03/30] ARM: entry: Skip ret_slow_syscall label Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 04/30] ARM: process: Rewrite ret_from_fork i C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 05/30] ARM: process: Remove local restart Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 06/30] ARM: entry: Invoke syscalls using C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 07/30] ARM: entry: Rewrite two asm calls in C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 08/30] ARM: entry: Move trace entry to C function Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 09/30] ARM: entry: save the syscall sp in thread_info Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 10/30] ARM: entry: move all tracing invocation to C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 11/30] ARM: entry: Merge the common and trace entry code Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 12/30] ARM: entry: Rename syscall invocation Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 13/30] ARM: entry: Create user_mode_enter/exit Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 14/30] ARM: entry: Drop trace argument from usr_entry macro Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 15/30] ARM: entry: Separate call path for syscall SWI entry Linus Walleij
2025-01-07 9:41 ` Linus Walleij [this message]
2025-01-07 9:41 ` [PATCH RFC v3 17/30] ARM: entry: Implement syscall_exit_to_user_mode() Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 18/30] ARM: entry: Drop the superfast ret_fast_syscall Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 19/30] ARM: entry: Remove fast and offset register restore Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 20/30] ARM: entry: Untangle ret_fast_syscall/to_user Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 21/30] ARM: entry: Do not double-call exit functions Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 22/30] ARM: entry: Move work processing to C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 23/30] ARM: entry: Stop exiting syscalls like IRQs Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 24/30] ARM: entry: Complete syscall and IRQ transition to C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 25/30] ARM: entry: Create irqentry calls from kernel mode Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 26/30] ARM: entry: Move in-kernel hardirq tracing to C Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 27/30] ARM: irq: Add irqstack helpers Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 28/30] ARM: entry: Convert to generic entry Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 29/30] ARM: entry: Handle prefetch and data aborts as interrupts Linus Walleij
2025-01-07 9:41 ` [PATCH RFC v3 30/30] RFC: ARM: entry: Block IRQs in early IRQ context Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250107-arm-generic-entry-v3-16-4e5f3c15db2d@linaro.org \
--to=linus.walleij@linaro.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=frederic@kernel.org \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®