mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Vyukov <dvyukov@google.com>,
	Oleg Nesterov <oleg@redhat.com>,
	 Russell King <linux@armlinux.org.uk>,
	Kees Cook <kees@kernel.org>,
	 Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	 Frederic Weisbecker <frederic@kernel.org>,
	 "Paul E. McKenney" <paulmck@kernel.org>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,  Ard Biesheuvel <ardb@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH RFC v3 27/30] ARM: irq: Add irqstack helpers
Date: Tue, 07 Jan 2025 10:41:43 +0100	[thread overview]
Message-ID: <20250107-arm-generic-entry-v3-27-4e5f3c15db2d@linaro.org> (raw)
In-Reply-To: <20250107-arm-generic-entry-v3-0-4e5f3c15db2d@linaro.org>

Add two helpers that essentially re-implement some IRQ
dispatch code in C: on_irq_stack() that checks if a regs
context is on the IRQ stack, and call_on_irq_stack()
so we can explicitly issue handle_irq() on the IRQ
stack from a C program.

Cc: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/kernel/irq.c | 31 +++++++++++++++++++++++++++++++
 arch/arm/kernel/irq.h |  3 +++
 2 files changed, 34 insertions(+)

diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index e1993e28a9ecfd80b55b2677253ac582467e6c14..4c1a678b72b326e42c871b994c09d1fa4b0863f6 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -43,6 +43,7 @@
 #include <asm/mach/irq.h>
 #include <asm/mach/time.h>
 
+#include "irq.h"
 #include "reboot.h"
 
 unsigned long irq_err_count;
@@ -71,6 +72,36 @@ static void __init init_irq_stacks(void)
 	}
 }
 
+/*
+ * on_irq_stack() - check if a regs context is using the IRQ stack
+ * @regs: the context to check
+ * Returns true if regs is using the IRQ stack
+ */
+bool on_irq_stack(struct pt_regs *regs)
+{
+	u8 *high = __this_cpu_read(irq_stack_ptr);
+	u8 *low = high - THREAD_SIZE;
+	u8 *sp = (u8 *)regs->ARM_sp;
+	bool on_stack;
+
+	on_stack = (low <= sp && sp <= high);
+
+	if (on_stack && IS_ENABLED(CONFIG_VMAP_STACK))
+		/*
+		 * Also check that SP is inside the linear kernel memory
+		 * if using VMAP:ed stacks.
+		 * TODO: Ask Ard to explain why we need to do this
+		 */
+		on_stack = (sp > (u8 *)high_memory);
+
+	return on_stack;
+}
+
+void call_on_irq_stack(void (*fn)(void *), void *arg)
+{
+	call_with_stack(fn, arg, __this_cpu_read(irq_stack_ptr));
+}
+
 #ifdef CONFIG_SOFTIRQ_ON_OWN_STACK
 static void ____do_softirq(void *arg)
 {
diff --git a/arch/arm/kernel/irq.h b/arch/arm/kernel/irq.h
new file mode 100644
index 0000000000000000000000000000000000000000..c5186b67242a2976fe702154ed4f2a22eca51add
--- /dev/null
+++ b/arch/arm/kernel/irq.h
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+bool on_irq_stack(struct pt_regs *regs);
+void call_on_irq_stack(void (*fn)(void *), void *arg);

-- 
2.47.1


  parent reply	other threads:[~2025-01-07  9:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  9:41 [PATCH RFC v3 00/30] ARM: Switch to generic entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 01/30] ARM: Prepare includes for " Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 02/30] ARM: ptrace: Split report_syscall() Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 03/30] ARM: entry: Skip ret_slow_syscall label Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 04/30] ARM: process: Rewrite ret_from_fork i C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 05/30] ARM: process: Remove local restart Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 06/30] ARM: entry: Invoke syscalls using C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 07/30] ARM: entry: Rewrite two asm calls in C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 08/30] ARM: entry: Move trace entry to C function Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 09/30] ARM: entry: save the syscall sp in thread_info Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 10/30] ARM: entry: move all tracing invocation to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 11/30] ARM: entry: Merge the common and trace entry code Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 12/30] ARM: entry: Rename syscall invocation Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 13/30] ARM: entry: Create user_mode_enter/exit Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 14/30] ARM: entry: Drop trace argument from usr_entry macro Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 15/30] ARM: entry: Separate call path for syscall SWI entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 16/30] ARM: entry: Drop argument to asm_irqentry macros Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 17/30] ARM: entry: Implement syscall_exit_to_user_mode() Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 18/30] ARM: entry: Drop the superfast ret_fast_syscall Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 19/30] ARM: entry: Remove fast and offset register restore Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 20/30] ARM: entry: Untangle ret_fast_syscall/to_user Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 21/30] ARM: entry: Do not double-call exit functions Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 22/30] ARM: entry: Move work processing to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 23/30] ARM: entry: Stop exiting syscalls like IRQs Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 24/30] ARM: entry: Complete syscall and IRQ transition to C Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 25/30] ARM: entry: Create irqentry calls from kernel mode Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 26/30] ARM: entry: Move in-kernel hardirq tracing to C Linus Walleij
2025-01-07  9:41 ` Linus Walleij [this message]
2025-01-07  9:41 ` [PATCH RFC v3 28/30] ARM: entry: Convert to generic entry Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 29/30] ARM: entry: Handle prefetch and data aborts as interrupts Linus Walleij
2025-01-07  9:41 ` [PATCH RFC v3 30/30] RFC: ARM: entry: Block IRQs in early IRQ context Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250107-arm-generic-entry-v3-27-4e5f3c15db2d@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dvyukov@google.com \
    --cc=frederic@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®