mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Update clocks for sc7280-camss
@ 2025-01-21 18:07 Vikram Sharma
  2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
  2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
  0 siblings, 2 replies; 6+ messages in thread
From: Vikram Sharma @ 2025-01-21 18:07 UTC (permalink / raw)
  To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will
  Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm,
	devicetree, linux-kernel, kernel

Update clock names as follow-up change for series.
https://lore.kernel.org/linux-arm-msm/20241206191900.2545069-1-quic_vikramsa@quicinc.com/
We have got comments on our dtsi change to update clock names as
- GCC_CAMERA_AHB_CLK is always enabled clock so it can be removed.
- Change clock name from gcc_cam_hf_axi to `gcc_axi_hf` for consistency.
- Add gcc_axi_sf as missing to enable it can have undefined hw behaviour.

To handle these comments in our base series we need to update
documentaion and driver (already merged) to work with dtsi.

We are not breaking ABI here because the ABI hasn't been cemented yet as the dtsi
changes are not merged yet also there are no users for this driver as of now. 

Used following tools for the sanity check of these changes.
- make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml
- make DT_CHECKER_FLAGS=-m W=1
DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml dt_binding_check
- make -j32 W=1
- ./scripts/checkpatch.pl

Changes in V2:
- Updated commit text to explain the reason behind this change.
- Updated commit text to use imperative mood.
- Updated commit text to utilize 75 character limit properly.
- Link to v1: https://lore.kernel.org/linux-arm-msm/20250121120901.1841142-1-quic_vikramsa@quicinc.com/

Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>

Vikram Sharma (2):
  media: dt-bindings: update clocks for sc7280-camss
  media: qcom: camss: update clock names for sc7280

 .../bindings/media/qcom,sc7280-camss.yaml         | 10 +++++-----
 drivers/media/platform/qcom/camss/camss.c         | 15 ++++++++++-----
 2 files changed, 15 insertions(+), 10 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/2] media: dt-bindings: update clocks for sc7280-camss
  2025-01-21 18:07 [PATCH v2 0/2] Update clocks for sc7280-camss Vikram Sharma
@ 2025-01-21 18:07 ` Vikram Sharma
  2025-01-22 13:30   ` Bryan O'Donoghue
  2025-01-24  8:10   ` Krzysztof Kozlowski
  2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
  1 sibling, 2 replies; 6+ messages in thread
From: Vikram Sharma @ 2025-01-21 18:07 UTC (permalink / raw)
  To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will
  Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm,
	devicetree, linux-kernel, kernel

Update clock names to make them consistent with existing platform i.e
qcom,sc8280xp-camss.yaml. Rename gcc_cam_hf_axi to gcc_axi_hf and add
gcc_axi_sf.

gcc_camera_ahb is always on and we don't need to enable it explicitly.
gcc_axi_sf is added to avoid unexpected hardware behaviour.

This change will not break ABI because the ABI hasn't been cemented yet as
the dtsi changes are not merged yet and there are no users for this driver
as of now.

Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
---
 .../devicetree/bindings/media/qcom,sc7280-camss.yaml   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index e11141b812a0..ee35e3bc97ff 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -55,8 +55,8 @@ properties:
       - const: csiphy3_timer
       - const: csiphy4
       - const: csiphy4_timer
-      - const: gcc_camera_ahb
-      - const: gcc_cam_hf_axi
+      - const: gcc_axi_hf
+      - const: gcc_axi_sf
       - const: icp_ahb
       - const: vfe0
       - const: vfe0_axi
@@ -310,8 +310,8 @@ examples:
                      <&camcc CAM_CC_CSI3PHYTIMER_CLK>,
                      <&camcc CAM_CC_CSIPHY4_CLK>,
                      <&camcc CAM_CC_CSI4PHYTIMER_CLK>,
-                     <&gcc GCC_CAMERA_AHB_CLK>,
                      <&gcc GCC_CAMERA_HF_AXI_CLK>,
+                     <&gcc GCC_CAMERA_SF_AXI_CLK>,
                      <&camcc CAM_CC_ICP_AHB_CLK>,
                      <&camcc CAM_CC_IFE_0_CLK>,
                      <&camcc CAM_CC_IFE_0_AXI_CLK>,
@@ -343,8 +343,8 @@ examples:
                           "csiphy3_timer",
                           "csiphy4",
                           "csiphy4_timer",
-                          "gcc_camera_ahb",
-                          "gcc_cam_hf_axi",
+                          "gcc_axi_hf",
+                          "gcc_axi_sf",
                           "icp_ahb",
                           "vfe0",
                           "vfe0_axi",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280
  2025-01-21 18:07 [PATCH v2 0/2] Update clocks for sc7280-camss Vikram Sharma
  2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
@ 2025-01-21 18:07 ` Vikram Sharma
  2025-01-22 13:30   ` Bryan O'Donoghue
  1 sibling, 1 reply; 6+ messages in thread
From: Vikram Sharma @ 2025-01-21 18:07 UTC (permalink / raw)
  To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will
  Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm,
	devicetree, linux-kernel, kernel

Update clock names to make them consistent with existing platform i.e
sc8280xp. Rename gcc_cam_hf_axi to gcc_axi_hf and add gcc_axi_sf.

Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
---
 drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index a85e9df0f301..b1358457c66e 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -1443,12 +1443,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
 		.regulators = {},
 
 		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe0",
-			   "vfe0_axi", "gcc_cam_hf_axi" },
+			   "vfe0_axi", "gcc_axi_hf", "gcc_axi_sf" },
 		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
 				{ 80000000 },
 				{ 0 },
 				{ 380000000, 510000000, 637000000, 760000000 },
 				{ 0 },
+				{ 0 },
 				{ 0 } },
 
 		.reg = { "vfe0" },
@@ -1468,12 +1469,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
 		.regulators = {},
 
 		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe1",
-			   "vfe1_axi", "gcc_cam_hf_axi" },
+			   "vfe1_axi", "gcc_axi_hf", "gcc_axi_sf" },
 		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
 				{ 80000000 },
 				{ 0 },
 				{ 380000000, 510000000, 637000000, 760000000 },
 				{ 0 },
+				{ 0 },
 				{ 0 } },
 
 		.reg = { "vfe1" },
@@ -1493,12 +1495,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
 		.regulators = {},
 
 		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe2",
-			   "vfe2_axi", "gcc_cam_hf_axi" },
+			   "vfe2_axi", "gcc_axi_hf", "gcc_axi_sf" },
 		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
 				{ 80000000 },
 				{ 0 },
 				{ 380000000, 510000000, 637000000, 760000000 },
 				{ 0 },
+				{ 0 },
 				{ 0 } },
 
 		.reg = { "vfe2" },
@@ -1516,11 +1519,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
 	/* VFE3 (lite) */
 	{
 		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
-			   "vfe_lite0", "gcc_cam_hf_axi" },
+			   "vfe_lite0", "gcc_axi_hf", "gcc_axi_sf" },
 		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
 				{ 80000000 },
 				{ 0 },
 				{ 320000000, 400000000, 480000000, 600000000 },
+				{ 0 },
 				{ 0 } },
 
 		.regulators = {},
@@ -1537,11 +1541,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
 	/* VFE4 (lite) */
 	{
 		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
-			   "vfe_lite1", "gcc_cam_hf_axi" },
+			   "vfe_lite1", "gcc_axi_hf", "gcc_axi_sf" },
 		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
 				{ 80000000 },
 				{ 0 },
 				{ 320000000, 400000000, 480000000, 600000000 },
+				{ 0 },
 				{ 0 } },
 
 		.regulators = {},
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] media: dt-bindings: update clocks for sc7280-camss
  2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
@ 2025-01-22 13:30   ` Bryan O'Donoghue
  2025-01-24  8:10   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2025-01-22 13:30 UTC (permalink / raw)
  To: Vikram Sharma, rfoss, todor.too, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will
  Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree,
	linux-kernel, kernel

On 21/01/2025 18:07, Vikram Sharma wrote:
> Update clock names to make them consistent with existing platform i.e
> qcom,sc8280xp-camss.yaml. Rename gcc_cam_hf_axi to gcc_axi_hf and add
> gcc_axi_sf.
> 
> gcc_camera_ahb is always on and we don't need to enable it explicitly.
> gcc_axi_sf is added to avoid unexpected hardware behaviour.
> 
> This change will not break ABI because the ABI hasn't been cemented yet as
> the dtsi changes are not merged yet and there are no users for this driver
> as of now.
> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>   .../devicetree/bindings/media/qcom,sc7280-camss.yaml   | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index e11141b812a0..ee35e3bc97ff 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -55,8 +55,8 @@ properties:
>         - const: csiphy3_timer
>         - const: csiphy4
>         - const: csiphy4_timer
> -      - const: gcc_camera_ahb
> -      - const: gcc_cam_hf_axi
> +      - const: gcc_axi_hf
> +      - const: gcc_axi_sf
>         - const: icp_ahb
>         - const: vfe0
>         - const: vfe0_axi
> @@ -310,8 +310,8 @@ examples:
>                        <&camcc CAM_CC_CSI3PHYTIMER_CLK>,
>                        <&camcc CAM_CC_CSIPHY4_CLK>,
>                        <&camcc CAM_CC_CSI4PHYTIMER_CLK>,
> -                     <&gcc GCC_CAMERA_AHB_CLK>,
>                        <&gcc GCC_CAMERA_HF_AXI_CLK>,
> +                     <&gcc GCC_CAMERA_SF_AXI_CLK>,
>                        <&camcc CAM_CC_ICP_AHB_CLK>,
>                        <&camcc CAM_CC_IFE_0_CLK>,
>                        <&camcc CAM_CC_IFE_0_AXI_CLK>,
> @@ -343,8 +343,8 @@ examples:
>                             "csiphy3_timer",
>                             "csiphy4",
>                             "csiphy4_timer",
> -                          "gcc_camera_ahb",
> -                          "gcc_cam_hf_axi",
> +                          "gcc_axi_hf",
> +                          "gcc_axi_sf",
>                             "icp_ahb",
>                             "vfe0",
>                             "vfe0_axi",
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280
  2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
@ 2025-01-22 13:30   ` Bryan O'Donoghue
  0 siblings, 0 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2025-01-22 13:30 UTC (permalink / raw)
  To: Vikram Sharma, rfoss, todor.too, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will
  Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree,
	linux-kernel, kernel

On 21/01/2025 18:07, Vikram Sharma wrote:
> Update clock names to make them consistent with existing platform i.e
> sc8280xp. Rename gcc_cam_hf_axi to gcc_axi_hf and add gcc_axi_sf.
> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>   drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index a85e9df0f301..b1358457c66e 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1443,12 +1443,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>   		.regulators = {},
>   
>   		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe0",
> -			   "vfe0_axi", "gcc_cam_hf_axi" },
> +			   "vfe0_axi", "gcc_axi_hf", "gcc_axi_sf" },
>   		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
>   				{ 80000000 },
>   				{ 0 },
>   				{ 380000000, 510000000, 637000000, 760000000 },
>   				{ 0 },
> +				{ 0 },
>   				{ 0 } },
>   
>   		.reg = { "vfe0" },
> @@ -1468,12 +1469,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>   		.regulators = {},
>   
>   		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe1",
> -			   "vfe1_axi", "gcc_cam_hf_axi" },
> +			   "vfe1_axi", "gcc_axi_hf", "gcc_axi_sf" },
>   		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
>   				{ 80000000 },
>   				{ 0 },
>   				{ 380000000, 510000000, 637000000, 760000000 },
>   				{ 0 },
> +				{ 0 },
>   				{ 0 } },
>   
>   		.reg = { "vfe1" },
> @@ -1493,12 +1495,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>   		.regulators = {},
>   
>   		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe2",
> -			   "vfe2_axi", "gcc_cam_hf_axi" },
> +			   "vfe2_axi", "gcc_axi_hf", "gcc_axi_sf" },
>   		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
>   				{ 80000000 },
>   				{ 0 },
>   				{ 380000000, 510000000, 637000000, 760000000 },
>   				{ 0 },
> +				{ 0 },
>   				{ 0 } },
>   
>   		.reg = { "vfe2" },
> @@ -1516,11 +1519,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>   	/* VFE3 (lite) */
>   	{
>   		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
> -			   "vfe_lite0", "gcc_cam_hf_axi" },
> +			   "vfe_lite0", "gcc_axi_hf", "gcc_axi_sf" },
>   		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
>   				{ 80000000 },
>   				{ 0 },
>   				{ 320000000, 400000000, 480000000, 600000000 },
> +				{ 0 },
>   				{ 0 } },
>   
>   		.regulators = {},
> @@ -1537,11 +1541,12 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>   	/* VFE4 (lite) */
>   	{
>   		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb",
> -			   "vfe_lite1", "gcc_cam_hf_axi" },
> +			   "vfe_lite1", "gcc_axi_hf", "gcc_axi_sf" },
>   		.clock_rate = { { 150000000, 240000000, 320000000, 400000000, 480000000 },
>   				{ 80000000 },
>   				{ 0 },
>   				{ 320000000, 400000000, 480000000, 600000000 },
> +				{ 0 },
>   				{ 0 } },
>   
>   		.regulators = {},
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] media: dt-bindings: update clocks for sc7280-camss
  2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
  2025-01-22 13:30   ` Bryan O'Donoghue
@ 2025-01-24  8:10   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-24  8:10 UTC (permalink / raw)
  To: Vikram Sharma
  Cc: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt,
	conor+dt, akapatra, hariramp, andersson, konradybcio,
	hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will,
	linux-arm-kernel, linux-media, linux-arm-msm, devicetree,
	linux-kernel, kernel

On Tue, Jan 21, 2025 at 11:37:45PM +0530, Vikram Sharma wrote:
> Update clock names to make them consistent with existing platform i.e
> qcom,sc8280xp-camss.yaml. Rename gcc_cam_hf_axi to gcc_axi_hf and add
> gcc_axi_sf.
> 
> gcc_camera_ahb is always on and we don't need to enable it explicitly.
> gcc_axi_sf is added to avoid unexpected hardware behaviour.
> 
> This change will not break ABI because the ABI hasn't been cemented yet as
> the dtsi changes are not merged yet and there are no users for this driver
> as of now.
> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>  .../devicetree/bindings/media/qcom,sc7280-camss.yaml   | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-01-24  8:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-21 18:07 [PATCH v2 0/2] Update clocks for sc7280-camss Vikram Sharma
2025-01-21 18:07 ` [PATCH v2 1/2] media: dt-bindings: update " Vikram Sharma
2025-01-22 13:30   ` Bryan O'Donoghue
2025-01-24  8:10   ` Krzysztof Kozlowski
2025-01-21 18:07 ` [PATCH v2 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
2025-01-22 13:30   ` Bryan O'Donoghue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®