From: kernel test robot <lkp@intel.com>
To: "Xin Li (Intel)" <xin@zytor.com>, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, peterz@infradead.org,
andrew.cooper3@citrix.com, stable@vger.kernel.org
Subject: Re: [PATCH v1 1/1] x86/fred/signal: Prevent single-step upon ERETU completion
Date: Fri, 23 May 2025 01:20:32 +0800 [thread overview]
Message-ID: <202505230141.4YBHhrPI-lkp@intel.com> (raw)
In-Reply-To: <20250522060549.2882444-1-xin@zytor.com>
Hi Xin,
kernel test robot noticed the following build errors:
[auto build test ERROR on 6a7c3c2606105a41dde81002c0037420bc1ddf00]
url: https://github.com/intel-lab-lkp/linux/commits/Xin-Li-Intel/x86-fred-signal-Prevent-single-step-upon-ERETU-completion/20250522-140954
base: 6a7c3c2606105a41dde81002c0037420bc1ddf00
patch link: https://lore.kernel.org/r/20250522060549.2882444-1-xin%40zytor.com
patch subject: [PATCH v1 1/1] x86/fred/signal: Prevent single-step upon ERETU completion
config: i386-buildonly-randconfig-003-20250522 (https://download.01.org/0day-ci/archive/20250523/202505230141.4YBHhrPI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250523/202505230141.4YBHhrPI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505230141.4YBHhrPI-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/signal_32.c:32:
arch/x86/include/asm/sighandling.h: In function 'prevent_single_step_upon_eretu':
>> arch/x86/include/asm/sighandling.h:44:21: error: 'struct pt_regs' has no member named 'fred_ss'
44 | regs->fred_ss.swevent = 0;
| ^~
vim +44 arch/x86/include/asm/sighandling.h
26
27 /*
28 * To prevent infinite SIGTRAP handler loop if TF is used without an external
29 * debugger, clear the software event flag in the augmented SS, ensuring no
30 * single-step trap is pending upon ERETU completion.
31 *
32 * Note, this function should be called in sigreturn() before the original state
33 * is restored to make sure the TF is read from the entry frame.
34 */
35 static __always_inline void prevent_single_step_upon_eretu(struct pt_regs *regs)
36 {
37 /*
38 * If the trap flag (TF) is set, i.e., the sigreturn() SYSCALL instruction
39 * is being single-stepped, do not clear the software event flag in the
40 * augmented SS, thus a debugger won't skip over the following instruction.
41 */
42 if (IS_ENABLED(CONFIG_X86_FRED) && cpu_feature_enabled(X86_FEATURE_FRED) &&
43 !(regs->flags & X86_EFLAGS_TF))
> 44 regs->fred_ss.swevent = 0;
45 }
46
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-05-22 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 6:05 Xin Li (Intel)
2025-05-22 7:20 ` H. Peter Anvin
2025-05-22 17:10 ` Xin Li
2025-05-22 17:20 ` kernel test robot [this message]
2025-05-22 17:33 ` Xin Li
2025-05-22 17:51 ` Andrew Cooper
2025-05-23 6:23 ` Xin Li
2025-05-22 17:54 ` Dave Hansen
2025-05-23 6:24 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505230141.4YBHhrPI-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®