From: Dave Hansen <dave.hansen@intel.com>
To: Xin Li <xin@zytor.com>, kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, peterz@infradead.org,
andrew.cooper3@citrix.com, stable@vger.kernel.org
Subject: Re: [PATCH v1 1/1] x86/fred/signal: Prevent single-step upon ERETU completion
Date: Thu, 22 May 2025 10:54:43 -0700 [thread overview]
Message-ID: <8342ee1c-5adc-4a6a-b4ee-f7d3b42a6528@intel.com> (raw)
In-Reply-To: <83b013fb-2057-4097-ac8c-b5c38d019a0f@zytor.com>
On 5/22/25 10:33, Xin Li wrote:
>>>> arch/x86/include/asm/sighandling.h:44:21: error: 'struct pt_regs'
>>>> has no member named 'fred_ss'
>> 44 | regs->fred_ss.swevent = 0;
>> | ^~
>>
>
> Hmm, this statement is under IS_ENABLED(CONFIG_X86_FRED), which should
The compiler still _compiles_ unreachable statements:
if (0)
foo = bar.bar;
An #ifdef will keep the compiler out completely, of course. That's
probably the best thing in this case, especially since it'll be tucked
away in a header.
next prev parent reply other threads:[~2025-05-22 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 6:05 Xin Li (Intel)
2025-05-22 7:20 ` H. Peter Anvin
2025-05-22 17:10 ` Xin Li
2025-05-22 17:20 ` kernel test robot
2025-05-22 17:33 ` Xin Li
2025-05-22 17:51 ` Andrew Cooper
2025-05-23 6:23 ` Xin Li
2025-05-22 17:54 ` Dave Hansen [this message]
2025-05-23 6:24 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8342ee1c-5adc-4a6a-b4ee-f7d3b42a6528@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®