Re: [PATCH 1/1] perf/core: fix dangling cgroup pointer in cpuctx

[Peter Zijlstra <peterz@infradead.org>]

On Wed, Jun 04, 2025 at 04:16:40PM +0200, Peter Zijlstra wrote:

Alexander, I just noticed:

> @@ -2183,8 +2184,7 @@ static void perf_put_aux_event(struct perf_event *event)
>  		 * state so that we don't try to schedule it again. Note
>  		 * that perf_event_enable() will clear the ERROR status.
>  		 */
> -		event_sched_out(iter, ctx);
> -		perf_event_set_state(event, PERF_EVENT_STATE_ERROR);

That this is scheduling out the sibling, and marking the group leader
ERROR; surely this is a mistake?

> +		__event_disable(event, ctx, PERF_EVENT_STATE_ERROR);
>  	}
>  }