From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Francesco Lavra" <flavra@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/6] iio: ABI: Add partial quaternion modifier
Date: Sat, 7 Mar 2026 13:00:58 +0000 [thread overview]
Message-ID: <20260307130058.190a0596@jic23-huawei> (raw)
In-Reply-To: <aakrCIJBdHb1T30Y@ashevche-desk.local>
On Thu, 5 Mar 2026 09:04:40 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Mar 04, 2026 at 04:35:39PM -0600, David Lechner wrote:
> > On 3/4/26 2:07 AM, Francesco Lavra wrote:
>
> ...
>
> > > + - the quaternion vector is normalized, i.e. x^2 + y^2 + z^2 + w^2 = 1
> >
> > Isn't this usually written with w first?
> >
> > > + - the rotation angle is within the [-180, 180] range, i.e. the w
> >
> > Best to say the angle units. IIO standard unit for angle is radians.
> >
> > > + component (which represents the amount of rotation) is non-negative
>
> Based on these, maybe the name should be
>
> normalised_360_quaternion
>
> (or variations of this)? Actually "partial" quaternion some articles use
> for something different as far as I can say.
The "axis" naming for the define is probably as good as we can do for
something that is mathematically dubious in my view. There are two many
ways it could be interpreted and I'd be surprised if this does get used
in other devices, and they all pick the same way of filling in the
missing constraint.
Mind you I never much like quaternion's (part of my PhD was on Clifford /
Geometric algebra's and exponentials of bivectors are so much cleaner :)
Jonathan
>
next prev parent reply other threads:[~2026-03-07 13:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 8:05 [PATCH v7 0/6] imu: st_lsm6dsx: Add support for rotation sensor Francesco Lavra
2026-03-04 8:06 ` [PATCH v7 1/6] iio: imu: st_lsm6dsx: Fix check for invalid samples from FIFO Francesco Lavra
2026-03-07 12:46 ` Jonathan Cameron
2026-03-07 15:23 ` Lorenzo Bianconi
2026-03-07 17:04 ` Jonathan Cameron
2026-03-07 17:20 ` Lorenzo Bianconi
2026-03-04 8:06 ` [PATCH v7 2/6] iio: Replace 'sign' field with union in struct iio_scan_type Francesco Lavra
2026-03-04 22:55 ` David Lechner
2026-03-07 12:47 ` Jonathan Cameron
2026-03-07 13:10 ` Jonathan Cameron
2026-03-04 8:06 ` [PATCH v7 3/6] iio: tools: Add support for floating-point numbers in buffer scan elements Francesco Lavra
2026-03-04 22:53 ` David Lechner
2026-03-04 8:06 ` [PATCH v7 4/6] iio: ABI: " Francesco Lavra
2026-03-04 22:45 ` David Lechner
2026-03-05 9:09 ` Francesco Lavra
2026-03-05 9:23 ` Andy Shevchenko
2026-03-05 14:37 ` David Lechner
2026-03-06 12:09 ` Andy Shevchenko
2026-03-07 12:51 ` Jonathan Cameron
2026-03-17 10:40 ` Francesco Lavra
2026-03-04 8:07 ` [PATCH v7 5/6] iio: ABI: Add partial quaternion modifier Francesco Lavra
2026-03-04 11:51 ` Andy Shevchenko
2026-03-04 14:21 ` Francesco Lavra
2026-03-04 22:42 ` David Lechner
2026-03-05 8:50 ` Francesco Lavra
2026-03-05 14:40 ` David Lechner
2026-03-06 12:10 ` Andy Shevchenko
2026-03-04 19:25 ` kernel test robot
2026-03-04 22:35 ` David Lechner
2026-03-05 7:04 ` Andy Shevchenko
2026-03-07 13:00 ` Jonathan Cameron [this message]
2026-03-07 13:03 ` Jonathan Cameron
2026-03-08 20:27 ` Andy Shevchenko
2026-03-14 11:14 ` Jonathan Cameron
2026-03-07 13:05 ` Jonathan Cameron
2026-03-04 8:07 ` [PATCH v7 6/6] iio: imu: st_lsm6dsx: Add support for rotation sensor Francesco Lavra
2026-03-04 13:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307130058.190a0596@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=flavra@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®