* [PATCH] misc: issei: hw_heci: fix dev_err format warnings
@ 2026-07-30 4:22 Randy Dunlap
2026-07-30 5:03 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-07-30 4:22 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Vitaly Lubart, Alexander Usyskin,
Greg Kroah-Hartman, Arnd Bergmann
Use "%u" instead of "%lu" to prevent dev_err format warnings:
In file included from ../drivers/misc/issei/hw_heci.c:7:
../drivers/misc/issei/hw_heci.c: In function ‘heci_write_hbuf’:
../drivers/misc/issei/hw_heci.c:374:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
374 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/misc/issei/hw_heci.c: In function ‘heci_read_hbuf’:
../drivers/misc/issei/hw_heci.c:404:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
404 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 8bf5e84998c3 ("issei: add heci hardware module")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Vitaly Lubart <lubvital@gmail.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
drivers/misc/issei/hw_heci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20260729.orig/drivers/misc/issei/hw_heci.c
+++ linux-next-20260729/drivers/misc/issei/hw_heci.c
@@ -371,7 +371,7 @@ static int heci_write_hbuf(struct issei_
struct issei_heci_hw *hw = to_heci_hw(idev);
if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
- dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
+ dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
data_len, CB_SLOT_SIZE);
return -EINVAL;
}
@@ -401,7 +401,7 @@ static int heci_read_hbuf(struct issei_d
u32 *reg_buf = data;
if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
- dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
+ dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
data_len, CB_SLOT_SIZE);
return -EINVAL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: issei: hw_heci: fix dev_err format warnings
2026-07-30 4:22 [PATCH] misc: issei: hw_heci: fix dev_err format warnings Randy Dunlap
@ 2026-07-30 5:03 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2026-07-30 5:03 UTC (permalink / raw)
To: linux-kernel
Cc: Vitaly Lubart, Alexander Usyskin, Greg Kroah-Hartman, Arnd Bergmann
On 7/29/26 9:22 PM, Randy Dunlap wrote:
> Use "%u" instead of "%lu" to prevent dev_err format warnings:
>
> In file included from ../drivers/misc/issei/hw_heci.c:7:
> ../drivers/misc/issei/hw_heci.c: In function ‘heci_write_hbuf’:
> ../drivers/misc/issei/hw_heci.c:374:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
> 374 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/misc/issei/hw_heci.c: In function ‘heci_read_hbuf’:
> ../drivers/misc/issei/hw_heci.c:404:37: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
> 404 | dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8bf5e84998c3 ("issei: add heci hardware module")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Vitaly Lubart <lubvital@gmail.com>
> Cc: Alexander Usyskin <alexander.usyskin@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
>
> drivers/misc/issei/hw_heci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20260729.orig/drivers/misc/issei/hw_heci.c
> +++ linux-next-20260729/drivers/misc/issei/hw_heci.c
> @@ -371,7 +371,7 @@ static int heci_write_hbuf(struct issei_
> struct issei_heci_hw *hw = to_heci_hw(idev);
>
> if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
> - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
> data_len, CB_SLOT_SIZE);
> return -EINVAL;
> }
> @@ -401,7 +401,7 @@ static int heci_read_hbuf(struct issei_d
> u32 *reg_buf = data;
>
> if (!IS_ALIGNED(data_len, CB_SLOT_SIZE)) {
> - dev_err(&idev->dev, "Data size %zu not aligned to slot size %lu\n",
> + dev_err(&idev->dev, "Data size %zu not aligned to slot size %u\n",
> data_len, CB_SLOT_SIZE);
> return -EINVAL;
> }
Please ignore for now.
I get conflicting reports before/after this patch. (!?)
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-30 5:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-30 4:22 [PATCH] misc: issei: hw_heci: fix dev_err format warnings Randy Dunlap
2026-07-30 5:03 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®