* [PATCH v2 1/2] staging: rtl8723bs: remove unused 'pwrdown' from struct hal_com_data
2026-08-08 18:55 [PATCH v2 0/2] staging: rtl8723bs: remove pwrdown field & related function Nikolay Kulikov
@ 2026-08-08 18:55 ` Nikolay Kulikov
2026-08-08 18:55 ` [PATCH v2 2/2] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Nikolay Kulikov
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Kulikov @ 2026-08-08 18:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Dan Carpenter, linux-staging, linux-kernel, Nikolay Kulikov
This field is used only in the HalDetectPwrDownMode() functions. Replace
it with a direct return of a boolean value.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +-------
drivers/staging/rtl8723bs/include/hal_data.h | 3 ---
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 57d2925642e7..b9a7b03e2586 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -544,18 +544,12 @@ static void _RfPowerSave(struct adapter *padapter)
static bool HalDetectPwrDownMode(struct adapter *Adapter)
{
u8 tmpvalue;
- struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter);
rtw_efuse_shadow_read(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue);
/* 2010/08/25 MH INF priority > PDN Efuse value. */
- if (tmpvalue & BIT(4) && pwrctrlpriv->reg_pdnmode)
- pHalData->pwrdown = true;
- else
- pHalData->pwrdown = false;
-
- return pHalData->pwrdown;
+ return (tmpvalue & BIT(4)) && pwrctrlpriv->reg_pdnmode;
} /* HalDetectPwrDownMode */
u32 rtl8723bs_hal_init(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index f67ca496902a..57a18da67fc9 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -234,9 +234,6 @@ struct hal_com_data {
u8 u1ForcedIgiLb; /* forced IGI lower bound */
- /* 2010/08/09 MH Add CU power down mode. */
- bool pwrdown;
-
u8 OutEpQueueSel;
u8 OutEpNumber;
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 2/2] staging: rtl8723bs: remove static HalDetectPwrDownMode() function
2026-08-08 18:55 [PATCH v2 0/2] staging: rtl8723bs: remove pwrdown field & related function Nikolay Kulikov
2026-08-08 18:55 ` [PATCH v2 1/2] staging: rtl8723bs: remove unused 'pwrdown' from struct hal_com_data Nikolay Kulikov
@ 2026-08-08 18:55 ` Nikolay Kulikov
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Kulikov @ 2026-08-08 18:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Dan Carpenter, linux-staging, linux-kernel, Nikolay Kulikov
The return value of this function is ignored at the call site, and since
the function has no side effects, it can be removed.
At the same time, remove the efuse shadow functions, as they are
becoming unused.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 75 ---------------------------
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18 -------
drivers/staging/rtl8723bs/include/rtw_efuse.h | 1 -
3 files changed, 94 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 168ecb7a998f..7e215c9845f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -145,54 +145,6 @@ static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse)
Hal_EfusePowerSwitch(padapter, false);
}
-/*-----------------------------------------------------------------------------
- * Function: efuse_ShadowRead1Byte
- * efuse_ShadowRead2Byte
- * efuse_ShadowRead4Byte
- *
- * Overview: Read from efuse init map by one/two/four bytes !!!!!
- *
- * Input: NONE
- *
- * Output: NONE
- *
- * Return: NONE
- *
- * Revised History:
- * When Who Remark
- * 11/12/2008 MHC Create Version 0.
- *
- */
-static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8 *Value)
-{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
-
- *Value = pEEPROM->efuse_eeprom_data[Offset];
-
-} /* EFUSE_ShadowRead1Byte */
-
-/* Read Two Bytes */
-static void efuse_ShadowRead2Byte(struct adapter *padapter, u16 Offset, u16 *Value)
-{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
-
- *Value = pEEPROM->efuse_eeprom_data[Offset];
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8;
-
-} /* EFUSE_ShadowRead2Byte */
-
-/* Read Four Bytes */
-static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Value)
-{
- struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
-
- *Value = pEEPROM->efuse_eeprom_data[Offset];
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8;
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 2] << 16;
- *Value |= pEEPROM->efuse_eeprom_data[Offset + 3] << 24;
-
-} /* efuse_ShadowRead4Byte */
-
/*-----------------------------------------------------------------------------
* Function: rtw_efuse_shadow_map_update
*
@@ -224,30 +176,3 @@ void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType)
/* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */
/* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */
} /* rtw_efuse_shadow_map_update */
-
-/*-----------------------------------------------------------------------------
- * Function: rtw_efuse_shadow_read
- *
- * Overview: Read from efuse init map !!!!!
- *
- * Input: NONE
- *
- * Output: NONE
- *
- * Return: NONE
- *
- * Revised History:
- * When Who Remark
- * 11/12/2008 MHC Create Version 0.
- *
- */
-void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value)
-{
- if (Type == 1)
- efuse_ShadowRead1Byte(padapter, Offset, (u8 *)Value);
- else if (Type == 2)
- efuse_ShadowRead2Byte(padapter, Offset, (u16 *)Value);
- else if (Type == 4)
- efuse_ShadowRead4Byte(padapter, Offset, (u32 *)Value);
-
-} /* rtw_efuse_shadow_read*/
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index b9a7b03e2586..001b4b32c02e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -538,20 +538,6 @@ static void _RfPowerSave(struct adapter *padapter)
/* YJ, TODO */
}
-/* */
-/* 2010/08/09 MH Add for power down check. */
-/* */
-static bool HalDetectPwrDownMode(struct adapter *Adapter)
-{
- u8 tmpvalue;
- struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter);
-
- rtw_efuse_shadow_read(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue);
-
- /* 2010/08/25 MH INF priority > PDN Efuse value. */
- return (tmpvalue & BIT(4)) && pwrctrlpriv->reg_pdnmode;
-} /* HalDetectPwrDownMode */
-
u32 rtl8723bs_hal_init(struct adapter *padapter)
{
s32 ret;
@@ -626,10 +612,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
if (pwrctrlpriv->reg_rfoff)
pwrctrlpriv->rf_pwrstate = rf_off;
- /* 2010/08/09 MH We need to check if we need to turnon or off RF after detecting */
- /* HW GPIO pin. Before PHY_RFConfig8192C. */
- HalDetectPwrDownMode(padapter);
-
/* Save target channel */
/* <Roger_Notes> Current Channel will be updated again later. */
pHalData->CurrentChannel = 6;
diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h
index 808ba94a5998..a60e05cf699c 100644
--- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
+++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
@@ -73,6 +73,5 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data);
u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address);
void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType);
-void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value);
#endif
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread