* [PATCH] f2fs: fix error handling on device alias check in rename and unlink
@ 2026-08-21 1:18 Daeho Jeong
2026-08-21 1:31 ` [f2fs-dev] " Chao Yu
2026-08-21 8:21 ` Christophe JAILLET
0 siblings, 2 replies; 4+ messages in thread
From: Daeho Jeong @ 2026-08-21 1:18 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong, stable
From: Daeho Jeong <daehojeong@google.com>
In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when
encountering a device aliasing file bypasses the cleanup path.
Fix this by setting err to -EPERM and jumping to the proper cleanup
labels (out_dir and out) instead of returning immediately.
Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing")
Cc: stable@kernel.org
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
fs/f2fs/namei.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 784f636244e1..b9b15c5d28de 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -571,8 +571,10 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
trace_f2fs_unlink_enter(dir, dentry);
- if (IS_DEVICE_ALIASING(inode))
- return -EPERM;
+ if (IS_DEVICE_ALIASING(inode)) {
+ err = -EPERM;
+ goto out;
+ }
if (unlikely(f2fs_cp_error(sbi))) {
err = -EIO;
@@ -1025,8 +1027,10 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
}
if (new_inode) {
- if (IS_DEVICE_ALIASING(new_inode))
- return -EPERM;
+ if (IS_DEVICE_ALIASING(new_inode)) {
+ err = -EPERM;
+ goto out_dir;
+ }
err = -ENOTEMPTY;
if (old_is_dir && !f2fs_empty_dir(new_inode))
--
2.55.0.766.g2966f0265a-goog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix error handling on device alias check in rename and unlink
2026-08-21 1:18 [PATCH] f2fs: fix error handling on device alias check in rename and unlink Daeho Jeong
@ 2026-08-21 1:31 ` Chao Yu
2026-08-21 8:21 ` Christophe JAILLET
1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2026-08-21 1:31 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team
Cc: chao, Daeho Jeong, stable
On 8/21/26 09:18, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when
> encountering a device aliasing file bypasses the cleanup path.
>
> Fix this by setting err to -EPERM and jumping to the proper cleanup
> labels (out_dir and out) instead of returning immediately.
>
> Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing")
> Cc: stable@kernel.org
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] f2fs: fix error handling on device alias check in rename and unlink
2026-08-21 1:18 [PATCH] f2fs: fix error handling on device alias check in rename and unlink Daeho Jeong
2026-08-21 1:31 ` [f2fs-dev] " Chao Yu
@ 2026-08-21 8:21 ` Christophe JAILLET
1 sibling, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2026-08-21 8:21 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team
Cc: Daeho Jeong, stable
Le 21/08/2026 à 03:18, Daeho Jeong a écrit :
> From: Daeho Jeong <daehojeong@google.com>
>
> In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when
> encountering a device aliasing file bypasses the cleanup path.
>
> Fix this by setting err to -EPERM and jumping to the proper cleanup
> labels (out_dir and out) instead of returning immediately.
>
> Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing")
> Cc: stable@kernel.org
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Hi,
if possible, a
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
would be appreciated.
CJ> ---
> fs/f2fs/namei.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 784f636244e1..b9b15c5d28de 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -571,8 +571,10 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
>
> trace_f2fs_unlink_enter(dir, dentry);
>
> - if (IS_DEVICE_ALIASING(inode))
> - return -EPERM;
> + if (IS_DEVICE_ALIASING(inode)) {
> + err = -EPERM;
> + goto out;
> + }
>
> if (unlikely(f2fs_cp_error(sbi))) {
> err = -EIO;
> @@ -1025,8 +1027,10 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
> }
>
> if (new_inode) {
> - if (IS_DEVICE_ALIASING(new_inode))
> - return -EPERM;
> + if (IS_DEVICE_ALIASING(new_inode)) {
> + err = -EPERM;
> + goto out_dir;
> + }
>
> err = -ENOTEMPTY;
> if (old_is_dir && !f2fs_empty_dir(new_inode))
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] f2fs: fix error handling on device alias check in rename and unlink
@ 2026-08-21 14:17 Daeho Jeong
0 siblings, 0 replies; 4+ messages in thread
From: Daeho Jeong @ 2026-08-21 14:17 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team
Cc: Daeho Jeong, stable, Christophe JAILLET, Chao Yu
From: Daeho Jeong <daehojeong@google.com>
In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when
encountering a device aliasing file bypasses the cleanup path.
Fix this by setting err to -EPERM and jumping to the proper cleanup
labels (out_dir and out) instead of returning immediately.
Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing")
Cc: stable@kernel.org
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 784f636244e1..b9b15c5d28de 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -571,8 +571,10 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
trace_f2fs_unlink_enter(dir, dentry);
- if (IS_DEVICE_ALIASING(inode))
- return -EPERM;
+ if (IS_DEVICE_ALIASING(inode)) {
+ err = -EPERM;
+ goto out;
+ }
if (unlikely(f2fs_cp_error(sbi))) {
err = -EIO;
@@ -1025,8 +1027,10 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
}
if (new_inode) {
- if (IS_DEVICE_ALIASING(new_inode))
- return -EPERM;
+ if (IS_DEVICE_ALIASING(new_inode)) {
+ err = -EPERM;
+ goto out_dir;
+ }
err = -ENOTEMPTY;
if (old_is_dir && !f2fs_empty_dir(new_inode))
--
2.55.0.766.g2966f0265a-goog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-21 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-21 1:18 [PATCH] f2fs: fix error handling on device alias check in rename and unlink Daeho Jeong
2026-08-21 1:31 ` [f2fs-dev] " Chao Yu
2026-08-21 8:21 ` Christophe JAILLET
2026-08-21 14:17 Daeho Jeong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®