Re: [PATCH v2] staging: axis-fifo: remove unused r_mem local variable

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Oct 23, 2026 at 07:39:43AM -0300, Breno Rodrigues Alves wrote:
> Remove 'struct resource *r_mem' from axis_fifo_probe().  It is filled
> in by devm_platform_get_and_ioremap_resource() but never read; pass
> NULL instead.
> 
> This is v2 of a three-change series.  The debugfs_create_dir() check
> was dropped because debugfs has handled ERR_PTR parents gracefully
> since 2019 (thanks Greg and Dan for the correction).  The
> -EINVAL -> -ENOBUFS change was dropped as well, after Dan Carpenter
> noted that -EINVAL is the common errno for this path and that he
> would leave the choice to the author.
> 
> Signed-off-by: Breno Rodrigues Alves <breno3011alves@gmail.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3d358f919..464368e04 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -428,7 +428,6 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
>  
>  static int axis_fifo_probe(struct platform_device *pdev)
>  {
> -	struct resource *r_mem;
>  	struct device *dev = &pdev->dev;
>  	struct axis_fifo *fifo = NULL;
>  	int rc = 0; /* error return value */
> @@ -447,7 +446,7 @@ static int axis_fifo_probe(struct platform_device *pdev)
>  	mutex_init(&fifo->read_lock);
>  	mutex_init(&fifo->write_lock);
>  
> -	fifo->base_addr = devm_platform_get_and_ioremap_resource(pdev, 0, &r_mem);
> +	fifo->base_addr = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

This doesn't make sense, if r_mem is really not needed, then call the
proper function instead (exercise left to the reader to determine what
that is...)

And how was this found?

How was this tested?

thanks,

greg k-h