mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: SJ Park <sj@kernel.org>, Aveline Noir <jm5905938@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] Docs/admin-guide/mm/damon/stat: fix pronoun agreement
Date: Mon, 26 Oct 2026 07:31:07 -0700	[thread overview]
Message-ID: <20261026143109.150059-1-sj@kernel.org> (raw)
In-Reply-To: <203ef50d11ae600ab06546d73a2290f291381551.camel@mailbox.org>

On Mon, 26 Oct 2026 13:44:55 +0100 Manuel Ebner <manuelebnerli@mailbox.org> wrote:

> Hi Aveline,
> 
> On Mon, 2026-10-26 at 22:14 +1100, Aveline Noir wrote:
> > "converts it" refers to the access events, so I think it should be
> > "them".  Rewrap the paragraph while at it.
> > 
> > Signed-off-by: Aveline Noir <jm5905938@gmail.com>
> > ---
> >  Documentation/admin-guide/mm/damon/stat.rst | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/mm/damon/stat.rst b/Documentation/admin-guide/mm/damon/stat.rst
> > index 4a9db755a526..a93609649a5f 100644
> > --- a/Documentation/admin-guide/mm/damon/stat.rst
> > +++ b/Documentation/admin-guide/mm/damon/stat.rst
> 
> Here I found this one:
> @@ -41,8 +41,8 @@ enabled
>  
>  Enable or disable DAMON_STAT.
>  
> -You can enable DAMON_STAT by setting the value of this parameter as ``Y``.
> -Setting it as ``N`` disables DAMON_STAT.  The default value is set by
> +You can enable DAMON_STAT by setting the value of this parameter to ``Y``.
> +Setting it to ``N`` disables DAMON_STAT.  The default value is set by
>  ``CONFIG_DAMON_STAT_ENABLED_DEFAULT`` build config option.

Thanks.  Unless Aveline objects or add this part to the next revision of this
patch, I will add this  when I apply this patch to damon/next.

>  
> > @@ -68,10 +68,10 @@ estimated_memory_bandwidth
> >  Estimated memory bandwidth consumption (bytes per second) of the system.
> >  
> >  DAMON_STAT reads observed access events on the current DAMON results snapshot
> > -and converts it to memory bandwidth consumption estimation in bytes per second.
> > -The resulting metric is exposed to user via this read-only parameter.  Because
> > -DAMON uses sampling, this is only an estimation of the access intensity rather
> > -than accurate memory bandwidth.
> > +and converts them to memory bandwidth consumption estimation in bytes per
> > +second.  The resulting metric is exposed to user via this read-only parameter.
> > +Because DAMON uses sampling, this is only an estimation of the access intensity
> > +rather than accurate memory bandwidth.
> >  
> >  memory_idle_ms_percentiles
> >  --------------------------
> 
> 
> Thanks,
> Reviewed-by: Manuel Ebner <manuelebnerli@mailbox.org>

Thank you for your review.


Thanks,
SJ

  reply	other threads:[~2026-10-26 14:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 11:14 [PATCH 0/8] Docs: damon: fix grammar and typos Aveline Noir
2026-10-26 11:14 ` [PATCH 1/8] Docs/admin-guide/mm/damon/start: fix grammar Aveline Noir
2026-10-26 12:41   ` Manuel Ebner
2026-10-26 14:29     ` SJ Park
2026-10-26 15:50       ` Aveline Noir
2026-10-26 14:10   ` SJ Park
2026-10-26 11:14 ` [PATCH 2/8] Docs/admin-guide/mm/damon/stat: fix pronoun agreement Aveline Noir
2026-10-26 12:44   ` Manuel Ebner
2026-10-26 14:31     ` SJ Park [this message]
2026-10-26 15:50       ` Aveline Noir
2026-10-26 14:24   ` SJ Park
2026-10-26 11:14 ` [PATCH 3/8] Docs/admin-guide/mm/damon/usage: fix grammar Aveline Noir
2026-10-26 14:37   ` SJ Park
2026-10-26 11:14 ` [PATCH 4/8] Docs/admin-guide/mm/damon/lru_sort: fix remaining grammar Aveline Noir
2026-10-26 12:57   ` Manuel Ebner
2026-10-26 14:44     ` SJ Park
2026-10-26 15:50       ` Aveline Noir
2026-10-26 14:42   ` SJ Park
2026-10-26 11:14 ` [PATCH 5/8] Docs/mm/damon/design: fix grammar and typos Aveline Noir
2026-10-26 14:54   ` SJ Park
2026-10-26 11:14 ` [PATCH 6/8] Docs/mm/damon/api: fix verb form Aveline Noir
2026-10-26 14:55   ` SJ Park
2026-10-26 11:14 ` [PATCH 7/8] Docs/mm/damon/maintainer-profile: fix subject-verb agreement Aveline Noir
2026-10-26 14:56   ` SJ Park
2026-10-26 11:14 ` [PATCH 8/8] Docs/mm/damon/monitoring_intervals_tuning_example: fix grammar and typos Aveline Noir
2026-10-26 14:59   ` SJ Park
2026-10-27  0:49 ` [PATCH 0/8] Docs: damon: " SJ Park
2026-10-27  2:46   ` Aveline Noir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026143109.150059-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=jm5905938@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=manuelebnerli@mailbox.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®