mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qiliang Yuan <odys.yuan@gmail.com>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Stuart Hayes <stuart.w.hayes@gmail.com>
Subject: Re: [PATCH 2/2] block: set QUEUE_FLAG_NO_ELV_SWITCH under the read lock in del_gendisk()
Date: Tue,  3 Nov 2026 01:20:23 -0500	[thread overview]
Message-ID: <20261103062023.2910587-1-odys.yuan@gmail.com> (raw)
In-Reply-To: <44b0d0e5-b14f-4e6c-8e00-16b4af712b7d@linux.ibm.com>

On Tue, 3 Nov 2026 11:23:59 +0530, Nilay Shroff wrote:
> Currently, there's a patch[1] in-review to change update_nr_hwq_lock from
> write to read while switching elevator.
>
> So the proposal in this patch may not work out if the changes in patch[1]
> are accepted. I understand your proposed patchset but I'd recommend wait a
> bit till we settle with the patch[1].
>
> [1] https://lore.kernel.org/all/20261031044141.5569-1-laveeshb@laveeshbansal.com/

Right, with [1] a switch holds the lock for read and uses
QUEUE_FLAG_NO_ELV_SWITCH as its busy bit, so setting the flag under the
read lock here could be undone by a switch that is still running.

I'll drop this patch, send patch 1 on its own, and come back to this
once [1] has settled.

Thanks,
Qiliang

      reply	other threads:[~2026-11-03  6:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  6:14 [PATCH 0/2] nvme: delete controllers with many namespaces faster Qiliang Yuan
2026-11-02  6:14 ` [PATCH 1/2] nvme: remove namespaces in parallel Qiliang Yuan
2026-11-02  7:26   ` Hannes Reinecke
2026-11-02  8:00     ` Qiliang Yuan
2026-11-02  9:27       ` Hannes Reinecke
2026-11-02  6:14 ` [PATCH 2/2] block: set QUEUE_FLAG_NO_ELV_SWITCH under the read lock in del_gendisk() Qiliang Yuan
2026-11-02  7:22   ` Hannes Reinecke
2026-11-03  5:53   ` Nilay Shroff
2026-11-03  6:20     ` Qiliang Yuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103062023.2910587-1-odys.yuan@gmail.com \
    --to=odys.yuan@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=stuart.w.hayes@gmail.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®