mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Casco <jesse.casco@gmail.com>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Suresh Vankadara <svankada@qti.qualcomm.com>,
	Vikram Sharma <vikram.sharma@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: glymur: Add camera MCLK pinctrl
Date: Tue, 10 Nov 2026 17:12:32 -0500	[thread overview]
Message-ID: <20261110221232.3883-1-jesse.casco@gmail.com> (raw)
In-Reply-To: <20261015-glymur_camss_dts-v2-3-e7b1f403146f@oss.qualcomm.com>

On Thu, Oct 15, 2026 at 04:22:28PM +0530, Nihal Kumar Gupta wrote:
> +			cam_mclk4_default: cam-mclk4-default-state {
> +				pins = "gpio100";
> +				function = "cam_asc_mclk4";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};

I've been running this series on an ASUS Zenbook A16 (UX3607OA), which
has an OV02C10 on MCLK4 at 19.2 MHz. With 2 mA here the sensor shows
horizontal banding, and its frame period stretches by about 9%, whenever
the internal DMIC clock (LPASS LPI GPIO6, 2.4 MHz) is running. The bands
are already in the RAW10 frames, and the sensor test pattern is clean,
so it looks like the MCLK pad itself rather than CSI or the ISP.

Changing only this pin to 6 mA fixes it. A/B/A across three boots, same
kernel, fixed exposure/gain, row high-pass RMS / frame period:

  MCLK4   mic off          mic on            after
  2 mA    0.96 / 33.28 ms  20.44 / 36.17 ms  1.04 / 33.27 ms
  6 mA    0.89 / 33.27 ms   0.90 / 33.27 ms  0.90 / 33.27 ms
  2 mA    0.95 / 33.27 ms  15.33 / 34.37 ms  0.93 / 33.28 ms

At 6 mA the frame timing holds steady at 33.27 ms and the image stays
clean in every phase, including while the microphone is recording,
which is exactly the case that couples interference into the 2 mA
clock. Normal camera use with the mic on is also clean at 6 mA, so the
fix holds up on real hardware, not just in the capture script.

Could cam_mclk4_default use 6 mA? If you'd rather keep 2 mA in the SoC
dtsi, I'll override it in the A16 board DT instead.

Thanks,
Jesse

  reply	other threads:[~2026-11-10 22:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 10:52 [PATCH v2 0/6] Add CCI and CAMSS support for Glymur Nihal Kumar Gupta
2026-10-15 10:52 ` [PATCH v2 1/6] arm64: dts: qcom: glymur: Add CAMSS and CSIPHY nodes " Nihal Kumar Gupta
2026-10-21  8:54   ` Konrad Dybcio
2026-10-15 10:52 ` [PATCH v2 2/6] arm64: dts: qcom: glymur: Add CCI definitions " Nihal Kumar Gupta
2026-10-15 10:52 ` [PATCH v2 3/6] arm64: dts: qcom: glymur: Add camera MCLK pinctrl Nihal Kumar Gupta
2026-11-10 22:12   ` Jesse Casco [this message]
2026-10-15 10:52 ` [PATCH v2 4/6] arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC Nihal Kumar Gupta
2026-10-19 12:08   ` Konrad Dybcio
2026-10-26  5:19     ` Jishnu Prakash
2026-10-15 10:52 ` [PATCH v2 5/6] arm64: dts: qcom: glymur-crd: Add ov08x40 RGB sensor on CSIPHY4 Nihal Kumar Gupta
2026-10-21  8:51   ` Konrad Dybcio
2026-10-15 10:52 ` [PATCH v2 6/6] arm64: defconfig: Enable OV08X40 camera sensor driver Nihal Kumar Gupta
2026-10-31 16:24 ` [PATCH v2 0/6] Add CCI and CAMSS support for Glymur Christian Cortner
2026-11-03 18:25   ` Nihal Kumar Gupta
2026-11-04  7:47     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110221232.3883-1-jesse.casco@gmail.com \
    --to=jesse.casco@gmail.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=svankada@qti.qualcomm.com \
    --cc=vikram.sharma@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®