mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4 0/7] spi: cadence-xspi: Fixes and ACPI changes
@ 2026-11-16 14:49 Paul Cercueil
  2026-11-16 14:49 ` [PATCH v4 1/7] spi: cadence-xspi: Properly handle errors in .transfer_one_message Paul Cercueil
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Paul Cercueil @ 2026-11-16 14:49 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-spi, linux-kernel, Thomas Petazzoni, Bharat Bhushan,
	Sunil Kovvuri Goutham, Tanmay Jagdale, Jisheng Zhang,
	George Cherian, Witold Sadowski, Paul Cercueil

Hi Mark,

This is the v4 of my patchset that adds a few fixes to the cadence-xspi
driver, some cleanups, as well as a workaround for probing the Marvell
IP on firmwares that use the base string.

If that last one is a deal breaker then it can be skipped. Jisheng Zhang
queried the DT maintainers about a clarification on whether or not bugs
in out-of-tree DTs should be cared for, but they haven't responded yet.

The v4 is a minimal update from v3, with the first patch being
different, addressing a small issue reported by Sashiko.

I also imported the "Clear SDMA ready IRQ flag after polling" fix that I
originally sent as part of my 'spi-mem write-on-panic' patchset, a month
ago. It makes sense to have it here, and to group the fixes together,
if only to make it easier for linux-stable to cherry-pick the fixes
later. This patch wasn't modified since the v1 of that other patchset so
there was no history to carry along.

Note that Sashiko will most likely complain about this new patch, as it
thinks that the cdns_xspi_is_sdma_ready() may race against the IRQ
handler, but I think that's a false positive - the function is never
called in a code path where IRQs are enabled at the device level.

Changelog in v4:

- [1/7]: Also reset cdns_xspi->xfer_in_progress on error.

- [4/7]: New patch, imported from the 'spi-mem write-on-panic' patchset

Cheers,
-Paul

Tanmay Jagdale (7):
  spi: cadence-xspi: Properly handle errors in .transfer_one_message
  spi: cadence-xspi: Reconfigure to STIG mode before SPI message
  spi: cadence-xspi: Inform SPI core about size transferred
  spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling
  spi: cadence-xspi: Drop useless cdns_xspi->cur_cs
  spi: cadence-xspi: Rework resource discovery
  spi: cadence-xspi: Add workaround for old Marvell firmwares

 drivers/spi/spi-cadence-xspi.c | 183 ++++++++++++++++++++++-----------
 1 file changed, 124 insertions(+), 59 deletions(-)

-- 
2.47.3


^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH v4 0/7] spi: Add support for panic mem writes
@ 2026-10-16 10:29 Paul Cercueil
  2026-10-16 10:29 ` [PATCH v4 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Paul Cercueil
  0 siblings, 1 reply; 9+ messages in thread
From: Paul Cercueil @ 2026-10-16 10:29 UTC (permalink / raw)
  To: Pratyush Yadav, Michael Walle, Takahiro Kuwano, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Mark Brown
  Cc: Kees Cook, Tony Luck, Guilherme G . Piccoli, Thomas Petazzoni,
	linux-mtd, linux-kernel, linux-spi, Bharat Bhushan,
	Sunil Kovvuri Goutham, Tanmay Jagdale, Paul Cercueil

Hi,

Here is the v4 of my patchset that updates the MTD spi-nor code as well
as the spi-mem code, to add support for panic mem writes to a memory
partition configured as pstore.

This revision adds a workaround in mtd/spi-nor to avoid a call to
kmalloc(), and fixes a kernel doc mismatch.

Changelog:

 - [2/7]:
        - Also update kernel doc for new 'timeout_ms' parameter

 - [3/7]:
        - kmalloc() is not safe in panic context; reuse boucebuf instead

 - Patch [1/7] and 4->7 unchanged since v3.

Cheers,
-Paul

Tanmay Jagdale (7):
  spi: spi-mem: Add support for panic mem writes
  mtd: spi-nor: Wait for NOR ready with poll_timeout_us()
  mtd: spi-nor: Add support for panic writes
  spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling
  spi: cadence-xspi: Add irq-less support
  spi: cadence-xspi: Add support for panic writes
  spi: dt-bindings: cadence: Make XSPI's IRQ line optional

 .../devicetree/bindings/spi/cdns,xspi.yaml    |   1 -
 drivers/mtd/spi-nor/core.c                    | 128 ++++++++++++++----
 drivers/spi/spi-cadence-xspi.c                | 114 +++++++++-------
 drivers/spi/spi-mem.c                         |  42 +++++-
 include/linux/spi/spi-mem.h                   |   5 +
 5 files changed, 209 insertions(+), 81 deletions(-)

-- 
2.47.3


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-16 14:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 14:49 [PATCH v4 0/7] spi: cadence-xspi: Fixes and ACPI changes Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 1/7] spi: cadence-xspi: Properly handle errors in .transfer_one_message Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 2/7] spi: cadence-xspi: Reconfigure to STIG mode before SPI message Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 3/7] spi: cadence-xspi: Inform SPI core about size transferred Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 5/7] spi: cadence-xspi: Drop useless cdns_xspi->cur_cs Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 6/7] spi: cadence-xspi: Rework resource discovery Paul Cercueil
2026-11-16 14:49 ` [PATCH v4 7/7] spi: cadence-xspi: Add workaround for old Marvell firmwares Paul Cercueil
  -- strict thread matches above, loose matches on Subject: below --
2026-10-16 10:29 [PATCH v4 0/7] spi: Add support for panic mem writes Paul Cercueil
2026-10-16 10:29 ` [PATCH v4 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Paul Cercueil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®