mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	 Bartosz Golaszewski <brgl@kernel.org>,
	Kumar Patro <bibek.patro@oss.qualcomm.com>,
	 Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	 Shawn Guo <shengchao.guo@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints
Date: Sat, 21 Nov 2026 10:28:46 +0100	[thread overview]
Message-ID: <20261121-flawless-responsible-cheetah-0c3d87@quoll> (raw)
In-Reply-To: <20261121-red-chachalaca-of-essence-1ccb7c@quoll>

On Sat, Nov 21, 2026 at 10:25:55AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 20, 2026 at 06:50:50PM +0530, Komal Bajaj wrote:
> > The number of IOMMU streams used by a remote processor is not necessarily
> > limited to one. On Shikra, LPAICP uses three streams, while CDSP uses one
> > and MPSS does not use any. The existing single-entry limit therefore cannot
> > describe the LPAICP firmware streams.
> > 
> > Increase the maximum number of iommus entries to three and constrain it per
> > compatible: require three entries for qcom,shikra-lpaicp-pas, allow only
> > one for qcom,shikra-cdsp-pas, and disallow the property for
> > qcom,shikra-mpss-pas.
> > 
> > Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> > ---
> >  .../bindings/remoteproc/qcom,shikra-pas.yaml       | 24 +++++++++++++++++++++-
> >  1 file changed, 23 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > index 74f83b7ce08d..3b827f2aadb4 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > @@ -92,7 +92,8 @@ properties:
> >      description:
> >        IOMMU specifiers of the streams used by the remote processor
> >        firmware for its memory accesses.
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 3
> 
> Review from v4 still applies, you need to list the items, either here
> (if devices share the list) or in if:then: part.

Although if the device does not differentiate them and this is not
flexible, then its fine.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


  reply	other threads:[~2026-11-21  9:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-21  9:27   ` Krzysztof Kozlowski
2026-11-20 13:20 ` [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
2026-11-21  9:25   ` Krzysztof Kozlowski
2026-11-21  9:28     ` Krzysztof Kozlowski [this message]
2026-11-20 13:20 ` [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
2026-11-21  9:29   ` Krzysztof Kozlowski
2026-11-20 13:20 ` [PATCH v7 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 5/5] arm64: dts: qcom: sm8750: Add EL2 overlay for MTP Komal Bajaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-flawless-responsible-cheetah-0c3d87@quoll \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®