* [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
@ 2026-11-20 13:20 ` Komal Bajaj
2026-11-21 9:27 ` Krzysztof Kozlowski
2026-11-20 13:20 ` [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Komal Bajaj @ 2026-11-20 13:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, linux-remoteproc, Komal Bajaj
qcom,pas-common.yaml limits iommus to a single entry for every PAS
remoteproc binding referencing it. This is too restrictive for SoCs
whose firmware uses multiple IOMMU streams, and a schema referencing
the common one cannot relax the inherited limit.
Drop iommus from qcom,pas-common.yaml. As this removes the property
from every binding referencing it, define it in the top-level
properties of each of them, with a description and the same
maxItems: 1 limit, so that SoCs needing a different limit can override
it in their own binding.
No functional change intended.
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 6 ++++++
.../devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml | 3 ---
Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 ++++++
Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6 ++++++
17 files changed, 96 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 6cac1f77993b..99c567da3e98 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -82,6 +82,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- memory-region
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml
index e6c78d621d17..06aeb45fb2d7 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml
@@ -84,6 +84,12 @@ properties:
minItems: 2
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
index b24e6f6eaf37..4a033ccdecbb 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
@@ -76,6 +76,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
index e90d2953ba69..b1d84d8be4c6 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
@@ -89,6 +89,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
index f75cab6b4ed9..4662fe4cff62 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
@@ -32,9 +32,6 @@ properties:
minItems: 5
maxItems: 6
- iommus:
- maxItems: 1
-
power-domains:
minItems: 1
maxItems: 3
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
index bf9bf1af9ff1..c8898a041fb3 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
@@ -67,6 +67,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index dda2d144b720..73d25efed820 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -82,6 +82,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
index b20780e5e26b..33c9ff6522ce 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
@@ -76,6 +76,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
index 4bbe4a986c7c..6bff0ed118a3 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
@@ -73,6 +73,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
index 8c16b01c53e4..83b9d7289e06 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
@@ -79,6 +79,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
index 34a2f15e9361..74f83b7ce08d 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
@@ -88,6 +88,12 @@ properties:
items:
- const: stop
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
index 454ba82bd6f1..6ea56b497f89 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
@@ -79,6 +79,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
index 42e02c64347a..28e44a1dcc7e 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
@@ -73,6 +73,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
index 274f87880e2e..710dae4589b4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
@@ -69,6 +69,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
index 5a7c5f8c92d1..9fbf1b6aed76 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
@@ -89,6 +89,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index 72d0db5698c5..15da49130146 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -83,6 +83,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 99e9aeeb4f62..a3131e6417f5 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -115,6 +115,12 @@ properties:
maxItems: 1
description: The names of the state bits used for SMP2P output
+ iommus:
+ description:
+ IOMMU specifiers of the streams used by the remote processor
+ firmware for its memory accesses.
+ maxItems: 1
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
2026-11-20 13:20 ` [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
@ 2026-11-21 9:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-21 9:27 UTC (permalink / raw)
To: Komal Bajaj
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo, linux-arm-msm, devicetree,
linux-kernel, linux-remoteproc
On Fri, Nov 20, 2026 at 06:50:49PM +0530, Komal Bajaj wrote:
> qcom,pas-common.yaml limits iommus to a single entry for every PAS
> remoteproc binding referencing it. This is too restrictive for SoCs
> whose firmware uses multiple IOMMU streams, and a schema referencing
> the common one cannot relax the inherited limit.
>
> Drop iommus from qcom,pas-common.yaml. As this removes the property
> from every binding referencing it, define it in the top-level
> properties of each of them, with a description and the same
> maxItems: 1 limit, so that SoCs needing a different limit can override
> it in their own binding.
>
> No functional change intended.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
@ 2026-11-20 13:20 ` Komal Bajaj
2026-11-21 9:25 ` Krzysztof Kozlowski
2026-11-20 13:20 ` [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Komal Bajaj @ 2026-11-20 13:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, linux-remoteproc, Komal Bajaj
The number of IOMMU streams used by a remote processor is not necessarily
limited to one. On Shikra, LPAICP uses three streams, while CDSP uses one
and MPSS does not use any. The existing single-entry limit therefore cannot
describe the LPAICP firmware streams.
Increase the maximum number of iommus entries to three and constrain it per
compatible: require three entries for qcom,shikra-lpaicp-pas, allow only
one for qcom,shikra-cdsp-pas, and disallow the property for
qcom,shikra-mpss-pas.
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
.../bindings/remoteproc/qcom,shikra-pas.yaml | 24 +++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
index 74f83b7ce08d..3b827f2aadb4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
@@ -92,7 +92,8 @@ properties:
description:
IOMMU specifiers of the streams used by the remote processor
firmware for its memory accesses.
- maxItems: 1
+ minItems: 1
+ maxItems: 3
required:
- compatible
@@ -125,6 +126,25 @@ allOf:
items:
- const: cx
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,shikra-cdsp-pas
+ then:
+ properties:
+ iommus:
+ maxItems: 1
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,shikra-mpss-pas
+ then:
+ properties:
+ iommus: false
+
- if:
properties:
compatible:
@@ -140,6 +160,8 @@ allOf:
minItems: 2
firmware-name:
minItems: 2
+ iommus:
+ minItems: 3
power-domains: false
power-domain-names: false
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints
2026-11-20 13:20 ` [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
@ 2026-11-21 9:25 ` Krzysztof Kozlowski
2026-11-21 9:28 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-21 9:25 UTC (permalink / raw)
To: Komal Bajaj
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo, linux-arm-msm, devicetree,
linux-kernel, linux-remoteproc
On Fri, Nov 20, 2026 at 06:50:50PM +0530, Komal Bajaj wrote:
> The number of IOMMU streams used by a remote processor is not necessarily
> limited to one. On Shikra, LPAICP uses three streams, while CDSP uses one
> and MPSS does not use any. The existing single-entry limit therefore cannot
> describe the LPAICP firmware streams.
>
> Increase the maximum number of iommus entries to three and constrain it per
> compatible: require three entries for qcom,shikra-lpaicp-pas, allow only
> one for qcom,shikra-cdsp-pas, and disallow the property for
> qcom,shikra-mpss-pas.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
> .../bindings/remoteproc/qcom,shikra-pas.yaml | 24 +++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> index 74f83b7ce08d..3b827f2aadb4 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> @@ -92,7 +92,8 @@ properties:
> description:
> IOMMU specifiers of the streams used by the remote processor
> firmware for its memory accesses.
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
Review from v4 still applies, you need to list the items, either here
(if devices share the list) or in if:then: part.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints
2026-11-21 9:25 ` Krzysztof Kozlowski
@ 2026-11-21 9:28 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-21 9:28 UTC (permalink / raw)
To: Komal Bajaj
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo, linux-arm-msm, devicetree,
linux-kernel, linux-remoteproc
On Sat, Nov 21, 2026 at 10:25:55AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 20, 2026 at 06:50:50PM +0530, Komal Bajaj wrote:
> > The number of IOMMU streams used by a remote processor is not necessarily
> > limited to one. On Shikra, LPAICP uses three streams, while CDSP uses one
> > and MPSS does not use any. The existing single-entry limit therefore cannot
> > describe the LPAICP firmware streams.
> >
> > Increase the maximum number of iommus entries to three and constrain it per
> > compatible: require three entries for qcom,shikra-lpaicp-pas, allow only
> > one for qcom,shikra-cdsp-pas, and disallow the property for
> > qcom,shikra-mpss-pas.
> >
> > Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> > ---
> > .../bindings/remoteproc/qcom,shikra-pas.yaml | 24 +++++++++++++++++++++-
> > 1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > index 74f83b7ce08d..3b827f2aadb4 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > @@ -92,7 +92,8 @@ properties:
> > description:
> > IOMMU specifiers of the streams used by the remote processor
> > firmware for its memory accesses.
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 3
>
> Review from v4 still applies, you need to list the items, either here
> (if devices share the list) or in if:then: part.
Although if the device does not differentiate them and this is not
flexible, then its fine.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 1/5] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 2/5] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
@ 2026-11-20 13:20 ` Komal Bajaj
2026-11-21 9:29 ` Krzysztof Kozlowski
2026-11-20 13:20 ` [PATCH v7 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 5/5] arm64: dts: qcom: sm8750: Add EL2 overlay for MTP Komal Bajaj
4 siblings, 1 reply; 10+ messages in thread
From: Komal Bajaj @ 2026-11-20 13:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, linux-remoteproc, Komal Bajaj
Remote processors behind an IOMMU may use multiple firmware streams. On
SM8750, ADSP uses six IOMMU streams, which exceeds the single entry
currently allowed by the binding. CDSP uses a single stream, while MPSS
does not require any.
Allow up to six iommus entries in the binding. Require six entries for
qcom,sm8750-adsp-pas, disallow the property for qcom,sm8750-mpss-pas,
and retain the single-entry limit for the other compatibles.
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
.../bindings/remoteproc/qcom,sm8550-pas.yaml | 26 +++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index a3131e6417f5..45cc50d9c1b7 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -119,7 +119,8 @@ properties:
description:
IOMMU specifiers of the streams used by the remote processor
firmware for its memory accesses.
- maxItems: 1
+ minItems: 1
+ maxItems: 6
required:
- compatible
@@ -323,6 +324,29 @@ allOf:
- const: mx
- const: nsp
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sm8750-adsp-pas
+ then:
+ properties:
+ iommus:
+ minItems: 6
+ else:
+ properties:
+ iommus:
+ maxItems: 1
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sm8750-mpss-pas
+ then:
+ properties:
+ iommus: false
+
unevaluatedProperties: false
examples:
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP
2026-11-20 13:20 ` [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
@ 2026-11-21 9:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-21 9:29 UTC (permalink / raw)
To: Komal Bajaj
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo, linux-arm-msm, devicetree,
linux-kernel, linux-remoteproc
On Fri, Nov 20, 2026 at 06:50:51PM +0530, Komal Bajaj wrote:
> Remote processors behind an IOMMU may use multiple firmware streams. On
> SM8750, ADSP uses six IOMMU streams, which exceeds the single entry
> currently allowed by the binding. CDSP uses a single stream, while MPSS
> does not require any.
>
> Allow up to six iommus entries in the binding. Require six entries for
> qcom,sm8750-adsp-pas, disallow the property for qcom,sm8750-mpss-pas,
> and retain the single-entry limit for the other compatibles.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 26 +++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v7 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
` (2 preceding siblings ...)
2026-11-20 13:20 ` [PATCH v7 3/5] dt-bindings: remoteproc: qcom,sm8550-pas: Allow 6 iommus for SM8750 ADSP Komal Bajaj
@ 2026-11-20 13:20 ` Komal Bajaj
2026-11-20 13:20 ` [PATCH v7 5/5] arm64: dts: qcom: sm8750: Add EL2 overlay for MTP Komal Bajaj
4 siblings, 0 replies; 10+ messages in thread
From: Komal Bajaj @ 2026-11-20 13:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, linux-remoteproc,
Komal Bajaj, Abel Vesa, Dmitry Baryshkov
All existing Shikra board variants boot Linux under the Gunyah
hypervisor, with Linux running at EL1. Linux can also be booted
directly at EL2 on these devices.
For EL2 boot, describe the IOMMU streams used by the remote
processor firmware in the DeviceTree consumed by Linux. Also
disable GPU zap shader and Iris video codec.
Add an EL2-specific DT overlay and apply it to the Shikra CQM, CQS and
IQS EVK variants to produce -el2.dtb artifacts alongside the standard
DTBs.
Co-developed-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 11 +++++++++++
arch/arm64/boot/dts/qcom/shikra-el2.dtso | 33 ++++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 19310879349d..5c8d179f2792 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -416,9 +416,20 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdx75-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk.dtb
+
+shikra-cqm-evk-el2-dtbs := shikra-cqm-evk.dtb shikra-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-el2.dtb
+
dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk.dtb
+
+shikra-cqs-evk-el2-dtbs := shikra-cqs-evk.dtb shikra-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-el2.dtb
+
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk.dtb
+shikra-iqs-evk-el2-dtbs := shikra-iqs-evk.dtb shikra-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-el2.dtb
+
shikra-cqm-evk-imx577-camera-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-imx577-camera.dtbo
shikra-cqs-evk-imx577-camera-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-imx577-camera.dtbo
shikra-iqs-evk-imx577-camera-dtbs := shikra-iqs-evk.dtb shikra-iqs-evk-imx577-camera.dtbo
diff --git a/arch/arm64/boot/dts/qcom/shikra-el2.dtso b/arch/arm64/boot/dts/qcom/shikra-el2.dtso
new file mode 100644
index 000000000000..547db48da476
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/shikra-el2.dtso
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ *
+ * Shikra specific modifications required to boot in EL2.
+ */
+
+/dts-v1/;
+/plugin/;
+
+&gpu_zap_shader {
+ status = "disabled";
+};
+
+&iris {
+ status = "disabled";
+};
+
+&remoteproc_cdsp {
+ iommus = <&apps_smmu 0x0200 0x0>;
+};
+
+&remoteproc_lpaicp {
+ iommus = <&apps_smmu 0x0360 0x0005>,
+ <&apps_smmu 0x0366 0x0000>,
+ <&apps_smmu 0x00e7 0x0000>;
+};
+
+&wifi {
+ wifi-firmware {
+ iommus = <&apps_smmu 0x01a2 0x0001>;
+ };
+};
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v7 5/5] arm64: dts: qcom: sm8750: Add EL2 overlay for MTP
2026-11-20 13:20 [PATCH v7 0/5] arm64: dts: qcom: Add EL2 overlays for Shikra and SM8750 Komal Bajaj
` (3 preceding siblings ...)
2026-11-20 13:20 ` [PATCH v7 4/5] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants Komal Bajaj
@ 2026-11-20 13:20 ` Komal Bajaj
4 siblings, 0 replies; 10+ messages in thread
From: Komal Bajaj @ 2026-11-20 13:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Mathieu Poirier,
Manivannan Sadhasivam, Bartosz Golaszewski, Kumar Patro,
Jingyi Wang, Luca Weiss, Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, linux-remoteproc, Komal Bajaj
SM8750 boards boot Linux under the Gunyah hypervisor, with Linux
running at EL1. Linux can also be booted directly at EL2 on these
devices.
For EL2 boot, describe the IOMMU streams used by the remote processor
firmware in the DeviceTree consumed by Linux. Also disable GPU zap
shader and Iris video codec.
Add an EL2-specific DT overlay and apply it to the SM8750 MTP to
produce sm8750-mtp-el2.dtb alongside the standard DTB.
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 4 ++++
arch/arm64/boot/dts/qcom/sm8750-el2.dtso | 30 ++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 5c8d179f2792..60f627a469e9 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -511,6 +511,10 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8650-valve-deckard.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb
+
+sm8750-mtp-el2-dtbs := sm8750-mtp.dtb sm8750-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp-el2.dtb
+
dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8750-el2.dtso b/arch/arm64/boot/dts/qcom/sm8750-el2.dtso
new file mode 100644
index 000000000000..3e50c50e82dc
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8750-el2.dtso
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+
+ * Pakala specific modifications required to boot in EL2.
+ */
+
+/dts-v1/;
+/plugin/;
+
+&gpu_zap_shader {
+ status = "disabled";
+};
+
+&iris {
+ status = "disabled";
+};
+
+&remoteproc_adsp {
+ iommus = <&apps_smmu 0x1000 0x0>,
+ <&apps_smmu 0x10a0 0x0>,
+ <&apps_smmu 0x00a5 0x0>,
+ <&apps_smmu 0x0425 0x0>,
+ <&apps_smmu 0x0525 0x0>,
+ <&apps_smmu 0x0125 0x0>;
+};
+
+&remoteproc_cdsp {
+ iommus = <&apps_smmu 0x0c00 0x0>;
+};
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread