* Re: Re: [PATCH] meminfo:Don't Account Shared memory in MemAvailable
@ 2016-01-13 3:52 Manjeet Pawar
2016-01-14 0:47 ` David Rientjes
0 siblings, 1 reply; 2+ messages in thread
From: Manjeet Pawar @ 2016-01-13 3:52 UTC (permalink / raw)
To: David Rientjes; +Cc: linux-kernel, Vaneet Narang, AJEET YADAV, PANKAJ MISHRA
>> Instead of using watermark we should subtract SHMEM from pagecache for
>> accounting in available memory
>>
>> Signed-off-by: Vaneet Narang
>> Signed-off-by: Manjeet Pawar
>> Reviewed-by: Ajeet Yadav
>What's missing from your commit description is: why?
Nothing is missing from the commit description, I think this is enough to explain about the patch.
Commit Description : Instead of using watermark we should subtract SHMEM from pagecache for accounting in available memory.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [PATCH] meminfo:Don't Account Shared memory in MemAvailable
2016-01-13 3:52 Re: [PATCH] meminfo:Don't Account Shared memory in MemAvailable Manjeet Pawar
@ 2016-01-14 0:47 ` David Rientjes
0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2016-01-14 0:47 UTC (permalink / raw)
To: Manjeet Pawar; +Cc: linux-kernel, Vaneet Narang, AJEET YADAV, PANKAJ MISHRA
On Wed, 13 Jan 2016, Manjeet Pawar wrote:
> >> Instead of using watermark we should subtract SHMEM from pagecache for
> >> accounting in available memory
> >>
> >> Signed-off-by: Vaneet Narang
> >> Signed-off-by: Manjeet Pawar
> >> Reviewed-by: Ajeet Yadav
>
> >What's missing from your commit description is: why?
> Nothing is missing from the commit description, I think this is enough to explain about the patch.
> Commit Description : Instead of using watermark we should subtract SHMEM from pagecache for accounting in available memory.
NACK to your patch until proper justification for a user-facing change is
provided.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-14 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13 3:52 Re: [PATCH] meminfo:Don't Account Shared memory in MemAvailable Manjeet Pawar
2016-01-14 0:47 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®