Re: [PATCH 07/27] clk: rockchip: Add RK3572 clock and reset support

["Heiko Stübner" <heiko@sntech.de>]

Hi,

Am Mittwoch, 21. Oktober 2026, 18:11:04 Mitteleuropäische Sommerzeit schrieb Cunhao Lu via B4 Relay:
> From: Cunhao Lu <1579567540@qq.com>
> 
> CPU clocks are managed by SCMI. Keep BPLL and LPLL enabled for firmware
> consumers.
> 
> Signed-off-by: Cunhao Lu <1579567540@qq.com>

[...]

> diff --git a/drivers/clk/rockchip/clk-rk3572.c b/drivers/clk/rockchip/clk-rk3572.c
> new file mode 100644
> index 000000000000..78fd35f5f27d
> --- /dev/null
> +++ b/drivers/clk/rockchip/clk-rk3572.c
> @@ -0,0 +1,1972 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025 Rockchip Electronics Co., Ltd.
> + * Author: Elaine Zhang <zhangqing@rock-chips.com>
> + */

As you didn't write this driver on your own and even kept the original
author, please also credit the original author in the commit itself.

This can be done for example with something like
	git commit --amend --author="Elaine Zhang <zhangqing@rock-chips.com>"
and in the commit also have both signed-offs-by, aka Elaine first
then yours below as the submitter, i.e. like

+++++++++++
Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
[document what changes you did inside the brackets]
Signed-off-by: Cunhao Lu <1579567540@qq.com>
+++++++++++

The same applies to all commits coming from the Rockchip vendor kernel.


Thanks
Heiko