mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names
@ 2026-11-06  3:08 Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs Kyle Hsieh
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Kyle Hsieh @ 2026-11-06  3:08 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
	Andrew Jeffery, Ryan Chen, Billy Tsai
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Kyle Hsieh

This series is a follow-up to the Ventura2 devicetree.

Patch 1 describes the three LTC2305 ADCs fitted on Ventura2 and exposes
the valve voltages read by the bus 3 ADCs through iio-hwmon.

The LTC2305 ADCs use their internal 4.096V reference, so no vref-supply
is described. Patch 1 therefore depends on "dt-bindings: iio: adc:
ltc2497: Make vref-supply optional for LTC2305/LTC2309"; without it,
dtbs_check reports a missing vref-supply for the LTC2305 nodes.

Patch 2 names the presence detect GPIO of the optional COM Express
module so userspace can determine whether the module is present.

Patch 3 names the reset GPIOs of the three USB-to-UART bridges so
userspace can reset the bridges.

Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
---
Kyle Hsieh (3):
      ARM: dts: aspeed: ventura2: Add LTC2305 ADCs
      ARM: dts: aspeed: ventura2: Name the COMe presence GPIO
      ARM: dts: aspeed: ventura2: Name the USB-UART bridge reset GPIOs

 .../dts/aspeed/aspeed-bmc-facebook-ventura2.dts    | 36 ++++++++++++++++++++--
 1 file changed, 33 insertions(+), 3 deletions(-)
---
base-commit: f4dcbba2ec358f7079daddcda7594dad9746326a
change-id: 20261106-ventura2-dts-update-f00bc0510b2b

Best regards,
-- 
Kyle Hsieh <kylehsieh1995@gmail.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs
  2026-11-06  3:08 [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Kyle Hsieh
@ 2026-11-06  3:08 ` Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 2/3] ARM: dts: aspeed: ventura2: Name the COMe presence GPIO Kyle Hsieh
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Kyle Hsieh @ 2026-11-06  3:08 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
	Andrew Jeffery, Ryan Chen, Billy Tsai
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Kyle Hsieh

Ventura2 has three LTC2305 2-channel 12-bit ADCs: one behind channel 2
of the PCA9548 mux on I2C bus 0, and two on I2C bus 3 at addresses
0x08 and 0x09. The bus 3 ADCs read the valve voltages.

Describe the ADCs and expose the bus 3 channels through iio-hwmon so
the voltages are reported as hwmon sensors.

The ADCs use their internal 4.096V reference, so no vref-supply is
described.

Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
---
 .../dts/aspeed/aspeed-bmc-facebook-ventura2.dts     | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
index f3dbdece3076..50e652cc37a1 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
@@ -190,7 +190,8 @@ iio-hwmon {
 		io-channels =
 			<&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
 			<&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
-			<&adc1 2>;
+			<&adc1 2>,
+			<&adc_op_fb1 0>, <&adc_op_fb1 1>, <&adc_op_fb2 0>;
 	};
 
 	leds {
@@ -392,6 +393,12 @@ i2c0mux0ch2: i2c@2 {
 			reg = <2>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+
+			adc@8 {
+				compatible = "lltc,ltc2305";
+				reg = <0x08>;
+				#io-channel-cells = <1>;
+			};
 		};
 
 		i2c0mux0ch3: i2c@3 {
@@ -583,6 +590,18 @@ &i2c3 {
 
 	status = "okay";
 
+	adc_op_fb1: adc@8 {
+		compatible = "lltc,ltc2305";
+		reg = <0x08>;
+		#io-channel-cells = <1>;
+	};
+
+	adc_op_fb2: adc@9 {
+		compatible = "lltc,ltc2305";
+		reg = <0x09>;
+		#io-channel-cells = <1>;
+	};
+
 	dac@c {
 		compatible = "adi,ad5612";
 		reg = <0x0c>;

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] ARM: dts: aspeed: ventura2: Name the COMe presence GPIO
  2026-11-06  3:08 [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs Kyle Hsieh
@ 2026-11-06  3:08 ` Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 3/3] ARM: dts: aspeed: ventura2: Name the USB-UART bridge reset GPIOs Kyle Hsieh
  2026-11-09  2:41 ` [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Andrew Jeffery
  3 siblings, 0 replies; 5+ messages in thread
From: Kyle Hsieh @ 2026-11-06  3:08 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
	Andrew Jeffery, Ryan Chen, Billy Tsai
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Kyle Hsieh

Line 9 of the PCA9555 at address 0x23 on I2C bus 3 is the presence
detect of the optional COM Express module. Name it PRSNT_COME_N so
userspace can determine whether the module is present.

Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
index 50e652cc37a1..a9c5990ef969 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
@@ -625,6 +625,17 @@ gpio@23 {
 		reg = <0x23>;
 		#gpio-cells = <2>;
 		gpio-controller;
+
+		gpio-line-names =
+			"", "",
+			"", "",
+			"", "",
+			"", "",
+			"", "PRSNT_COME_N",
+			"", "",
+			"", "",
+			"", "";
+
 		interrupt-parent = <&io_expander7>;
 		interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
 	};

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] ARM: dts: aspeed: ventura2: Name the USB-UART bridge reset GPIOs
  2026-11-06  3:08 [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs Kyle Hsieh
  2026-11-06  3:08 ` [PATCH 2/3] ARM: dts: aspeed: ventura2: Name the COMe presence GPIO Kyle Hsieh
@ 2026-11-06  3:08 ` Kyle Hsieh
  2026-11-09  2:41 ` [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Andrew Jeffery
  3 siblings, 0 replies; 5+ messages in thread
From: Kyle Hsieh @ 2026-11-06  3:08 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
	Andrew Jeffery, Ryan Chen, Billy Tsai
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Kyle Hsieh

Lines 2-4 of the PCA9555 at address 0x20 on I2C bus 6 drive the reset
of the three USB-to-UART bridges. Name them RST_FT4232_{1,2,3}_BMC_N_R
after the schematic nets so userspace can reset the bridges.

Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
index a9c5990ef969..af26256f19f4 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
@@ -1937,8 +1937,8 @@ gpio@20 {
 
 		gpio-line-names =
 			"", "",
-			"", "",
-			"", "PRSNT_FANBP_0_PWR_N",
+			"RST_FT4232_1_BMC_N_R", "RST_FT4232_2_BMC_N_R",
+			"RST_FT4232_3_BMC_N_R", "PRSNT_FANBP_0_PWR_N",
 			"PRSNT_FANBP_0_SIG_N", "PRSNT_POE_PWR_N",
 			"PRSNT_POE_SIG_N", "",
 			"PWRGD_P3V3_ISO_POE_BMC_R", "",

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names
  2026-11-06  3:08 [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Kyle Hsieh
                   ` (2 preceding siblings ...)
  2026-11-06  3:08 ` [PATCH 3/3] ARM: dts: aspeed: ventura2: Name the USB-UART bridge reset GPIOs Kyle Hsieh
@ 2026-11-09  2:41 ` Andrew Jeffery
  3 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2026-11-09  2:41 UTC (permalink / raw)
  To: Kyle Hsieh, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Joel Stanley, Ryan Chen, Billy Tsai
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel

On Fri, 2026-11-06 at 11:08 +0800, Kyle Hsieh wrote:
> This series is a follow-up to the Ventura2 devicetree.
> 
> Patch 1 describes the three LTC2305 ADCs fitted on Ventura2 and exposes
> the valve voltages read by the bus 3 ADCs through iio-hwmon.
> 
> The LTC2305 ADCs use their internal 4.096V reference, so no vref-supply
> is described. Patch 1 therefore depends on "dt-bindings: iio: adc:
> ltc2497: Make vref-supply optional for LTC2305/LTC2309"; without it,
> dtbs_check reports a missing vref-supply for the LTC2305 nodes.

Can you provide a link to this patch? I am yet to find it on lore.

> 
> Patch 2 names the presence detect GPIO of the optional COM Express
> module so userspace can determine whether the module is present.
> 
> Patch 3 names the reset GPIOs of the three USB-to-UART bridges so
> userspace can reset the bridges.

This isn't so much a summary as something self-evident from looking at
the contained patches.

In my opinion what you write here should identify broad patterns across
the patch series (perhaps how you've grouped the patches and why, if
necessary) and not rehash the commit messages.

Andrew

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-09  2:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06  3:08 [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Kyle Hsieh
2026-11-06  3:08 ` [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs Kyle Hsieh
2026-11-06  3:08 ` [PATCH 2/3] ARM: dts: aspeed: ventura2: Name the COMe presence GPIO Kyle Hsieh
2026-11-06  3:08 ` [PATCH 3/3] ARM: dts: aspeed: ventura2: Name the USB-UART bridge reset GPIOs Kyle Hsieh
2026-11-09  2:41 ` [PATCH 0/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs and GPIO line names Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®