[PATCH V2 0/4] Add QFPROM support for few IPQ SoCs

[PATCH V2 0/4] Add QFPROM support for few IPQ SoCs

[Kathiravan T]

Like any other SOCs, Qualcomm's IPQ SOCs also have an efuse region which
exposes the HW quirks like CPU Freq limit and so on. This series add the
basic support for the efuse. Feature specific fuses will be added along
with the feature set.

Kathiravan T (4):
  dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs
  arm64: dts: qcom: ipq5332: add QFPROM node
  arm64: dts: qcom: ipq6018: add QFPROM node
  arm64: dts: qcom: ipq9574: add QFPROM node

 Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
 arch/arm64/boot/dts/qcom/ipq5332.dtsi                    | 7 +++++++
 arch/arm64/boot/dts/qcom/ipq6018.dtsi                    | 7 +++++++
 arch/arm64/boot/dts/qcom/ipq9574.dtsi                    | 7 +++++++
 4 files changed, 24 insertions(+)

-- 
2.17.1

[PATCH V2 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs

[Kathiravan T]

Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- No changes

 Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 8d8503dd934b..076566ef9cc8 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -18,8 +18,11 @@ properties:
       - enum:
           - qcom,apq8064-qfprom
           - qcom,apq8084-qfprom
+          - qcom,ipq5332-qfprom
+          - qcom,ipq6018-qfprom
           - qcom,ipq8064-qfprom
           - qcom,ipq8074-qfprom
+          - qcom,ipq9574-qfprom
           - qcom,msm8916-qfprom
           - qcom,msm8974-qfprom
           - qcom,msm8976-qfprom
-- 
2.17.1

[PATCH V2 2/4] arm64: dts: qcom: ipq5332: add QFPROM node

[Kathiravan T]

IPQ5332 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Pick up R-b tag

 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index af4d97143bcf..c2d6cc65a323 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -135,6 +135,13 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0xffffffff>;
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
+			reg = <0x000a4000 0x721>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		rng: rng@e3000 {
 			compatible = "qcom,prng-ee";
 			reg = <0x000e3000 0x1000>;
-- 
2.17.1

[PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

[Kathiravan T]

IPQ6018 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Reorder the node based on node address

 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index f531797f2619..0f6d6c6daed2 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -302,6 +302,13 @@
 			status = "disabled";
 		};
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
+			reg = <0x0 0x000a4000 0x0 0x2000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		prng: qrng@e1000 {
 			compatible = "qcom,prng-ee";
 			reg = <0x0 0x000e3000 0x0 0x1000>;
-- 
2.17.1

[PATCH V2 4/4] arm64: dts: qcom: ipq9574: add QFPROM node

[Kathiravan T]

IPQ9574 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Pick up R-b tag

 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 1a2c813ffd43..715fe51ff567 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -117,6 +117,13 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0xffffffff>;
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
+			reg = <0x000a4000 0x5a1>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		tlmm: pinctrl@1000000 {
 			compatible = "qcom,ipq9574-tlmm";
 			reg = <0x01000000 0x300000>;
-- 
2.17.1

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

[Konrad Dybcio]

On 26.05.2023 14:53, Kathiravan T wrote:
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> Changes in V2:
> 	- Reorder the node based on node address
> 
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..0f6d6c6daed2 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -302,6 +302,13 @@
>  			status = "disabled";
>  		};
>  
> +		qfprom: efuse@a4000 {
> +			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> +			reg = <0x0 0x000a4000 0x0 0x2000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		prng: qrng@e1000 {
>  			compatible = "qcom,prng-ee";
>  			reg = <0x0 0x000e3000 0x0 0x1000>;

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

[Dmitry Baryshkov]

On Fri, 26 May 2023 at 15:54, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
>         - Reorder the node based on node address
>
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..0f6d6c6daed2 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -302,6 +302,13 @@
>                         status = "disabled";
>                 };
>
> +               qfprom: efuse@a4000 {
> +                       compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> +                       reg = <0x0 0x000a4000 0x0 0x2000>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +               };
> +
>                 prng: qrng@e1000 {
>                         compatible = "qcom,prng-ee";
>                         reg = <0x0 0x000e3000 0x0 0x1000>;

It looks like the prng node name is incorrect. It should be qrng@e3000
instead of qrng@e1000. Could you please send a followup to fix it?

For this patch:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> --
> 2.17.1
>


-- 
With best wishes
Dmitry

Re: [PATCH V2 3/4] arm64: dts: qcom: ipq6018: add QFPROM node

[Konrad Dybcio]

On 26.05.2023 15:22, Dmitry Baryshkov wrote:
> On Fri, 26 May 2023 at 15:54, Kathiravan T <quic_kathirav@quicinc.com> wrote:
>>
>> IPQ6018 has efuse region to determine the various HW quirks. Lets
>> add the initial support and the individual fuses will be added as they
>> are required.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>>         - Reorder the node based on node address
>>
>>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index f531797f2619..0f6d6c6daed2 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -302,6 +302,13 @@
>>                         status = "disabled";
>>                 };
>>
>> +               qfprom: efuse@a4000 {
>> +                       compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
>> +                       reg = <0x0 0x000a4000 0x0 0x2000>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <1>;
>> +               };
>> +
>>                 prng: qrng@e1000 {
>>                         compatible = "qcom,prng-ee";
>>                         reg = <0x0 0x000e3000 0x0 0x1000>;
> 
> It looks like the prng node name is incorrect. It should be qrng@e3000
> instead of qrng@e1000. Could you please send a followup to fix it?
In case that wasn't clear, since I think this series will go in as-is,
that fix would be sent separately, on top of this.

Konrad
> 
> For this patch:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
>> --
>> 2.17.1
>>
> 
> 

Re: [PATCH V2 0/4] Add QFPROM support for few IPQ SoCs

[Bjorn Andersson]

On Fri, 26 May 2023 18:23:01 +0530, Kathiravan T wrote:
> Like any other SOCs, Qualcomm's IPQ SOCs also have an efuse region which
> exposes the HW quirks like CPU Freq limit and so on. This series add the
> basic support for the efuse. Feature specific fuses will be added along
> with the feature set.
> 
> Kathiravan T (4):
>   dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs
>   arm64: dts: qcom: ipq5332: add QFPROM node
>   arm64: dts: qcom: ipq6018: add QFPROM node
>   arm64: dts: qcom: ipq9574: add QFPROM node
> 
> [...]

Applied, thanks!

[1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs
      commit: 8fa13a6e61a799b102b3314c623d27cb8c078d21
[2/4] arm64: dts: qcom: ipq5332: add QFPROM node
      commit: 2f34a2aa4c88f4882e3c5df8c9b78f8bbd3f564f
[3/4] arm64: dts: qcom: ipq6018: add QFPROM node
      commit: 546f0617a22a481f3ca1f7e058aea0c40517c64e
[4/4] arm64: dts: qcom: ipq9574: add QFPROM node
      commit: 05e6b82f395c406333253d6c492d884e7f14ef46

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH V2 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs

[Krzysztof Kozlowski]

On Fri, 26 May 2023 18:23:02 +0530, Kathiravan T wrote:
> Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- No changes
> 
>  Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1786533


qfprom@1b44000: compatible:0: 'qcom,qcm2290-qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcs404-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom']
	arch/arm64/boot/dts/qcom/qrb2210-rb1.dtb

qfprom@1b44000: Unevaluated properties are not allowed ('compatible' was unexpected)
	arch/arm64/boot/dts/qcom/qrb2210-rb1.dtb

qfprom@700000: Unevaluated properties are not allowed ('ranges' was unexpected)
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb

Re: [PATCH V2 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs

[Krzysztof Kozlowski]

On 30/05/2023 14:59, Krzysztof Kozlowski wrote:
> On Fri, 26 May 2023 18:23:02 +0530, Kathiravan T wrote:
>> Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>> 	- No changes
>>
>>  Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1786533
> 
> 
> qfprom@1b44000: compatible:0: 'qcom,qcm2290-qfprom' is not one of ['qcom,apq8064-qfprom', 'qcom,apq8084-qfprom', 'qcom,ipq5332-qfprom', 'qcom,ipq6018-qfprom', 'qcom,ipq8064-qfprom', 'qcom,ipq8074-qfprom', 'qcom,ipq9574-qfprom', 'qcom,msm8916-qfprom', 'qcom,msm8974-qfprom', 'qcom,msm8976-qfprom', 'qcom,msm8996-qfprom', 'qcom,msm8998-qfprom', 'qcom,qcs404-qfprom', 'qcom,sc7180-qfprom', 'qcom,sc7280-qfprom', 'qcom,sdm630-qfprom', 'qcom,sdm670-qfprom', 'qcom,sdm845-qfprom', 'qcom,sm6115-qfprom', 'qcom,sm6350-qfprom', 'qcom,sm6375-qfprom', 'qcom,sm8150-qfprom', 'qcom,sm8250-qfprom']
> 	arch/arm64/boot/dts/qcom/qrb2210-rb1.dtb

Not related, can be ignored.

Best regards,
Krzysztof

Re: [PATCH V2 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs

[Krzysztof Kozlowski]

On 26/05/2023 14:53, Kathiravan T wrote:
> Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- No changes

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof