* [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static
@ 2019-04-18 13:36 Yue Haibing
2019-05-30 15:13 ` Yuehaibing
2019-06-06 8:14 ` Roger Quadros
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-18 13:36 UTC (permalink / raw)
To: kishon, rogerq; +Cc: linux-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/phy/ti/phy-am654-serdes.c:250:12: warning:
symbol 'serdes_am654_xlate' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/phy/ti/phy-am654-serdes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
index d376920..f8edd08 100644
--- a/drivers/phy/ti/phy-am654-serdes.c
+++ b/drivers/phy/ti/phy-am654-serdes.c
@@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x)
mux_control_deselect(phy->control);
}
-struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args
- *args)
+static struct phy *serdes_am654_xlate(struct device *dev,
+ struct of_phandle_args *args)
{
struct serdes_am654 *am654_phy;
struct phy *phy;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static
2019-04-18 13:36 [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static Yue Haibing
@ 2019-05-30 15:13 ` Yuehaibing
2019-06-06 8:14 ` Roger Quadros
1 sibling, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-05-30 15:13 UTC (permalink / raw)
To: kishon, rogerq; +Cc: linux-kernel
Friendly ping...
On 2019/4/18 21:36, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/phy/ti/phy-am654-serdes.c:250:12: warning:
> symbol 'serdes_am654_xlate' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/phy/ti/phy-am654-serdes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
> index d376920..f8edd08 100644
> --- a/drivers/phy/ti/phy-am654-serdes.c
> +++ b/drivers/phy/ti/phy-am654-serdes.c
> @@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x)
> mux_control_deselect(phy->control);
> }
>
> -struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args
> - *args)
> +static struct phy *serdes_am654_xlate(struct device *dev,
> + struct of_phandle_args *args)
> {
> struct serdes_am654 *am654_phy;
> struct phy *phy;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static
2019-04-18 13:36 [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static Yue Haibing
2019-05-30 15:13 ` Yuehaibing
@ 2019-06-06 8:14 ` Roger Quadros
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2019-06-06 8:14 UTC (permalink / raw)
To: Yue Haibing, kishon; +Cc: linux-kernel, hulkci
On 18/04/2019 16:36, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/phy/ti/phy-am654-serdes.c:250:12: warning:
> symbol 'serdes_am654_xlate' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/phy/ti/phy-am654-serdes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
> index d376920..f8edd08 100644
> --- a/drivers/phy/ti/phy-am654-serdes.c
> +++ b/drivers/phy/ti/phy-am654-serdes.c
> @@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x)
> mux_control_deselect(phy->control);
> }
>
> -struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args
> - *args)
> +static struct phy *serdes_am654_xlate(struct device *dev,
> + struct of_phandle_args *args)
> {
> struct serdes_am654 *am654_phy;
> struct phy *phy;
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-06 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 13:36 [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static Yue Haibing
2019-05-30 15:13 ` Yuehaibing
2019-06-06 8:14 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®