From: Darren Hart <dvhart@linux.intel.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
peter.p.waskiewicz.jr@intel.com,
andriy.shevchenko@linux.intel.com, danders@circuitco.com,
vishal.l.verma@intel.com, dvhart@linux.intel.com
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: [PATCH 1/8] pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32
Date: Tue, 25 Jun 2013 18:53:21 -0700 [thread overview]
Message-ID: <28bb2a41e403eac476c2d72a338b8c508a0219c5.1372211451.git.dvhart@linux.intel.com> (raw)
In-Reply-To: <cover.1372211451.git.dvhart@linux.intel.com>
In-Reply-To: <cover.1372211451.git.dvhart@linux.intel.com>
Avoid using magic numbers when we have perfectly good defines just lying
around.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Waskiewicz <peter.p.waskiewicz.jr@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 0c1c65a..6667a6b 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -670,7 +670,7 @@ static int pch_gbe_init_phy(struct pch_gbe_adapter *adapter)
}
adapter->hw.phy.addr = adapter->mii.phy_id;
pr_debug("phy_addr = %d\n", adapter->mii.phy_id);
- if (addr == 32)
+ if (addr == PCH_GBE_PHY_REGS_LEN)
return -EAGAIN;
/* Selected the phy and isolate the rest */
for (addr = 0; addr < PCH_GBE_PHY_REGS_LEN; addr++) {
--
1.8.1.2
next prev parent reply other threads:[~2013-06-26 1:54 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 1:53 [PATCH 0/8] MinnowBoard support Darren Hart
2013-06-26 1:53 ` Darren Hart [this message]
2013-06-26 1:53 ` [PATCH 2/8] pch_uart: Add uart_clk selection for the MinnowBoard Darren Hart
2013-06-26 2:31 ` Greg Kroah-Hartman
2013-06-26 3:16 ` Darren Hart
2013-06-26 3:39 ` Greg Kroah-Hartman
2013-06-26 3:58 ` Darren Hart
2013-06-26 4:16 ` Greg Kroah-Hartman
2013-06-26 6:43 ` Jiri Slaby
2013-06-26 7:19 ` Darren Hart
2013-06-26 7:25 ` Jiri Slaby
2013-06-26 16:23 ` Darren Hart
2013-06-26 1:53 ` [PATCH 3/8] gpio-sch: Add sch_gpio_resume_set_enable() Darren Hart
2013-06-26 21:24 ` Darren Hart
2013-06-26 1:53 ` [PATCH 4/8] minnowboard: Add base platform driver for the MinnowBoard Darren Hart
2013-06-26 4:00 ` Olof Johansson
2013-06-26 4:43 ` Darren Hart
2013-06-26 4:52 ` Matthew Garrett
2013-06-26 5:32 ` Darren Hart
2013-06-26 5:36 ` Matthew Garrett
2013-06-26 7:17 ` Darren Hart
2013-06-27 9:14 ` Linus Walleij
2013-06-28 5:43 ` Darren Hart
2013-07-04 16:26 ` Mark Brown
2013-07-20 17:37 ` Linus Walleij
2013-07-21 23:41 ` Mark Brown
2013-10-30 14:18 ` Darren Hart
2013-10-30 21:36 ` Mark Brown
2013-07-22 0:09 ` Grant Likely
2013-07-22 3:27 ` Darren Hart
2013-06-26 1:53 ` [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO Darren Hart
2013-06-26 7:55 ` Andy Shevchenko
2013-06-26 16:21 ` Darren Hart
2013-06-27 8:18 ` Andy Shevchenko
2013-06-28 4:27 ` Darren Hart
2013-06-26 1:53 ` [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys Darren Hart
2013-06-26 8:46 ` Andy Shevchenko
2013-06-26 16:28 ` Darren Hart
2013-06-26 17:16 ` Greg Kroah-Hartman
2013-06-26 17:23 ` Darren Hart
2013-06-26 19:57 ` Linus Walleij
2013-06-26 21:23 ` Darren Hart
2013-06-26 1:53 ` [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID Darren Hart
2013-06-26 16:32 ` Bjorn Helgaas
2013-06-26 17:15 ` Darren Hart
2013-06-26 19:37 ` Bjorn Helgaas
2013-06-26 21:16 ` Darren Hart
2013-06-26 21:30 ` Bjorn Helgaas
2013-06-26 21:30 ` H. Peter Anvin
2013-06-26 21:46 ` Bjorn Helgaas
2013-06-26 21:49 ` H. Peter Anvin
2013-06-26 1:53 ` [PATCH 8/8] pch_gbe: Add MinnowBoard support Darren Hart
2013-06-26 2:35 ` Bjorn Helgaas
2013-06-26 3:11 ` Darren Hart
2013-06-26 3:25 ` H. Peter Anvin
2013-06-28 5:37 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28bb2a41e403eac476c2d72a338b8c508a0219c5.1372211451.git.dvhart@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=danders@circuitco.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome