mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Darren Hart <dvhart@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	danders@circuitco.com, vishal.l.verma@intel.com,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID
Date: Wed, 26 Jun 2013 14:30:44 -0700	[thread overview]
Message-ID: <51CB5D84.4080709@zytor.com> (raw)
In-Reply-To: <CAErSpo6=1i76RRmJSUi+BpD9D0WrXaML4HkGLn0C=+6=ohB0uQ@mail.gmail.com>

On 06/26/2013 12:37 PM, Bjorn Helgaas wrote:
> 
> Yeah, that's what I was thinking.
> 
> But Peter's comment makes more sense to me now.  The spec refers to
> that config register as "Subsystem ID," not "Subsystem Device ID," but
> I was confused because most existing usage treats it as a device ID.
> For example, the field in struct pci_device_id is named "subdevice,"
> and all the existing #defines in pci_ids.h are of the form
> PCI_SUBDEVICE_ID_*.
> 
> Device IDs are pretty specific identifiers, so I was thinking that a
> "sub-device ID" would be even more specific.  Then it would make no
> sense to have a "sub-device ID" that was as generic as "MINNOWBOARD."
> But the register is actually *not* a "sub-device ID," and I can see
> that using the same Subsystem ID for all the devices on a board might
> make sense.
> 

Subsystem IDs is basically a board ID in the traditional PC view, but
they didn't call it that because it would have been confusing in other,
nontraditional configurations.

Microsoft has a "best practices" document, which may end up becoming
basis for a future PCI-SIG document clarifying the standard:

http://msdn.microsoft.com/en-us/library/windows/hardware/gg463287.aspx

	-hpa


  parent reply	other threads:[~2013-06-26 21:31 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26  1:53 [PATCH 0/8] MinnowBoard support Darren Hart
2013-06-26  1:53 ` [PATCH 1/8] pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32 Darren Hart
2013-06-26  1:53 ` [PATCH 2/8] pch_uart: Add uart_clk selection for the MinnowBoard Darren Hart
2013-06-26  2:31   ` Greg Kroah-Hartman
2013-06-26  3:16     ` Darren Hart
2013-06-26  3:39       ` Greg Kroah-Hartman
2013-06-26  3:58         ` Darren Hart
2013-06-26  4:16           ` Greg Kroah-Hartman
2013-06-26  6:43           ` Jiri Slaby
2013-06-26  7:19             ` Darren Hart
2013-06-26  7:25               ` Jiri Slaby
2013-06-26 16:23                 ` Darren Hart
2013-06-26  1:53 ` [PATCH 3/8] gpio-sch: Add sch_gpio_resume_set_enable() Darren Hart
2013-06-26 21:24   ` Darren Hart
2013-06-26  1:53 ` [PATCH 4/8] minnowboard: Add base platform driver for the MinnowBoard Darren Hart
2013-06-26  4:00   ` Olof Johansson
2013-06-26  4:43     ` Darren Hart
2013-06-26  4:52       ` Matthew Garrett
2013-06-26  5:32         ` Darren Hart
2013-06-26  5:36           ` Matthew Garrett
2013-06-26  7:17             ` Darren Hart
2013-06-27  9:14   ` Linus Walleij
2013-06-28  5:43     ` Darren Hart
2013-07-04 16:26       ` Mark Brown
2013-07-20 17:37         ` Linus Walleij
2013-07-21 23:41           ` Mark Brown
2013-10-30 14:18             ` Darren Hart
2013-10-30 21:36               ` Mark Brown
2013-07-22  0:09         ` Grant Likely
2013-07-22  3:27           ` Darren Hart
2013-06-26  1:53 ` [PATCH 5/8] minnowboard-gpio: Export MinnowBoard expansion GPIO Darren Hart
2013-06-26  7:55   ` Andy Shevchenko
2013-06-26 16:21     ` Darren Hart
2013-06-27  8:18       ` Andy Shevchenko
2013-06-28  4:27         ` Darren Hart
2013-06-26  1:53 ` [PATCH 6/8] minnowboard-keys: Bind MinnowBoard buttons to arrow keys Darren Hart
2013-06-26  8:46   ` Andy Shevchenko
2013-06-26 16:28     ` Darren Hart
2013-06-26 17:16       ` Greg Kroah-Hartman
2013-06-26 17:23         ` Darren Hart
2013-06-26 19:57           ` Linus Walleij
2013-06-26 21:23             ` Darren Hart
2013-06-26  1:53 ` [PATCH 7/8] pci: Add CircuitCo VENDOR ID and MinnowBoard DEVICE ID Darren Hart
2013-06-26 16:32   ` Bjorn Helgaas
2013-06-26 17:15     ` Darren Hart
2013-06-26 19:37       ` Bjorn Helgaas
2013-06-26 21:16         ` Darren Hart
2013-06-26 21:30           ` Bjorn Helgaas
2013-06-26 21:30         ` H. Peter Anvin [this message]
2013-06-26 21:46           ` Bjorn Helgaas
2013-06-26 21:49             ` H. Peter Anvin
2013-06-26  1:53 ` [PATCH 8/8] pch_gbe: Add MinnowBoard support Darren Hart
2013-06-26  2:35   ` Bjorn Helgaas
2013-06-26  3:11     ` Darren Hart
2013-06-26  3:25     ` H. Peter Anvin
2013-06-28  5:37   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CB5D84.4080709@zytor.com \
    --to=hpa@zytor.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=danders@circuitco.com \
    --cc=dvhart@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome