* [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs
@ 2017-10-23 23:44 Dmitry Torokhov
2017-10-24 7:08 ` Danilo Krummrich
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2017-10-23 23:44 UTC (permalink / raw)
To: linux-input; +Cc: Danilo Krummrich, Linus Walleij, linux-kernel
We've been missing a goto to the unwind path...
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/serio/ps2-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
index b50e3817f3c4..c62cceb97bb1 100644
--- a/drivers/input/serio/ps2-gpio.c
+++ b/drivers/input/serio/ps2-gpio.c
@@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device *pdev)
gpiod_cansleep(drvdata->gpio_clk)) {
dev_err(dev, "GPIO data or clk are connected via slow bus\n");
error = -EINVAL;
+ goto err_free_serio;
}
drvdata->irq = platform_get_irq(pdev, 0);
--
2.15.0.rc0.271.g36b669edcc-goog
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs
2017-10-23 23:44 [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs Dmitry Torokhov
@ 2017-10-24 7:08 ` Danilo Krummrich
0 siblings, 0 replies; 2+ messages in thread
From: Danilo Krummrich @ 2017-10-24 7:08 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Linus Walleij, linux-kernel
On 2017-10-24 01:44, Dmitry Torokhov wrote:
> We've been missing a goto to the unwind path...
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/serio/ps2-gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/serio/ps2-gpio.c
> b/drivers/input/serio/ps2-gpio.c
> index b50e3817f3c4..c62cceb97bb1 100644
> --- a/drivers/input/serio/ps2-gpio.c
> +++ b/drivers/input/serio/ps2-gpio.c
> @@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device
> *pdev)
> gpiod_cansleep(drvdata->gpio_clk)) {
> dev_err(dev, "GPIO data or clk are connected via slow bus\n");
> error = -EINVAL;
> + goto err_free_serio;
Good catch, thanks.
> }
>
> drvdata->irq = platform_get_irq(pdev, 0);
> --
> 2.15.0.rc0.271.g36b669edcc-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-24 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 23:44 [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs Dmitry Torokhov
2017-10-24 7:08 ` Danilo Krummrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome