From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Joseph Salisbury <joseph.salisbury@oracle.com>,
Cristian Prundeanu <cpru@amazon.com>,
linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
Bjoern Doebel <doebel@amazon.com>,
Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>,
Geoff Blake <blakgeof@amazon.com>,
Ali Saidi <alisaidi@amazon.com>, Csaba Csoma <csabac@amazon.com>
Subject: Re: [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them to sysctl
Date: Tue, 19 Nov 2024 11:29:07 +0100 [thread overview]
Message-ID: <3f24c6a9-27d7-46ad-a479-18a806444740@arm.com> (raw)
In-Reply-To: <ca5c6d15-7205-45e0-96a9-e78ab2a52b45@oracle.com>
On 14/11/2024 21:10, Joseph Salisbury wrote:
Hi Joseph,
> On 10/17/24 01:19, Cristian Prundeanu wrote:
[...]
> Hi Cristian,
>
> This is a confirmation that we are also seeing a 9% performance
> regression with the TPCC benchmark after v6.6-rc1. We narrowed down the
> regression was caused due to commit:
> 86bfbb7ce4f6 ("sched/fair: Add lag based placement")
>
> This regression was reported via this thread:
> https://lore.kernel.org/lkml/1c447727-92ed-416c-bca1-a7ca0974f0df@oracle.com/
>
> Phil Auld suggested to try turning off the PLACE_LAG sched feature. We
> tested with NO_PLACE_LAG and can confirm it brought back 5% of the
> performance loss. We do not yet know what effect NO_PLACE_LAG will have
> on other benchmarks, but it indeed helps TPCC.
Can you try to run mysql in SCHED_BATCH when using EEVDF?
https://lkml.kernel.org/r/20241029045749.37257-1-cpru@amazon.com
The regression went away for me when changing mysql threads to SCHED_BATCH.
You can either start mysql with 'CPUSchedulingPolicy=batch':
#cat /etc/systemd/system/mysql.service
[Service]
CPUSchedulingPolicy=batch
ExecStart=/usr/local/mysql/bin/mysqld_safe
# systemctl daemon-reload
# systemctl restart mysql
or change the policy with chrt for all mysql threads when doing
consecutive test runs starting from the 2. run ('connection' threads
have to exists already)
# chrt -b -a -p 0 $PID_MYSQL
# ps -p $PID_MYSQL -To comm,pid,tid,nice,class
COMMAND PID TID NI CLS
mysqld 4872 4872 0 B
ib_io_ibuf 4872 4878 0 B
...
xpl_accept-3 4872 4921 0 B
connection 4872 5007 0 B
...
connection 4872 5413 0 B
My hunch is that this is due to the 'connection' threads (1 per virtual
user) running in SCHED_BATCH. I yet have to confirm this by only
changing the 'connection' tasks to SCHED_BATCH.
[..]
next prev parent reply other threads:[~2024-11-19 10:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 5:19 Cristian Prundeanu
2024-10-17 5:19 ` [PATCH 1/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY Cristian Prundeanu
2024-10-17 5:20 ` [PATCH 2/2] [tip: sched/core] sched: Move PLACE_LAG and RUN_TO_PARITY to sysctl Cristian Prundeanu
2024-10-17 9:10 ` [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them " Peter Zijlstra
2024-10-17 18:19 ` Prundeanu, Cristian
2024-10-18 7:07 ` K Prateek Nayak
2024-10-18 9:54 ` Mohamed Abuelfotoh, Hazem
2024-11-14 20:10 ` Joseph Salisbury
2024-11-19 10:29 ` Dietmar Eggemann [this message]
2024-11-25 11:35 ` Cristian Prundeanu
2024-11-26 3:58 ` K Prateek Nayak
2024-11-26 15:12 ` Dietmar Eggemann
2024-11-28 10:32 ` Cristian Prundeanu
2024-11-29 10:12 ` Dietmar Eggemann
2024-10-19 2:30 Prundeanu, Cristian
2024-10-24 8:12 ` Benjamin Herrenschmidt
2024-10-25 14:43 ` Gautham R. Shenoy
2024-10-29 4:57 ` Cristian Prundeanu
2024-10-30 10:21 ` Dietmar Eggemann
2024-11-01 13:05 ` Peter Zijlstra
2024-11-04 10:19 ` Gautham R. Shenoy
2024-11-04 10:34 ` K Prateek Nayak
2025-01-19 11:04 [GIT PULL] sched/urgent for v6.13 Borislav Petkov
2025-01-28 23:09 [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them to sysctl Cristian Prundeanu
2025-02-11 3:27 ` K Prateek Nayak
2025-02-12 5:41 ` Cristian Prundeanu
2025-02-12 9:43 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f24c6a9-27d7-46ad-a479-18a806444740@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=abuehaze@amazon.com \
--cc=alisaidi@amazon.com \
--cc=blakgeof@amazon.com \
--cc=cpru@amazon.com \
--cc=csabac@amazon.com \
--cc=doebel@amazon.com \
--cc=joseph.salisbury@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®