From: "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>
To: "Prundeanu, Cristian" <cpru@amazon.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Doebel, Bjoern" <doebel@amazon.de>,
"Blake, Geoff" <blakgeof@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Csoma, Csaba" <csabac@amazon.com>,
"gautham.shenoy@amd.com" <gautham.shenoy@amd.com>
Subject: Re: [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them to sysctl
Date: Fri, 18 Oct 2024 10:54:19 +0100 [thread overview]
Message-ID: <cb7be27b-8063-4eba-98b7-3672c8c41b96@amazon.com> (raw)
In-Reply-To: <70D6B66E-B4BC-4A92-9A23-0DADE9B8C3FE@amazon.com>
>> And sysctl is arguably more of an ABI than debugfs, which
>> doesn't really sound suitable for workaround.
>>
>> And I don't see how adding a line to /etc/rc.local is harder than adding
>> a line to /etc/sysctl.conf
>
> Adding a line is equally difficult both ways, you're right. But aren't
> most distros better equipped to manage (persist, modify, automate) sysctl
> parameters in a standardized manner?
> Whereas rc.local seems more "individual need / edge case" oriented. For
> instance: changes are done by editing the file, which is poorly scriptable
> (unlike the sysctl command, which is a unified interface that reconciles
> changes); the load order is also typically late in the boot stage, making
> it not an ideal place for settings that affect system processes.
>
I'd add to what Cristian mentioned is that having these tunables as
sysctls will make them more detectable to the end users because checking
output of sysctl -a is usually one of the first steps during performance
troubleshooting vs checking /sys/kernel/debug/sched/ files so it's
easier for people to spot these configurations as sysctls if they notice
performance difference after upgrading the kernel.
Hazem
next prev parent reply other threads:[~2024-10-18 9:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 5:19 Cristian Prundeanu
2024-10-17 5:19 ` [PATCH 1/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY Cristian Prundeanu
2024-10-17 5:20 ` [PATCH 2/2] [tip: sched/core] sched: Move PLACE_LAG and RUN_TO_PARITY to sysctl Cristian Prundeanu
2024-10-17 9:10 ` [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them " Peter Zijlstra
2024-10-17 18:19 ` Prundeanu, Cristian
2024-10-18 7:07 ` K Prateek Nayak
2024-10-18 9:54 ` Mohamed Abuelfotoh, Hazem [this message]
2024-11-14 20:10 ` Joseph Salisbury
2024-11-19 10:29 ` Dietmar Eggemann
2024-11-25 11:35 ` Cristian Prundeanu
2024-11-26 3:58 ` K Prateek Nayak
2024-11-26 15:12 ` Dietmar Eggemann
2024-11-28 10:32 ` Cristian Prundeanu
2024-11-29 10:12 ` Dietmar Eggemann
2024-10-19 2:30 Prundeanu, Cristian
2024-10-24 8:12 ` Benjamin Herrenschmidt
2024-10-25 14:43 ` Gautham R. Shenoy
2024-10-29 4:57 ` Cristian Prundeanu
2024-10-30 10:21 ` Dietmar Eggemann
2024-11-01 13:05 ` Peter Zijlstra
2024-11-04 10:19 ` Gautham R. Shenoy
2024-11-04 10:34 ` K Prateek Nayak
2025-01-19 11:04 [GIT PULL] sched/urgent for v6.13 Borislav Petkov
2025-01-28 23:09 [PATCH 0/2] [tip: sched/core] sched: Disable PLACE_LAG and RUN_TO_PARITY and move them to sysctl Cristian Prundeanu
2025-02-11 3:27 ` K Prateek Nayak
2025-02-12 5:41 ` Cristian Prundeanu
2025-02-12 9:43 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7be27b-8063-4eba-98b7-3672c8c41b96@amazon.com \
--to=abuehaze@amazon.com \
--cc=alisaidi@amazon.com \
--cc=blakgeof@amazon.com \
--cc=cpru@amazon.com \
--cc=csabac@amazon.com \
--cc=doebel@amazon.de \
--cc=gautham.shenoy@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®