* [PATCH] ACPI / APEI: remove redundant variables len and node_len
@ 2017-10-15 21:24 Colin King
2017-11-28 10:51 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-10-15 21:24 UTC (permalink / raw)
To: Rafael J . Wysocki, Len Brown, Tony Luck, Borislav Petkov,
Tyler Baicar, Will Deacon, linux-acpi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variables len and node_len are redundant and can be removed. Cleans
up clang warning: node_len = GHES_ESTATUS_NODE_LEN(len);
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/acpi/apei/ghes.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 3c3a37b8503b..f2e1049232c0 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -923,7 +923,6 @@ static void ghes_print_queued_estatus(void)
struct ghes_estatus_node *estatus_node;
struct acpi_hest_generic *generic;
struct acpi_hest_generic_status *estatus;
- u32 len, node_len;
llnode = llist_del_all(&ghes_estatus_llist);
/*
@@ -935,8 +934,6 @@ static void ghes_print_queued_estatus(void)
estatus_node = llist_entry(llnode, struct ghes_estatus_node,
llnode);
estatus = GHES_ESTATUS_FROM_NODE(estatus_node);
- len = cper_estatus_len(estatus);
- node_len = GHES_ESTATUS_NODE_LEN(len);
generic = estatus_node->generic;
ghes_print_estatus(NULL, generic, estatus);
llnode = llnode->next;
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI / APEI: remove redundant variables len and node_len
2017-10-15 21:24 [PATCH] ACPI / APEI: remove redundant variables len and node_len Colin King
@ 2017-11-28 10:51 ` Borislav Petkov
2017-12-06 0:54 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2017-11-28 10:51 UTC (permalink / raw)
To: Colin King
Cc: Rafael J . Wysocki, Len Brown, Tony Luck, Tyler Baicar,
Will Deacon, linux-acpi, kernel-janitors, linux-kernel
On Sun, Oct 15, 2017 at 10:24:54PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables len and node_len are redundant and can be removed. Cleans
> up clang warning: node_len = GHES_ESTATUS_NODE_LEN(len);
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/apei/ghes.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 3c3a37b8503b..f2e1049232c0 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -923,7 +923,6 @@ static void ghes_print_queued_estatus(void)
> struct ghes_estatus_node *estatus_node;
> struct acpi_hest_generic *generic;
> struct acpi_hest_generic_status *estatus;
> - u32 len, node_len;
>
> llnode = llist_del_all(&ghes_estatus_llist);
> /*
> @@ -935,8 +934,6 @@ static void ghes_print_queued_estatus(void)
> estatus_node = llist_entry(llnode, struct ghes_estatus_node,
> llnode);
> estatus = GHES_ESTATUS_FROM_NODE(estatus_node);
> - len = cper_estatus_len(estatus);
> - node_len = GHES_ESTATUS_NODE_LEN(len);
> generic = estatus_node->generic;
> ghes_print_estatus(NULL, generic, estatus);
> llnode = llnode->next;
> --
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI / APEI: remove redundant variables len and node_len
2017-11-28 10:51 ` Borislav Petkov
@ 2017-12-06 0:54 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-12-06 0:54 UTC (permalink / raw)
To: Borislav Petkov, Colin King
Cc: Len Brown, Tony Luck, Tyler Baicar, Will Deacon, linux-acpi,
kernel-janitors, linux-kernel
On Tuesday, November 28, 2017 11:51:10 AM CET Borislav Petkov wrote:
> On Sun, Oct 15, 2017 at 10:24:54PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variables len and node_len are redundant and can be removed. Cleans
> > up clang warning: node_len = GHES_ESTATUS_NODE_LEN(len);
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/acpi/apei/ghes.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index 3c3a37b8503b..f2e1049232c0 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -923,7 +923,6 @@ static void ghes_print_queued_estatus(void)
> > struct ghes_estatus_node *estatus_node;
> > struct acpi_hest_generic *generic;
> > struct acpi_hest_generic_status *estatus;
> > - u32 len, node_len;
> >
> > llnode = llist_del_all(&ghes_estatus_llist);
> > /*
> > @@ -935,8 +934,6 @@ static void ghes_print_queued_estatus(void)
> > estatus_node = llist_entry(llnode, struct ghes_estatus_node,
> > llnode);
> > estatus = GHES_ESTATUS_FROM_NODE(estatus_node);
> > - len = cper_estatus_len(estatus);
> > - node_len = GHES_ESTATUS_NODE_LEN(len);
> > generic = estatus_node->generic;
> > ghes_print_estatus(NULL, generic, estatus);
> > llnode = llnode->next;
>
> Reviewed-by: Borislav Petkov <bp@suse.de>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-15 21:24 [PATCH] ACPI / APEI: remove redundant variables len and node_len Colin King
2017-11-28 10:51 ` Borislav Petkov
2017-12-06 0:54 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®