Re: [PATCH 02/11] PCI: tegra194: Check core reset deassertion

[Manikanta Maddireddy <mmaddireddy@nvidia.com>]

On 25/09/26 1:55 am, Andy Shevchenko wrote:
> On Wed, Sep 23, 2026 at 12:52:28PM +0530, Manikanta Maddireddy wrote:
>> Several paths access DBI registers after deasserting the controller core
>> reset. If reset_control_deassert() fails, those DBI accesses can trigger a
>> CBB timeout, or setup can return success with the core still in reset.
>>
>> Check core reset deassertion in Root Port setup, the DLF retry path and the
>> Endpoint PERST# deassert path. Unwind before DBI access when deassertion
>> fails.
> 
> ...
> 
>> +		ret = reset_control_deassert(pcie->core_rst);
>> +		if (ret) {
>> +			dev_err(pci->dev, "Failed to deassert core reset: %d\n",
>> +				ret);
> 
> We have pci_err().

Thank you for taking time to review.
pci pointer is of type "struct dw_pcie" not "struct pci_dev".

- Manikanta

> 
>> +			return ret;
>> +		}
> 

-- 
nvpublic